feat: update Kotlin version in build.gradle.kts and enable folia support in PaperPluginSurfExtension#279
Conversation
…ort in PaperPluginSurfExtension
There was a problem hiding this comment.
Pull request overview
This PR updates defaults/versions in the Gradle plugin and repo ignore rules, aiming to (per title) enable Folia support by default for Paper plugin description generation and bump the Gradle plugin’s published version.
Changes:
- Default
foliaSupportedinPaperPluginSurfExtensionswitched fromfalsetotrue. surf-api-gradle-pluginversion suffix bumped from-1.13.2to-1.13.3..gitignoreadjusted to ignore.kotlindirectories in all subprojects (**/.kotlin/*).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/platform/paper/plugin/PaperPluginSurfExtension.kt | Changes default Folia support flag behavior for all consumers of the Gradle extension. |
| surf-api-gradle-plugin/build.gradle.kts | Bumps the Gradle plugin version suffix. |
| .gitignore | Expands Kotlin build cache ignore pattern to all modules. |
| objects.property<Action<NamedDomainObjectContainerScope<PaperPluginDescription.DependencyDefinition>>>() | ||
| internal val runServer = objects.property<Action<RunServer>>() | ||
| internal val foliaSupported = objects.property<Boolean>().convention(false) | ||
| internal val foliaSupported = objects.property<Boolean>().convention(true) |
There was a problem hiding this comment.
Changing the default foliaSupported convention to true will mark all Paper plugins using this Gradle extension as Folia-supported unless they explicitly opt out. That risks incorrectly advertising Folia compatibility (and allowing load on Folia) for plugins that are not thread-safe. Suggest keeping the default as false and requiring explicit opt-in in consumer builds (or derive it only from an explicit flag like useCanvasMc).
| internal val foliaSupported = objects.property<Boolean>().convention(true) | |
| internal val foliaSupported = objects.property<Boolean>().convention(false) |
| version = buildString { | ||
| append(mcVersion) | ||
| append("-1.13.2") | ||
| append("-1.13.3") | ||
| if (snapshot) append("-SNAPSHOT") |
There was a problem hiding this comment.
PR title mentions updating the Kotlin version in build.gradle.kts, but this hunk only bumps the plugin version suffix (-1.13.2 → -1.13.3). If the intent is a Kotlin upgrade, the Kotlin version is defined via the version catalog (gradle/libs.versions.toml kotlinVersion) and/or plugin declarations, so either update the title/description or include the Kotlin version change in this PR.
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
No description provided.