chore: remove unused dependencies and update version to 1.21.11-2.75.0#280
Conversation
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
There was a problem hiding this comment.
Pull request overview
Removes the legacy StefVanschie “inventory-framework (IF)” dependency and cleans up the now-unused Surf GUI wrapper/DSL code that was built on top of it, alongside a project version bump to 1.21.11-2.75.0.
Changes:
- Drop
com.github.stefvanschie.inventoryframework:IFfrom Gradle dependencies and the version catalog. - Remove Surf GUI wrapper/DSL API and plugin-test command that depended on the StefVanschie IF types.
- Bump repository version from
1.21.11-2.74.0→1.21.11-2.75.0.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-api-bukkit/surf-api-bukkit-server/build.gradle.kts | Removes the old IF dependency from the server module dependencies. |
| surf-api-bukkit/surf-api-bukkit-plugin-test/src/main/java/dev/slne/surf/surfapi/bukkit/test/command/SurfApiTestCommand.java | Removes the InventoryFramework test subcommand and expands imports (plus formatting changes). |
| surf-api-bukkit/surf-api-bukkit-plugin-test/src/main/java/dev/slne/surf/surfapi/bukkit/test/command/subcommands/gui/InventoryFrameworkTest.java | Deletes the test command that directly used StefVanschie IF APIs. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/types/SurfChestGui.kt | Deletes the SurfChestGui wrapper around StefVanschie IF ChestGui. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/SurfGui.kt | Deletes the base SurfGui abstraction around StefVanschie IF NamedGui. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/SinglePlayerGui.kt | Deletes the SinglePlayerGui convenience interface. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/pane/SubmitItemPane.kt | Deletes a custom Pane implementation built on StefVanschie IF. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/item/SurfGuiItem.kt | Deletes SurfGuiItem wrapper built on StefVanschie IF GuiItem. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/item/GuiItem.kt | Deletes guiItem(...) factory helpers for StefVanschie IF GuiItem. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/item/button.kt | Removes placeholder file under the old GUI item package. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/dsl/slot.kt | Deletes Slot helper functions tied to StefVanschie IF Slot. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/dsl/patterns.kt | Removes placeholder DSL file associated with the old Slot helpers. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/dsl/panes.kt | Deletes pane/outline DSL helpers targeting StefVanschie IF panes. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/dsl/markers.kt | Deletes the old PaneMarker DSL marker annotation. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/inventory/dsl/gui.kt | Deletes the old menu/playerMenu DSL built on StefVanschie IF. |
| surf-api-bukkit/surf-api-bukkit-api/build.gradle.kts | Removes compileOnlyApi dependency on StefVanschie IF. |
| gradle/libs.versions.toml | Removes the stefvanschie-if version and library entry from the catalog. |
| gradle.properties | Bumps overall project version to 1.21.11-2.75.0. |
| mcVersion=1.21.11 | ||
| group=dev.slne.surf | ||
| version=1.21.11-2.74.0 | ||
| version=1.21.11-2.75.0 |
There was a problem hiding this comment.
The PR title suggests only dependency cleanup + version bump, but this change set also deletes multiple public inventory GUI API types from surf-api-bukkit-api (e.g., SurfGui, SinglePlayerGui, SurfChestGui, SubmitItemPane, and related DSL helpers). That’s a potentially breaking change for downstream consumers; please align the PR title/description and ensure the versioning/release notes communicate the API removal (or consider a deprecation/migration path).
| public class SurfApiTestCommand extends CommandAPICommand { | ||
|
|
||
| public SurfApiTestCommand() { | ||
| super("surfapitest"); | ||
| public SurfApiTestCommand() { | ||
| super("surfapitest"); | ||
|
|
||
| withPermission("surfapitest.use"); | ||
| withPermission("surfapitest.use"); |
There was a problem hiding this comment.
This file uses 4-space indentation, but the other CommandAPI Java subcommands in this module use 2-space indentation (e.g. PacketLoreTest.java). To keep formatting consistent across the plugin-test commands, reformat this class to match the existing indentation style.
No description provided.