chore/correct-register-required#290
Merged
Merged
Conversation
| @@ -7,6 +7,6 @@ org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled | |||
| javaVersion=25 | |||
| mcVersion=26.1 | |||
There was a problem hiding this comment.
version now starts with 26.1.1 while mcVersion is still 26.1. This breaks the repo’s versioning convention of {MC_VERSION}-{LIB_VERSION} (see guidelines example 1.21.11-2.62.0). Align these by either updating mcVersion to 26.1.1 or reverting the version prefix to 26.1 so they match.
Suggested change
| mcVersion=26.1 | |
| mcVersion=26.1.1 |
| mcVersion=26.1 | ||
| group=dev.slne.surf | ||
| version=26.1-3.0.2 | ||
| version=26.1.1-3.0.2 |
There was a problem hiding this comment.
PR title suggests a change around "register required", but the only change in this PR is a version string update in gradle.properties. If the intent is to correct the project version, consider renaming the PR to reflect that; otherwise, the missing functional changes may have been omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.