refactor: update reflection proxies and improve JSON serialization for player stats#291
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Paper server-side reflection/NMS bridges to align with updated Minecraft internals: player stats JSON is now produced via JsonElement + Gson, and item component mutation is done via registry holder binding instead of a custom reflection proxy.
Changes:
- Update
ServerStatsCounterProxy.toJsonto return aJsonElementand expose the underlying staticGSONvia a reflection-remapper@FieldGetter. - Remove the custom
ItemProxyreflection abstraction and update item component updates to usebuiltInRegistryHolder().bindComponents(...). - Bump project version to
26.1.1-3.0.3.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/reflection/ServerStatsCounterProxy.kt | Adjust stats JSON proxy to return JsonElement and add static GSON access. |
| surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/reflection/Reflection.kt | Remove ITEM_PROXY wiring from the central reflection registry. |
| surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/reflection/ItemProxy.kt | Delete obsolete reflection proxy for mutating Item.components. |
| surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/impl/nms/bridges/SurfPaperNmsStatsBridgeImpl.kt | Serialize player stats by converting JsonElement to String with the server’s Gson. |
| surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/impl/nms/bridges/SurfPaperNmsItemBridgeImpl.kt | Switch item component mutation to bindComponents instead of reflection-based field mutation. |
| gradle.properties | Increment version to 26.1.1-3.0.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.