chore: update group ID and versioning scheme, adjust repository URLs#293
Conversation
There was a problem hiding this comment.
Pull request overview
Updates build/publishing metadata to reflect a new Maven group ID and versioning scheme, and migrates repository endpoints from repo.slne.dev to reposilite.slne.dev.
Changes:
- Switch project
grouptodev.slne.surf.apiand remove themcVersion-prefix from several published module versions. - Update repository URLs/names across Gradle scripts and repository helper extensions.
- Adjust published dependency coordinates for Surf API platform artifacts to the new group ID.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
surf-api-gradle-plugin/surf-api-processor/build.gradle.kts |
Removes mcVersion-based version prefix for the processor artifact. |
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/util/repo-extensions.kt |
Migrates public/releases/private repo URLs + repo names to the new Reposilite endpoints. |
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/SurfApiPlatform.kt |
Updates Surf API dependency coordinates to the new dev.slne.surf.api group. |
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/common/CommonSurfPlugin.kt |
Changes how optional dependencies (core module/redis/db) are declared (now using dynamic +). |
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/common/CommonSurfExtension.kt |
Updates default publishing repo URL/name to Reposilite releases. |
surf-api-gradle-plugin/README.md |
Removes Gradle plugin installation/usage documentation. |
surf-api-gradle-plugin/build.gradle.kts |
Removes mcVersion-based version prefix and updates plugin publishing repo + generated constants repo IDs/URLs. |
gradle/libs.versions.toml |
Formatting-only change for a dependency declaration. |
gradle.properties |
Updates root group and root version to the new scheme. |
buildSrc/src/main/kotlin/publish-convention.gradle.kts |
Updates publishing repo URL/name to Reposilite releases. |
buildSrc/src/main/kotlin/core-convention.gradle.kts |
Updates public repository URL/name to Reposilite public. |
Comments suppressed due to low confidence (1)
surf-api-gradle-plugin/README.md:1
- The installation/usage documentation for the Gradle plugin is removed entirely. If this is intentional, consider replacing it with updated instructions (new groupId/version scheme and new repository URLs) or a pointer to the canonical docs location so consumers aren’t left without setup guidance.
| add( | ||
| COMPILE_ONLY, | ||
| "dev.slne.surf.core:${it.module}:${Constants.SURF_API_VERSION}" | ||
| "dev.slne.surf.core:${it.module}:+" |
There was a problem hiding this comment.
Using a dynamic version selector (+) for the core module dependency makes builds non-reproducible and can pull an incompatible artifact (especially now that it no longer includes the Minecraft-version prefix previously provided by Constants.SURF_API_VERSION). Prefer an explicit version (e.g., keep using Constants.SURF_API_VERSION or a version provided via the extension) to ensure deterministic resolution.
| "dev.slne.surf.core:${it.module}:+" | |
| "dev.slne.surf.core:${it.module}:${Constants.SURF_API_VERSION}" |
| if (extension.withSurfRedis.get()) { | ||
| if (extension.surfRedisRelocation.isPresent) { | ||
| dependencies { | ||
| add(API, "dev.slne.surf.redis:surf-redis:${extension.surfRedisVersion.get()}") | ||
| add(API, "dev.slne.surf.redis:surf-redis:+") | ||
| } |
There was a problem hiding this comment.
surf-redis is now added with a + dynamic version, which (1) makes dependency resolution non-deterministic and (2) ignores the extension’s configured Redis version (e.g., surfRedisVersion set by withSurfRedis(version, relocation)). Please switch back to a deterministic version (prefer the extension-provided version when set, otherwise a well-defined default) so consumer builds don’t unexpectedly change or break.
| dependencies { | ||
| add( | ||
| COMPILE_ONLY, | ||
| "dev.slne.surf.redis:surf-redis-api:${Constants.SURF_API_VERSION}" | ||
| "dev.slne.surf.redis:surf-redis-api:+" | ||
| ) |
There was a problem hiding this comment.
surf-redis-api is now declared with a + dynamic version, which can pull arbitrary newer (or incompatible) releases and makes builds non-reproducible. Use an explicit version aligned with the rest of the plugin’s versioning scheme (e.g., a constant or an extension property) to keep dependency resolution deterministic.
| dependencies { | ||
| add( | ||
| API, | ||
| "dev.slne.surf:surf-database-r2dbc:${extension.surfDatabaseR2dbcVersion.get()}" | ||
| "dev.slne.surf:surf-database-r2dbc:+" | ||
| ) |
There was a problem hiding this comment.
surf-database-r2dbc is now declared with a + dynamic version, which makes builds non-reproducible and also ignores the version configured via withSurfDatabaseR2dbc(version, relocation) (surfDatabaseR2dbcVersion). Prefer resolving a deterministic version (use the extension-provided version when set, or define a stable default) so consumers don’t get unexpected upgrades.
No description provided.