✨ feat(plugin): add support for surf-npc integration in PaperPluginSurf#342
Merged
Conversation
Member
TheBjoRedCraft
commented
May 9, 2026
TheBjoRedCraft
commented
- update version to 2.0.5 in build.gradle.kts
- introduce installSurfNpc property in PaperPluginSurfExtension
- add withSurfNpc method to enable surf-npc integration
- conditionally add surf-npc dependencies in PaperPluginSurfPlugin
- update version to 2.0.5 in build.gradle.kts - introduce installSurfNpc property in PaperPluginSurfExtension - add withSurfNpc method to enable surf-npc integration - conditionally add surf-npc dependencies in PaperPluginSurfPlugin
twisti-dev
approved these changes
May 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in Surf NPC integration toggle to the Paper Gradle plugin (dev.slne.surf.api.gradle.paper-plugin), so downstream Paper plugin projects can easily compile against surf-npc-api and declare a required runtime dependency on the surf-npc-paper plugin.
Changes:
- Bump
surf-api-gradle-pluginversion to2.0.5. - Add
withSurfNpc()toPaperPluginSurfExtension(backed by an internalinstallSurfNpcflag). - When enabled, automatically add
surf-npc-apias acompileOnlydependency and registersurf-npc-paperas a required server dependency in the generated Paper plugin.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/paper/plugin/PaperPluginSurfPlugin.kt |
Conditionally adds surf-npc-api to compileOnly and registers surf-npc-paper as a required server dependency. |
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/platform/paper/plugin/PaperPluginSurfExtension.kt |
Introduces the opt-in flag and exposes withSurfNpc() to enable integration from build scripts. |
surf-api-gradle-plugin/build.gradle.kts |
Updates plugin version to 2.0.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.