✨ feat(command): add (async) (offline) player argument support#345
Closed
TheBjoRedCraft wants to merge 2 commits into
Closed
✨ feat(command): add (async) (offline) player argument support#345TheBjoRedCraft wants to merge 2 commits into
TheBjoRedCraft wants to merge 2 commits into
Conversation
TheBjoRedCraft
commented
May 12, 2026
TheBjoRedCraft
commented
Member
- implement AsyncOfflinePlayerArgument for non-blocking offline player retrieval
- create OfflinePlayerArgument and PlayerArgument for consistent player argument handling
- update gradle.properties to version 3.10.1
- implement AsyncOfflinePlayerArgument for non-blocking offline player retrieval - create OfflinePlayerArgument and PlayerArgument for consistent player argument handling - update gradle.properties to version 3.10.1
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new CommandAPI argument helpers in the Paper module to resolve online/offline players consistently, including an async variant intended to avoid blocking offline player lookups, and bumps the project version.
Changes:
- Introduce
PlayerArgument,OfflinePlayerArgument, andAsyncOfflinePlayerArgumentargument types + DSL-style extension functions forCommandTree,Argument, andCommandAPICommand. - Provide tab-completion suggestions for these arguments based on online player names.
- Bump
versionto3.10.1.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| surf-api-paper/surf-api-paper/src/main/kotlin/dev/slne/surf/api/paper/command/args/audience/PlayerArgument.kt | Adds a custom online player argument with suggestions and an error message when not found. |
| surf-api-paper/surf-api-paper/src/main/kotlin/dev/slne/surf/api/paper/command/args/audience/OfflinePlayerArgument.kt | Adds a custom offline player argument with online-name suggestions. |
| surf-api-paper/surf-api-paper/src/main/kotlin/dev/slne/surf/api/paper/command/args/audience/AsyncOfflinePlayerArgument.kt | Adds a coroutine-based async offline player argument using SuspendCustomArgument. |
| gradle.properties | Bumps project version to 3.10.1. |
Comment on lines
+14
to
+17
| CustomArgument<Player, String>(StringArgument(nodeName), { info -> | ||
| Bukkit.getPlayer(info.input)?.takeIf { | ||
| info.sender !is Player || it.canSee(it) | ||
| } ?: throw CustomArgumentException.fromAdventureComponent( |
Comment on lines
+24
to
+28
| this.replaceSuggestions( | ||
| ArgumentSuggestions.stringCollection { viewerInfo -> | ||
| Bukkit.getOnlinePlayers().filter { viewerInfo.sender !is Player || it.canSee(it) } | ||
| .map(Player::getName) | ||
| } |
| init { | ||
| this.replaceSuggestions( | ||
| ArgumentSuggestions.stringCollection { viewerInfo -> | ||
| Bukkit.getOnlinePlayers().filter { viewerInfo.sender !is Player || it.canSee(it) } |
| init { | ||
| this.replaceSuggestions( | ||
| ArgumentSuggestions.stringCollection { viewerInfo -> | ||
| Bukkit.getOnlinePlayers().filter { viewerInfo.sender !is Player || it.canSee(it) } |
Contributor
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
- packetevents: 2.11.2 → 2.12.1
Contributor
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
Contributor
|
Paper macht den permission checkt auch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.