Skip to content

chore: bump scoreboard library to 2.3.0 and simplify transitive dependencies#87

Merged
twisti-dev merged 2 commits into
version/1.21from
chor/update-scoreboard-deps
Apr 20, 2025
Merged

chore: bump scoreboard library to 2.3.0 and simplify transitive dependencies#87
twisti-dev merged 2 commits into
version/1.21from
chor/update-scoreboard-deps

Conversation

@twisti-dev

Copy link
Copy Markdown
Contributor

Overview of Changes

This PR updates the scoreboard library dependencies across modules to version 2.3.0, adjusts build configurations to disable transitive dependencies where unnecessary, and performs general cleanup of .idea and project metadata files.

Details

  • Dependency Version Bump

    • Updated scoreboard-library, scoreboard-library-implementation, and scoreboard-library-modern to 2.3.0 in libs.versions.toml.
  • Gradle Configuration

    • Set isTransitive = false for scoreboard dependencies in surf-api-bukkit-api and surf-api-bukkit-server to prevent unwanted transitive dependency resolution.
  • Project Version Update

    • Incremented version in gradle.properties to 1.21.4-2.13.3-SNAPSHOT.
  • IDE and Metadata Cleanup

    • Removed redundant or obsolete module entries from .idea/modules.xml.
    • Cleared out old compiler options in .idea/compiler.xml.
    • Removed a blank line in CommonComponents.kt for minor style consistency.

Motivation

These changes ensure the project uses the latest features and fixes in the scoreboard library, reduce dependency bloat, and clean up legacy project configurations that may cause IDE or build inconsistencies.

Impact

  • Keeps dependencies up to date with the latest stable versions.
  • Reduces unnecessary transitive dependencies for a cleaner classpath.
  • Simplifies project structure by pruning outdated .idea configurations.

Testing

  • Build and dependency resolution tested locally with updated versions.
  • Modules dependent on scoreboard libraries confirmed to compile without issues.
  • Manual inspection of .idea cleanup to ensure no critical entries were removed.

Additional Notes

Consider running a ./gradlew dependencies check on affected modules to confirm minimal transitive pull after this change.

@twisti-dev twisti-dev requested a review from Copilot April 20, 2025 22:46
@twisti-dev twisti-dev self-assigned this Apr 20, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request bumps the scoreboard library dependencies to 2.3.0, updates relevant Gradle configurations to disable unnecessary transitive dependencies, and performs minor project metadata and code style cleanup.

  • Updated scoreboard-library versions in libs.versions.toml.
  • Removed an extraneous blank line in CommonComponents.kt for style consistency.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

File Description
surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt Removed an unnecessary blank line to improve code style.
gradle/libs.versions.toml Updated scoreboard library dependencies from 2.2.2 to 2.3.0.
Files not reviewed (5)
  • .idea/compiler.xml: Language not supported
  • .idea/modules.xml: Language not supported
  • gradle.properties: Language not supported
  • surf-api-bukkit/surf-api-bukkit-api/build.gradle.kts: Language not supported
  • surf-api-bukkit/surf-api-bukkit-server/build.gradle.kts: Language not supported

# Conflicts:
#	surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt
@twisti-dev twisti-dev merged commit 874bcb9 into version/1.21 Apr 20, 2025
@twisti-dev twisti-dev deleted the chor/update-scoreboard-deps branch April 20, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants