chore: bump scoreboard library to 2.3.0 and simplify transitive dependencies#87
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request bumps the scoreboard library dependencies to 2.3.0, updates relevant Gradle configurations to disable unnecessary transitive dependencies, and performs minor project metadata and code style cleanup.
- Updated scoreboard-library versions in libs.versions.toml.
- Removed an extraneous blank line in CommonComponents.kt for style consistency.
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt | Removed an unnecessary blank line to improve code style. |
| gradle/libs.versions.toml | Updated scoreboard library dependencies from 2.2.2 to 2.3.0. |
Files not reviewed (5)
- .idea/compiler.xml: Language not supported
- .idea/modules.xml: Language not supported
- gradle.properties: Language not supported
- surf-api-bukkit/surf-api-bukkit-api/build.gradle.kts: Language not supported
- surf-api-bukkit/surf-api-bukkit-server/build.gradle.kts: Language not supported
# Conflicts: # surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
This PR updates the scoreboard library dependencies across modules to version
2.3.0, adjusts build configurations to disable transitive dependencies where unnecessary, and performs general cleanup of.ideaand project metadata files.Details
Dependency Version Bump
scoreboard-library,scoreboard-library-implementation, andscoreboard-library-modernto2.3.0inlibs.versions.toml.Gradle Configuration
isTransitive = falsefor scoreboard dependencies insurf-api-bukkit-apiandsurf-api-bukkit-serverto prevent unwanted transitive dependency resolution.Project Version Update
versioningradle.propertiesto1.21.4-2.13.3-SNAPSHOT.IDE and Metadata Cleanup
.idea/modules.xml..idea/compiler.xml.CommonComponents.ktfor minor style consistency.Motivation
These changes ensure the project uses the latest features and fixes in the scoreboard library, reduce dependency bloat, and clean up legacy project configurations that may cause IDE or build inconsistencies.
Impact
.ideaconfigurations.Testing
.ideacleanup to ensure no critical entries were removed.Additional Notes
Consider running a
./gradlew dependenciescheck on affected modules to confirm minimal transitive pull after this change.