fix(redis): avoid poisoning Lua SHA cache on transient load failures#56
Draft
twisti-dev wants to merge 1 commit into
Draft
fix(redis): avoid poisoning Lua SHA cache on transient load failures#56twisti-dev wants to merge 1 commit into
twisti-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mono<String>fromscript.scriptLoad(...).cache(), andMono.cache()retains terminal errors which can permanently replay transientSCRIPT LOADfailures.Description
scriptShasfromConcurrentHashMap<String, Mono<String>>toConcurrentHashMap<String, String>so the map stores concrete SHA strings rather thanMonoinstances.getShato returnMono.just(cachedSha)when present, or callscript.scriptLoad(...)and store the SHA intoscriptShasviadoOnNextonly after a successful load.executebehavior, includingRedisNoScriptExceptionremoval of the cached SHA and the retry policy, so functionality is unchanged except for avoiding cached load errors.Testing
./gradlew --no-daemon -q :surf-redis-core:compileKotlin, but the build requires Java 25 while the environment provides Java 21, so compilation could not be completed.Codex Task