Skip to content

Commit 15205c6

Browse files
authored
Update README.md
missing word
1 parent 9af94c2 commit 15205c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ If you were already using an old version prior to RH Topic Tags v3.0.2, then the
254254
- Going to `https://yoursite.com/tags/` does not work, only `https://yoursite.com/tags` with no trailing slash, but these URLs canonically should be treated as equivalent. There is a `https://yoursite.com/tags/suggest` page (loading a script that takes data from another, and is used by various functions), so `https://yoursite.com/tags/` does actually exist. Fixing this will have something to do with `controller/main.php`.
255255
- See `add-on-comma="false"` in `adm/style/topictags_blacklist.html`, `adm/style/topictags_whitelist.html`, `styles/all/template/event/posting_editor_subject_after.html`, ``, possibly in other places. May be possible to turn on ability of comma to serve same as Enter/Return in ending a tag, which is common/expected behavior, and makes sense since commas cannot be used in tags anyway.
256256
- There is a significant amount of code in here (e.g. in `service/tags_manager.php`) to support an option for case-sensitive tagging (or at least case-sensitive sorting and other display considerations regarding tagging; the full intent isn't clear yet). But there is no ACP option to enable such a thing, it's always defaulting to "false" or was even hard-coded that way in a few places (i.e. to be case-insensitive).
257-
- Case-sensitivity of actual tags would probably be undesirable for most use-cases (e.g. if someone created a "YouTube" tag and someone else wrotes it as "Youtube" or "youtube" or "YOUTUBE" you'd end up with redundant tags, and this is especially likely on a busy board with many topics and users). But a niche recipe site with tagging controlled by only a few editors, for example, might want to distinguish between Turkey the country and turkey the bird or between Chile the country and chile the pepper. So, having a way to enable this is planned future upgrade.
257+
- Case-sensitivity of actual tags would probably be undesirable for most use-cases (e.g. if someone created a "YouTube" tag and someone else wrotes it as "Youtube" or "youtube" or "YOUTUBE" you'd end up with redundant tags, and this is especially likely on a busy board with many topics and users). But a niche recipe site with tagging controlled by only a few editors, for example, might want to distinguish between Turkey the country and turkey the bird or between Chile the country and chile the pepper. So, having a way to enable this is a planned future upgrade.
258258
- In `service/tags_manager.php` there is a "Note: that $query needs to be at least 3 characters long", and code like `if (utf8_strlen($query) < 3)`; this may have to be changed entirely and properly support 2- and 1-character tags in every circumstance, though in testing so far they have been working fine anyway. Depends on exactly what circumstances this 3-char. constraint is being applied to. So far, it looks like this only affects `get_tag_suggestions()`.
259259
- Not an "issue", per se, but the original codebase seemed to be expecting 4 spaces per tab (in most cases, but was not entirely consistent in alignment). I've thus been using 4-per-tab for this project. It may look weird if you're set for 8-per-tab.
260260
- RH used v2.1.1 of ngTagsInput and then custom tweaked it to work around a bug, and this extension has continued with RH's "v2.1.1-1" for years. But ngTagsInput is now at v3.2.0 and apparently has the underlying issue fixed, so the code should be reworked to use that version probably. It's unclear at this point what (if anything) would break if v3.2.0 were just swapped in. Odds are that the syntax of how it is called would have to change in some way.

0 commit comments

Comments
 (0)