Skip to content

Commit 15eae35

Browse files
committed
reverted supplier usage which isn't required
1 parent 7b3a227 commit 15eae35

3 files changed

Lines changed: 11 additions & 16 deletions

File tree

sormas-backend/src/main/java/de/symeda/sormas/backend/patch/DataPatcherImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,10 @@ public DataPatchResponse patch(CaseDataPatchRequest request) {
190190
return response.setApplied(true);
191191
}
192192

193-
private static @NotNull Map<CustomizableContextIndexKey, Supplier<String>> buildEntityUuidDictionaryFrom(
193+
private static @NotNull Map<CustomizableContextIndexKey, String> buildEntityUuidDictionaryFrom(
194194
Map<Tuple<String, Integer>, AttachedEntityWrapper> entityCache,
195195
CaseDataDto caseData) {
196-
Map<CustomizableContextIndexKey, Supplier<String>> temporaryResult = entityCache.entrySet()
196+
Map<CustomizableContextIndexKey, String> temporaryResult = entityCache.entrySet()
197197
.stream()
198198
.map(
199199
entry -> CustomizableFieldContextPatchMapping.fromI18nName(entry.getKey().getFirst())
@@ -202,7 +202,7 @@ public DataPatchResponse patch(CaseDataPatchRequest request) {
202202
new CustomizableContextIndexKey().setContext(context).setGroupIndex(entry.getKey().getSecond()),
203203
entry.getValue().getEntityDto().getUuid())))
204204
.flatMap(Optional::stream)
205-
.collect(Collectors.toMap(Tuple::getFirst, t -> t::getSecond));
205+
.collect(Collectors.toMap(Tuple::getFirst, Tuple::getSecond));
206206

207207
if (temporaryResult.keySet().stream().anyMatch(key -> key.getContext() == CustomizableFieldContext.EPIDATA)) {
208208
return temporaryResult;
@@ -214,7 +214,7 @@ public DataPatchResponse patch(CaseDataPatchRequest request) {
214214
Stream.of(
215215
new AbstractMap.SimpleEntry<>(
216216
new CustomizableContextIndexKey().setContext(CustomizableFieldContext.EPIDATA),
217-
(Supplier<String>) () -> caseData.getEpiData().getUuid())))
217+
caseData.getEpiData().getUuid())))
218218
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
219219
}
220220

sormas-backend/src/main/java/de/symeda/sormas/backend/patch/customizablefield/CustomizableFieldDataPatchRequest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.util.List;
44
import java.util.Map;
55
import java.util.Objects;
6-
import java.util.function.Supplier;
76

87
import javax.validation.constraints.NotNull;
98

@@ -23,7 +22,7 @@ public final class CustomizableFieldDataPatchRequest {
2322
private CaseDataDto caseDataDto;
2423

2524
@NotNull
26-
private Map<CustomizableContextIndexKey, Supplier<String>> entityUuidDictionary;
25+
private Map<CustomizableContextIndexKey, String> entityUuidDictionary;
2726

2827
public CaseDataPatchRequest getCaseDataPatchRequest() {
2928
return caseDataPatchRequest;
@@ -52,11 +51,11 @@ public CustomizableFieldDataPatchRequest setCaseDataDto(CaseDataDto caseDataDto)
5251
return this;
5352
}
5453

55-
public Map<CustomizableContextIndexKey, Supplier<String>> getEntityUuidDictionary() {
54+
public Map<CustomizableContextIndexKey, String> getEntityUuidDictionary() {
5655
return entityUuidDictionary;
5756
}
5857

59-
public CustomizableFieldDataPatchRequest setEntityUuidDictionary(Map<CustomizableContextIndexKey, Supplier<String>> entityUuidDictionary) {
58+
public CustomizableFieldDataPatchRequest setEntityUuidDictionary(Map<CustomizableContextIndexKey, String> entityUuidDictionary) {
6059
this.entityUuidDictionary = entityUuidDictionary;
6160
return this;
6261
}

sormas-backend/src/main/java/de/symeda/sormas/backend/patch/customizablefield/CustomizableFieldDataPatcher.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.Optional;
88
import java.util.Set;
99
import java.util.function.Function;
10-
import java.util.function.Supplier;
1110
import java.util.stream.Collectors;
1211

1312
import javax.ejb.EJB;
@@ -184,19 +183,16 @@ private Map<CustomizableFieldContext, Map<CustomizableFieldMetadataDto, Function
184183
contexts.stream().map(context -> {
185184
List<CustomizableFieldMetadataDto> activeFieldsForContext = metaDataFacade.getActiveFieldsForContext(context);
186185

187-
Map<CustomizableContextIndexKey, Supplier<String>> entityUuidDictionary = request.getEntityUuidDictionary();
186+
Map<CustomizableContextIndexKey, String> entityUuidDictionary = request.getEntityUuidDictionary();
188187

189188
Map<String, Map<CustomizableFieldMetadataDto, CustomizableFieldValueDto>> entityValuesCache = new HashMap<>();
190189

191190
Map<CustomizableFieldMetadataDto, Function<CustomizablePatchField, CustomizableFieldValueDto>> valueProviderDictionary =
192191
activeFieldsForContext.stream().collect(Collectors.toMap(Function.identity(), metaData -> (customizablePatchField) -> {
193192

194-
String entityUuid =
195-
entityUuidDictionary
196-
.get(
197-
new CustomizableContextIndexKey().setContext(customizablePatchField.getContext())
198-
.setGroupIndex(customizablePatchField.getGroupIndex()))
199-
.get();
193+
String entityUuid = entityUuidDictionary.get(
194+
new CustomizableContextIndexKey().setContext(customizablePatchField.getContext())
195+
.setGroupIndex(customizablePatchField.getGroupIndex()));
200196

201197
Map<CustomizableFieldMetadataDto, CustomizableFieldValueDto> alreadyExistingValuesForEntity =
202198
entityValuesCache.computeIfAbsent(entityUuid, uuid -> valueFacade.getValuesForEntity(uuid, context));

0 commit comments

Comments
 (0)