Skip to content

Commit 1a33b3c

Browse files
committed
💄🔥: Adjusted ordering & Removed Serogroup input
1 parent e39a04e commit 1a33b3c

1 file changed

Lines changed: 2 additions & 24 deletions

File tree

sormas-ui/src/main/java/de/symeda/sormas/ui/dashboard/sample/SampleDashboardFilterLayout.java

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,13 @@
2525
import org.apache.commons.collections4.CollectionUtils;
2626

2727
import com.vaadin.v7.ui.ComboBox;
28-
import com.vaadin.v7.ui.TextField;
2928

3029
import de.symeda.sormas.api.Disease;
3130
import de.symeda.sormas.api.FacadeProvider;
3231
import de.symeda.sormas.api.caze.CaseDataDto;
3332
import de.symeda.sormas.api.customizableenum.CustomizableEnumType;
3433
import de.symeda.sormas.api.disease.DiseaseVariant;
3534
import de.symeda.sormas.api.environment.environmentsample.EnvironmentSampleMaterial;
36-
import de.symeda.sormas.api.i18n.Captions;
3735
import de.symeda.sormas.api.i18n.Descriptions;
3836
import de.symeda.sormas.api.i18n.I18nProperties;
3937
import de.symeda.sormas.api.i18n.Strings;
@@ -52,21 +50,18 @@ public class SampleDashboardFilterLayout extends DashboardFilterLayout<SampleDas
5250
public static final String SAMPLE_MATERIAL_FILTER = "sampleMaterialFilter";
5351
public static final String DISEASE_FILTER = "diseaseFilter";
5452
public static final String PATHOGEN_TEST_RESULT_FILTER = "pathogenTestResultFilter";
55-
public static final String SEROGROUP_FILTER = "serogroupFilter";
5653
public static final String DISEASE_VARIANT_FILTER = "diseaseVariantFilter";
5754

5855
private final static String[] FILTERS = new String[] {
5956
DATE_TYPE_FILTER,
6057
REGION_FILTER,
6158
DISTRICT_FILTER,
6259
SAMPLE_MATERIAL_FILTER,
63-
DISEASE_FILTER,
6460
PATHOGEN_TEST_RESULT_FILTER,
65-
SEROGROUP_FILTER,
61+
DISEASE_FILTER,
6662
DISEASE_VARIANT_FILTER };
6763

6864
private ComboBox pathogenTestResultFilter;
69-
private TextField serogroupFilter;
7065
private ComboBox diseaseVariantFilter;
7166

7267
public SampleDashboardFilterLayout(SampleDashboardView dashboardView, SampleDashboardDataProvider dashboardDataProvider) {
@@ -81,9 +76,8 @@ public void populateLayout() {
8176
createRegionFilter(I18nProperties.getDescription(Descriptions.sampleDashboardRegionFilter));
8277
createDistrictFilter(I18nProperties.getDescription(Descriptions.sampleDashboardDistrictFilter));
8378
createPathogenTestResultFilter();
84-
createSerogroupFilter();
85-
createDiseaseVariantFilter();
8679
createSampleMaterialFilter();
80+
createDiseaseVariantFilter();
8781
createDiseaseFilter();
8882
}
8983

@@ -146,29 +140,13 @@ private void createPathogenTestResultFilter() {
146140
addCustomComponent(pathogenTestResultFilter, PATHOGEN_TEST_RESULT_FILTER);
147141
}
148142

149-
private void createSerogroupFilter() {
150-
serogroupFilter = new TextField();
151-
serogroupFilter.setWidth(200, Unit.PIXELS);
152-
serogroupFilter.setNullRepresentation("");
153-
serogroupFilter.setInputPrompt(I18nProperties.getCaption(Captions.serogroup));
154-
serogroupFilter.setValue(dashboardDataProvider.getSerogroup());
155-
serogroupFilter.addValueChangeListener(e -> dashboardDataProvider.setSerogroup(serogroupFilter.getValue()));
156-
addCustomComponent(serogroupFilter, SEROGROUP_FILTER);
157-
}
158-
159143
private void setLabFiltersEnabled(boolean enabled) {
160144
if (pathogenTestResultFilter != null) {
161145
pathogenTestResultFilter.setEnabled(enabled);
162146
if (!enabled) {
163147
pathogenTestResultFilter.setValue(null);
164148
}
165149
}
166-
if (serogroupFilter != null) {
167-
serogroupFilter.setEnabled(enabled);
168-
if (!enabled) {
169-
serogroupFilter.setValue(null);
170-
}
171-
}
172150
if (diseaseVariantFilter != null) {
173151
// When re-enabling, the variant combo's own per-disease logic governs its enabled state.
174152
if (enabled) {

0 commit comments

Comments
 (0)