before commenting audit logging.

Author: Pa-Touche

sormas-api/src/main/java/de/symeda/sormas/api/ConfigFacade.java

@@ -21,18 +21,20 @@
 import java.util.stream.Collectors;
 
 import javax.annotation.Nullable;
+import javax.ejb.Remote;
 import javax.validation.constraints.NotNull;
 
-import de.symeda.sormas.api.externaljournal.PatientDiaryConfig;
-import de.symeda.sormas.api.externaljournal.SymptomJournalConfig;
-import de.symeda.sormas.api.sormastosormas.SormasToSormasConfig;
 import org.apache.commons.lang3.CharUtils;
 import org.apache.commons.lang3.StringUtils;
 
+import de.symeda.sormas.api.externaljournal.PatientDiaryConfig;
+import de.symeda.sormas.api.externaljournal.SymptomJournalConfig;
 import de.symeda.sormas.api.geo.GeoLatLon;
 import de.symeda.sormas.api.i18n.I18nProperties;
+import de.symeda.sormas.api.sormastosormas.SormasToSormasConfig;
 import de.symeda.sormas.api.systemconfiguration.Config;
 
+@Remote
 public interface ConfigFacade {
 
 	String SORMAS = "SORMAS";
@@ -125,7 +127,7 @@ default Set<String> getAllowedFileExtensions() {
 
 	@NotNull
 	default String getSormasInstanceName() {
-		return getAsBoolean(Config.CUSTOM_BRANDING) ? getAsStringOrThrow(Config.CUSTOM_BRANDING_NAME) : SORMAS;
+		return isCustomBranding() ? getAsStringOrThrow(Config.CUSTOM_BRANDING_NAME) : SORMAS;
 	}
 
 	@NotNull
@@ -179,7 +181,7 @@ default String getGeneratedFilesPath() {
 		return getAsStringOrNull(Config.GENERATED_FILES_PATH);
 	}
 
-	@Nullable
+	@NotNull
 	default String getCustomFilesPath() {
 		return getAsStringOrNull(Config.CUSTOM_FILES_PATH);
 	}

sormas-api/src/main/java/de/symeda/sormas/api/systemconfiguration/SystemConfigurationValueFacade.java

@@ -17,8 +17,8 @@
 
 import java.io.Serializable;
 import java.util.List;
-import java.util.Optional;
 
+import javax.annotation.Nullable;
 import javax.ejb.Remote;
 
 import de.symeda.sormas.api.BaseFacade;
@@ -29,44 +29,48 @@
  */
 @Remote
 public interface SystemConfigurationValueFacade
-    extends
-    BaseFacade<SystemConfigurationValueDto, SystemConfigurationValueIndexDto, SystemConfigurationValueReferenceDto, SystemConfigurationValueCriteria>,
-    Serializable {
+	extends
+	BaseFacade<SystemConfigurationValueDto, SystemConfigurationValueIndexDto, SystemConfigurationValueReferenceDto, SystemConfigurationValueCriteria>,
+	Serializable {
 
-    /**
-     * Retrieves system configuration values by their UUIDs.
-     *
-     * @param uuids the list of UUIDs
-     * @return the list of matching system configuration value DTOs
-     */
-    List<SystemConfigurationValueDto> getByUuids(List<String> uuids);
+	/**
+	 * Retrieves system configuration values by their UUIDs.
+	 *
+	 * @param uuids
+	 *            the list of UUIDs
+	 * @return the list of matching system configuration value DTOs
+	 */
+	List<SystemConfigurationValueDto> getByUuids(List<String> uuids);
 
-    /**
-     * Retrieves all UUIDs of system configuration values.
-     *
-     * @return the list of all UUIDs
-     */
-    List<String> getAllUuids();
+	/**
+	 * Retrieves all UUIDs of system configuration values.
+	 *
+	 * @return the list of all UUIDs
+	 */
+	List<String> getAllUuids();
 
-    /**
-     * Retrieves a configuration value associated with the given key.
-     * The implementors should assure that proper caching is used.
-     *
-     * @param key The key of the configuration value to retrieve.
-     * @return the value of the configuration.
-     */
-	Optional<String> getValue(Config key);
+	/**
+	 * Retrieves a configuration value associated with the given key.
+	 * The implementors should assure that proper caching is used.
+	 *
+	 * @param key
+	 *            The key of the configuration value to retrieve.
+	 * @return the value of the configuration.
+	 */
+	@Nullable
+	String getValue(Config key);
 
-    /**
-     * Checks if a configuration value exists for the given key.
-     *
-     * @param key The key to check.
-     * @return true if the configuration value exists, false otherwise.
-     */
+	/**
+	 * Checks if a configuration value exists for the given key.
+	 *
+	 * @param key
+	 *            The key to check.
+	 * @return true if the configuration value exists, false otherwise.
+	 */
 	boolean exists(Config key);
 
-    /**
-     * Clears the caches and reloads the system configuration values from the database.
-     */
-    void loadData();
+	/**
+	 * Clears the caches and reloads the system configuration values from the database.
+	 */
+	void loadData();
 }