Skip to content

Commit 466f87d

Browse files
Resolved test failures
1 parent f047212 commit 466f87d

8 files changed

Lines changed: 119 additions & 95 deletions

File tree

sormas-api/src/main/java/de/symeda/sormas/api/i18n/Captions.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1021,6 +1021,7 @@ public interface Captions {
10211021
String Contact_contactIdentificationSourceDetails = "Contact.contactIdentificationSourceDetails";
10221022
String Contact_contactOfficer = "Contact.contactOfficer";
10231023
String Contact_contactOfficerUuid = "Contact.contactOfficerUuid";
1024+
String Contact_contactProximities = "Contact.contactProximities";
10241025
String Contact_contactProximity = "Contact.contactProximity";
10251026
String Contact_contactProximityDetails = "Contact.contactProximityDetails";
10261027
String Contact_contactProximityLongForm = "Contact.contactProximityLongForm";

sormas-api/src/main/java/de/symeda/sormas/api/i18n/Descriptions.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public interface Descriptions {
3131
String CaseHospitalization_isolated = "CaseHospitalization.isolated";
3232
String CasePreviousHospitalization_admissionDate = "CasePreviousHospitalization.admissionDate";
3333
String Contact_community = "Contact.community";
34+
String Contact_contactProximities = "Contact.contactProximities";
3435
String Contact_contactProximity = "Contact.contactProximity";
3536
String Contact_district = "Contact.district";
3637
String Contact_followUpStatus = "Contact.followUpStatus";

sormas-app/app/src/main/java/de/symeda/sormas/app/backend/common/AbstractAdoDao.java

Lines changed: 101 additions & 86 deletions
Large diffs are not rendered by default.

sormas-app/app/src/main/java/de/symeda/sormas/app/backend/common/DatabaseHelper.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3232,6 +3232,10 @@ public void onUpgrade(SQLiteDatabase db, ConnectionSource connectionSource, int
32323232

32333233
// ATTENTION: break should only be done after last version
32343234
break;
3235+
case 362:
3236+
currentVersion = 362;
3237+
getDao(PathogenTest.class).executeRaw("ALTER TABLE pathogentest ADD COLUMN IF NOT EXISTS serotypetext varchar(255);");
3238+
getDao(PathogenTest.class).executeRaw("UPDATE pathogentest SET serotypetext = serotype, serotype = \"'OTHER\"' WHERE serotype IS NOT null and serotypetext is null;");
32353239

32363240
default:
32373241
throw new IllegalStateException("onUpgrade() with unknown oldVersion " + oldVersion);

sormas-app/app/src/main/java/de/symeda/sormas/app/backend/sample/PathogenTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import de.symeda.sormas.api.sample.PCRTestSpecification;
4040
import de.symeda.sormas.api.sample.PathogenTestResultType;
4141
import de.symeda.sormas.api.sample.PathogenTestType;
42+
import de.symeda.sormas.api.sample.Serotype;
4243
import de.symeda.sormas.app.backend.common.DatabaseHelper;
4344
import de.symeda.sormas.app.backend.common.PseudonymizableAdo;
4445
import de.symeda.sormas.app.backend.environment.environmentsample.EnvironmentSample;
@@ -116,8 +117,9 @@ public class PathogenTest extends PseudonymizableAdo {
116117
@Column
117118
private boolean fourFoldIncreaseAntibodyTiter;
118119

119-
@Column(length = CHARACTER_LIMIT_DEFAULT)
120-
private String serotype;
120+
@Column
121+
@Enumerated(EnumType.STRING)
122+
private Serotype serotype;
121123

122124
@DatabaseField
123125
private Float cqValue;
@@ -333,11 +335,11 @@ public void setTestTypeText(String testTypeText) {
333335
this.testTypeText = testTypeText;
334336
}
335337

336-
public String getSerotype() {
338+
public Serotype getSerotype() {
337339
return serotype;
338340
}
339341

340-
public void setSerotype(String serotype) {
342+
public void setSerotype(Serotype serotype) {
341343
this.serotype = serotype;
342344
}
343345

sormas-app/app/src/main/res/layout/fragment_pathogen_test_edit_layout.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
<import type="de.symeda.sormas.api.sample.SampleMaterial" />
3030
<import type="de.symeda.sormas.api.sample.PathogenTestType" />
3131
<import type="de.symeda.sormas.api.sample.PathogenTestResultType" />
32+
<import type="de.symeda.sormas.api.sample.Serotype" />
3233
<import type="de.symeda.sormas.api.Disease" />
3334
<import type="de.symeda.sormas.api.disease.DiseaseVariant" />
3435

@@ -172,13 +173,13 @@
172173
android:layout_height="wrap_content"
173174
android:orientation="horizontal">
174175

175-
<de.symeda.sormas.app.component.controls.ControlTextEditField
176+
<de.symeda.sormas.app.component.controls.ControlCheckBoxField
176177
android:id="@+id/pathogenTest_serotype"
177178
app:dependencyParentField="@{pathogenTestTestedDisease}"
178179
app:dependencyParentValue="@{Disease.CSM}"
179180
app:dependencyParent2Field="@{pathogenTestTestResult}"
180181
app:dependencyParent2Value="@{PathogenTestResultType.POSITIVE}"
181-
app:value="@={data.serotype}"
182+
app:value="@{data.serotype!=null}"
182183
style="@style/ControlFirstOfTwoColumnsStyle" />
183184

184185
<de.symeda.sormas.app.component.controls.ControlTextEditField

sormas-app/app/src/main/res/layout/fragment_pathogen_test_read_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@
148148
android:layout_height="wrap_content"
149149
android:orientation="horizontal">
150150

151-
<de.symeda.sormas.app.component.controls.ControlTextReadField
151+
<de.symeda.sormas.app.component.controls.ControlCheckBoxField
152152
android:id="@+id/pathogenTest_serotype"
153153
app:dependencyParentField="@{pathogenTestTestedDisease}"
154154
app:dependencyParentValue="@{Disease.CSM}"

sormas-backend/src/main/java/de/symeda/sormas/backend/util/PatchHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
import com.fasterxml.jackson.databind.ObjectMapper;
1919

2020
import de.symeda.sormas.api.EntityDto;
21-
import de.symeda.sormas.api.uuid.HasUuid;
2221
import de.symeda.sormas.api.i18n.I18nProperties;
2322
import de.symeda.sormas.api.i18n.Validations;
2423
import de.symeda.sormas.api.utils.Experimental;
2524
import de.symeda.sormas.api.utils.ValidationRuntimeException;
25+
import de.symeda.sormas.api.uuid.HasUuid;
2626

2727
public class PatchHelper {
2828

@@ -104,7 +104,7 @@ private static <T extends HasUuid> void updateObjectList(T existingObject, JsonN
104104
}
105105
}
106106

107-
if (existingObjectField.getType().isAssignableFrom(List.class)) {
107+
if (Collection.class.isAssignableFrom(existingObjectField.getType())) {
108108
Object existingObjectFieldInstance = null;
109109
try {
110110
existingObjectFieldInstance = existingObjectField.get(existingObject);

0 commit comments

Comments
 (0)