#13555 - Fix editing Notifier in phone DD

[raulbob]

• Restored previous query for retrieving notifier
• Changed the edit form to only edit the current version of the notifier

Summary by CodeRabbit

• Bug Fixes

  • Editing a notifier now always targets the current version, preventing unintended edits to historical snapshots.
  • Improved reliability when viewing notifier details as of a past date, ensuring fields reflect the correct historical state.

• Refactor

  • Optimized backend retrieval of notifier data at a given time for better consistency and performance without changing public interfaces.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Backend: Rewrote NotifierService.getByUuidAndTime SQL from UNION-based selection to a LEFT JOIN with COALESCE over notifier and latest matching notifier_history row. UI: CaseNotifierSideViewController.editNotifier now fetches NotifierDto by current uuid instead of time-based retrieval.

Changes

Cohort / File(s)	Summary
Backend notifier time-slice retrieval sormas-backend/src/main/java/de/symeda/sormas/backend/person/notifier/NotifierService.java	Replaced UNION query with LEFT JOIN on latest history row (by changedate <= input), using COALESCE per field; explicitly selected columns; preserved uuid filter.
UI notifier edit retrieval sormas-ui/src/main/java/de/symeda/sormas/ui/caze/notifier/CaseNotifierSideViewController.java	Changed edit flow to load notifier via getByUuid(...) instead of getByUuidAndTime(..., versionDate); added inline comment.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as CaseNotifierSideViewController
  participant Backend as NotifierService
  participant DB as DB (notifier, notifier_history)

  User->>UI: Edit Notifier
  Note over UI: Load Notifier for editing

  UI->>Backend: getByUuid(uuid)  (New)
  rect rgba(230,245,255,0.5)
    Backend->>DB: SELECT from notifier WHERE uuid=?
    DB-->>Backend: Current notifier row
  end
  Backend-->>UI: NotifierDto (current)

  Note over UI,Backend: Previously: getByUuidAndTime(uuid, versionDate)
  rect rgba(255,240,230,0.5)
    UI->>Backend: getByUuidAndTime(uuid, t)  (Old)
    Backend->>DB: SELECT via LEFT JOIN on latest history <= t with COALESCE
    DB-->>Backend: Reconstructed time-sliced row
    Backend-->>UI: NotifierDto (as of t)
  end

  UI-->>User: Open edit form with current data

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• #13555 - Fixed notifier query to correctly get the most recent version #13583 — Also modifies NotifierService.getByUuidAndTime with an alternative query strategy, directly overlapping in logic for time-sliced notifier retrieval.

Suggested reviewers

• KarnaiahPesula

Poem

A nibble of SQL, a hop to UI,
I stitch time’s trail with COALESCE sly.
Now edits peek the present face,
While history waits in a gentler place.
Thump-thump goes my review drum—
Carrots merged, changes plumb. 🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 19af2d3 and b541947.

📒 Files selected for processing (2)

• sormas-backend/src/main/java/de/symeda/sormas/backend/person/notifier/NotifierService.java (1 hunks)
• sormas-ui/src/main/java/de/symeda/sormas/ui/caze/notifier/CaseNotifierSideViewController.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix-13555-phone_dd_save_error

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sormas-vitagroup]

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13590