Added missed symptom for Measles & data validation#13615
Conversation
WalkthroughAdds MEASLES to @diseases annotations for three fields in SymptomsDto. Updates ExposureForm to call DateComparisonValidator.addStartEndValidators with an added boolean argument (false) and adjusts DateComparisonValidator signature accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as ExposureForm
participant Validator as DateComparisonValidator
User ->> UI: Enter start/end dates
UI ->> Validator: addStartEndValidators(start, end, false)
Note over Validator: Register cross-field\ndate validation handlers (flag=false)
User ->> UI: Attempt save
UI ->> Validator: Validate(start, end, flag=false)
alt Dates valid
Validator -->> UI: OK
UI -->> User: Save proceeds
else Invalid order/range
Validator -->> UI: Error
UI -->> User: Show validation message
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13615 |
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13615 |
Fixes #
Summary by CodeRabbit
New Features
Bug Fixes