Skip to content

Added missed symptom for Measles & data validation#13615

Merged
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-measles-minor-issues
Sep 19, 2025
Merged

Added missed symptom for Measles & data validation#13615
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-measles-minor-issues

Conversation

@KarnaiahPesula
Copy link
Copy Markdown
Contributor

@KarnaiahPesula KarnaiahPesula commented Sep 19, 2025

Fixes #

Summary by CodeRabbit

  • New Features

    • Enabled “Other clinical presentation” and “Unknown symptom” fields for measles cases, including support in data export.
  • Bug Fixes

    • Refined exposure start/end date validation for more consistent input handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 19, 2025

Walkthrough

Adds MEASLES to @diseases annotations for three fields in SymptomsDto. Updates ExposureForm to call DateComparisonValidator.addStartEndValidators with an added boolean argument (false) and adjusts DateComparisonValidator signature accordingly.

Changes

Cohort / File(s) Summary
Symptoms annotations update
sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java
Extended @Diseases on otherClinicalPresentation, otherClinicalPresentationText, and unknownSymptom to include MEASLES.
Date validation API change
sormas-ui/src/main/java/de/symeda/sormas/ui/exposure/ExposureForm.java, sormas-ui/src/main/java/de/symeda/sormas/ui/utils/DateComparisonValidator.java
ExposureForm now calls addStartEndValidators(start, end, false); DateComparisonValidator.addStartEndValidators signature updated to accept a boolean flag.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as ExposureForm
  participant Validator as DateComparisonValidator

  User ->> UI: Enter start/end dates
  UI ->> Validator: addStartEndValidators(start, end, false)
  Note over Validator: Register cross-field\ndate validation handlers (flag=false)
  User ->> UI: Attempt save
  UI ->> Validator: Validate(start, end, flag=false)
  alt Dates valid
    Validator -->> UI: OK
    UI -->> User: Save proceeds
  else Invalid order/range
    Validator -->> UI: Error
    UI -->> User: Show validation message
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Date validations #13596 — Related change that introduced/used DateComparisonValidator.addStartEndValidators with the new parameter.

Suggested reviewers

  • obinna-h-n
  • raulbob

Poem

Hop hop, I patch with care,
Measles listed in fields now there.
Dates get checked with one more flag,
Tiny hops that skip a snag.
(_/) 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains only the repository default template with "Fixes #" left blank and no summary, rationale, testing steps, or issue reference, so it lacks the required information to understand or review the change. Please replace the template content with a concise description including the issue number after "Fixes #", a brief summary of the changes (mention the MEASLES annotation additions and the date validator call change), rationale/impact, and testing or verification steps; include links to related issues or SonarCloud results if available.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title succinctly and accurately reflects the primary changes: adding a missed measles symptom (MEASLES annotations) and a related data-validation change (date validator usage), and is concise and specific enough for a quick history scan.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix-measles-minor-issues

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e625bde and 7607f14.

📒 Files selected for processing (1)
  • sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: SORMAS CI
  • GitHub Check: android app test (28)
  • GitHub Check: android app test (27)
  • GitHub Check: android app test (26)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sormas-vitagroup
Copy link
Copy Markdown
Contributor

@KarnaiahPesula KarnaiahPesula merged commit 1772743 into development Sep 19, 2025
4 of 11 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bugfix-measles-minor-issues branch September 19, 2025 09:10
@sormas-vitagroup
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants