Further fixes for system configuration UI and reverted IPI follow-up …

[raulbob]

Fixes System Configuration UI filtering issues, and reverted a change introduced by PR #13519.

Summary by CodeRabbit

• Bug Fixes

  • Updated default follow-up settings for invasive pneumococcal infection disease—follow-up is now disabled by default with zero-day duration.

• Chores

  • Refactored system configuration data structure for improved naming clarity and consistency. Added sorting capability for configuration categories.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request modifies the default follow-up configuration for invasive pneumococcal infection in the Disease enum and refactors field naming in system configuration value indexing by renaming categoryName to category across the API and backend, including corresponding sorting support.

Changes

Cohort / File(s)	Summary
Disease enum constant configuration sormas-api/src/main/java/de/symeda/sormas/api/Disease.java	Updated INVASIVE_PNEUMOCOCCAL_INFECTION constant: disabled default follow-up (defaultFollowUpEnabled: true → false) and reset duration to zero (defaultFollowUpDuration: 7 → 0).
System configuration DTO field refactoring sormas-api/src/main/java/de/symeda/sormas/api/systemconfiguration/SystemConfigurationValueIndexDto.java	Renamed categoryName field to category, including constant CATEGORY_NAME_PROPERTY_NAME, getter (getCategoryName → getCategory), setter (setCategoryName → setCategory), and Javadoc.
System configuration backend updates sormas-backend/src/main/java/de/symeda/sormas/backend/systemconfiguration/SystemConfigurationValueEjb.java	Added CATEGORY field sorting support in getIndexList and updated toIndexDto to use setCategory instead of setCategoryName.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• The Disease enum change is a straightforward value update
• The field renaming is systematic and consistent across DTO accessors
• Backend changes are isolated to sorting logic and method mapping
• Attention areas: Verify the field renaming coordination between SystemConfigurationValueIndexDto and SystemConfigurationValueEjb is complete; ensure no other references to setCategoryName or the old constant name exist elsewhere in the codebase.

Possibly related PRs

• #13519 - Modify Disease.java to permit the view of INVASIVE_PNEUMOCOC… #13585: Modifies the same INVASIVE_PNEUMOCOCCAL_INFECTION enum constant with opposite changes to default follow-up settings.
• Defect fixes #13643: Also affects the INVASIVE_PNEUMOCOCCAL_INFECTION constant; may add it to PathogenTestType.SEQUENCING annotation.

Suggested reviewers

• obinna-h-n
• KarnaiahPesula

Poem

🐰 A field gets renamed, smooth and clean,
From categoryName to category lean!
The follow-up rests for pneumococcal care,
Sorting now flows with graceful flair ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix-system_config_ui_field_sorting

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 697a49b and a3e23f7.

📒 Files selected for processing (3)

• sormas-api/src/main/java/de/symeda/sormas/api/Disease.java (1 hunks)
• sormas-api/src/main/java/de/symeda/sormas/api/systemconfiguration/SystemConfigurationValueIndexDto.java (2 hunks)
• sormas-backend/src/main/java/de/symeda/sormas/backend/systemconfiguration/SystemConfigurationValueEjb.java (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}