release bug fixes #13713, #13704, #13726

[obinna-h-n]

Fixes #13713, #13704, #13726

Summary by CodeRabbit

• New Features

  • Extended antibiotic susceptibility testing to support invasive meningococcal and invasive pneumococcal infections alongside tuberculosis.

• Bug Fixes

  • Updated sensitive clinical data field visibility to be permission-based rather than disease-specific.
  • Improved test result field handling to display correctly based on selected disease type.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Extended disease applicability in drug susceptibility annotations to include invasive meningococcal and pneumococcal infections. Restricted test types for antibiotic susceptibility fields. Modified pathogen test form visibility logic to be disease-aware, treating invasive meningococcal infections specially. Shifted health conditions visibility from disease-based to permission-based control.

Changes

Cohort / File(s)	Summary
Drug Susceptibility API Annotations sormas-api/src/main/java/de/symeda/sormas/api/therapy/DrugSusceptibilityDto.java	Expanded @Diseases annotations on susceptibility fields to include Disease.INVASIVE_MENINGOCOCCAL_INFECTION and Disease.INVASIVE_PNEUMOCOCCAL_INFECTION alongside Disease.TUBERCULOSIS. Removed PCR_RT_PCR from @ApplicableToPathogenTests annotations, restricting test types to ANTIBIOTIC_SUSCEPTIBILITY only.
Health Conditions Visibility sormas-ui/src/main/java/de/symeda/sormas/ui/clinicalcourse/HealthConditionsForm.java	Replaced disease-specific (TB) gating of OTHER_CONDITIONS field with permission-based visibility controlled by SEE_SENSITIVE_DATA_IN_JURISDICTION or SEE_SENSITIVE_DATA_OUTSIDE_JURISDICTION user rights. Added imports for UserRight and UiUtil.
Pathogen Test Disease-Aware Logic sormas-ui/src/main/java/de/symeda/sormas/ui/samples/PathogenTestForm.java	Updated setCqValueVisibility() method signature to accept diseaseField parameter and apply visibility logic only for non-TB diseases. Added special handling for invasive meningococcal infections with antibiotic susceptibility tests to set test result as NOT_APPLICABLE. Propagated method signature change to all call sites.

Sequence Diagram

sequenceDiagram
    participant User
    participant PathogenTestForm
    participant DrugSusceptibilityDto
    
    User->>PathogenTestForm: Select Disease (IMI) + Test Type (Antibiotic Susceptibility)
    PathogenTestForm->>PathogenTestForm: Check if disease is TUBERCULOSIS
    alt Is TB
        PathogenTestForm->>PathogenTestForm: Apply TB-specific visibility rules
    else Is IMI + Antibiotic Susceptibility
        PathogenTestForm->>PathogenTestForm: Set Test Result to NOT_APPLICABLE
        PathogenTestForm->>PathogenTestForm: Restrict field editability
    else Other Disease
        PathogenTestForm->>PathogenTestForm: Apply standard visibility logic
    end
    
    PathogenTestForm->>DrugSusceptibilityDto: Validate against allowed test types
    Note over DrugSusceptibilityDto: Only ANTIBIOTIC_SUSCEPTIBILITY allowed (no PCR_RT_PCR)
    
    User->>PathogenTestForm: Save Pathogen Test
    PathogenTestForm-->>User: Form saved successfully

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• PathogenTestForm.java requires careful review of disease-aware visibility logic changes and new method signature propagation across multiple call sites to ensure all conditional branches function correctly
• Special handling for invasive meningococcal infections with antibiotic susceptibility tests should be validated against the linked bug report
• Verify that permission-based visibility in HealthConditionsForm does not unintentionally expose sensitive data based on user role combinations

Possibly related PRs

• Defect fixes #13643 — Modifies disease associations and pathogen-test handling for invasive infections alongside API annotation changes
• update therapy form for TB. disable TB by default. drug susceptibility result entry fixes #13658 — Updates PathogenTestForm and drug-susceptibility-related UI/DTO handling with similar visibility and field control logic
• Feature 13365 enhance case data form for measles #13582 — Changes the same PathogenTestForm file with disease-aware visibility adjustments to the setCqValueVisibility method

Suggested reviewers

• raulbob
• KarnaiahPesula

Poem

🐰 Hops through meningococcal tests with glee,
Disease-aware logic sets results free!
No more TB tangling up the way,
Permissions guard what users see today.
Susceptibility blooms, antibiotic and bright, ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfixes-13713-13711-13704-13726

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7f73f6 and 6dffe66.

📒 Files selected for processing (3)

• sormas-api/src/main/java/de/symeda/sormas/api/therapy/DrugSusceptibilityDto.java (4 hunks)
• sormas-ui/src/main/java/de/symeda/sormas/ui/clinicalcourse/HealthConditionsForm.java (2 hunks)
• sormas-ui/src/main/java/de/symeda/sormas/ui/samples/PathogenTestForm.java (4 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}