Skip to content

Reverting the partial commit#13932

Merged
KarnaiahPesula merged 1 commit into
developmentfrom
bugfix-reverting-to-development
May 13, 2026
Merged

Reverting the partial commit#13932
KarnaiahPesula merged 1 commit into
developmentfrom
bugfix-reverting-to-development

Conversation

@KarnaiahPesula
Copy link
Copy Markdown
Contributor

@KarnaiahPesula KarnaiahPesula commented May 11, 2026

Fixes #
Reverting the partial commit

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the display label for a field from "Species" to "Specie"
  • Changes

    • Removed Shigellosis from the list of available diseases in the system. This affects disease selection throughout the application
    • Updated sample material disease associations to remove all references to Shigellosis

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

📝 Walkthrough

Walkthrough

This PR removes the SHIGELLOSIS disease constant from the Disease enum and updates all associated sample material disease mappings to no longer reference it. A caption property label is also corrected from "Species" to "Specie".

Changes

SHIGELLOSIS Removal and Caption Correction

Layer / File(s) Summary
Disease Enum Removal
sormas-api/src/main/java/de/symeda/sormas/api/Disease.java
SHIGELLOSIS enum constant removed from between CRYPTOSPORIDIOSIS and SALMONELLOSIS.
Sample Material Disease Associations
sormas-api/src/main/java/de/symeda/sormas/api/sample/SampleMaterial.java
@Diseases annotations for eight enum constants (BRAIN_TISSUE, OP_ASPIRATE, NP_ASPIRATE, AMNIOTIC_FLUID, CLINICAL_SAMPLE, PERITONEAL_FLUID, and preceding constants) are updated to remove Disease.SHIGELLOSIS from their disease-to-sample mappings.
UI Label Correction
sormas-api/src/main/resources/captions.properties
PathogenTest.specie caption text changed from Species to Specie.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • #13927: Directly related as both target the SHIGELLOSIS enum constant in Disease; this PR removes it while that issue tracks its properties.

Possibly related PRs

Suggested reviewers

  • raulbob
  • obinna-h-n

Poem

🐰 A sickness cast aside with care,
No more Shigellosis anywhere!
Sample maps now clean and bright,
Captions spelled just right. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it contains only the template header and a single line repeating the title without the required issue number and detailed context. Complete the description by specifying the issue number after 'Fixes #' and provide details about what changes are being reverted and why.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Reverting the partial commit' is vague and generic, lacking specificity about what partial commit is being reverted or what changes are involved. Revise the title to clearly specify what is being reverted (e.g., 'Revert removal of SHIGELLOSIS disease and related changes') for better clarity.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-reverting-to-development

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KarnaiahPesula KarnaiahPesula requested a review from raulbob May 11, 2026 14:21
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@sormas-api/src/main/resources/captions.properties`:
- Line 1959: The caption key PathogenTest.specie has a typo in its value; update
the properties entry so the user-facing label reads "Species" instead of
"Specie" by changing the value for PathogenTest.specie to "Species" (also search
for other uses of PathogenTest.specie to update any duplicates or translations
to maintain consistency).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 936bed53-5622-44d6-ae42-bdda0351cca3

📥 Commits

Reviewing files that changed from the base of the PR and between 1dc509f and f65279c.

📒 Files selected for processing (3)
  • sormas-api/src/main/java/de/symeda/sormas/api/Disease.java
  • sormas-api/src/main/java/de/symeda/sormas/api/sample/SampleMaterial.java
  • sormas-api/src/main/resources/captions.properties
💤 Files with no reviewable changes (1)
  • sormas-api/src/main/java/de/symeda/sormas/api/Disease.java

PathogenTest.rifampicinResistant=Rifampicin resistant
PathogenTest.isoniazidResistant=Isoniazid resistant
PathogenTest.specie=Species
PathogenTest.specie=Specie
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix caption typo: use “Species” instead of “Specie”

This change introduces a user-facing wording regression. In this context, the correct label is “Species”.

Suggested fix
-PathogenTest.specie=Specie
+PathogenTest.specie=Species
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
PathogenTest.specie=Specie
PathogenTest.specie=Species
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sormas-api/src/main/resources/captions.properties` at line 1959, The caption
key PathogenTest.specie has a typo in its value; update the properties entry so
the user-facing label reads "Species" instead of "Specie" by changing the value
for PathogenTest.specie to "Species" (also search for other uses of
PathogenTest.specie to update any duplicates or translations to maintain
consistency).

@KarnaiahPesula KarnaiahPesula merged commit f16efd8 into development May 13, 2026
7 of 10 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bugfix-reverting-to-development branch May 13, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants