Reverting the partial commit#13932
Conversation
📝 WalkthroughWalkthroughThis PR removes the SHIGELLOSIS disease constant from the Disease enum and updates all associated sample material disease mappings to no longer reference it. A caption property label is also corrected from "Species" to "Specie". ChangesSHIGELLOSIS Removal and Caption Correction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sormas-api/src/main/resources/captions.properties`:
- Line 1959: The caption key PathogenTest.specie has a typo in its value; update
the properties entry so the user-facing label reads "Species" instead of
"Specie" by changing the value for PathogenTest.specie to "Species" (also search
for other uses of PathogenTest.specie to update any duplicates or translations
to maintain consistency).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 936bed53-5622-44d6-ae42-bdda0351cca3
📒 Files selected for processing (3)
sormas-api/src/main/java/de/symeda/sormas/api/Disease.javasormas-api/src/main/java/de/symeda/sormas/api/sample/SampleMaterial.javasormas-api/src/main/resources/captions.properties
💤 Files with no reviewable changes (1)
- sormas-api/src/main/java/de/symeda/sormas/api/Disease.java
| PathogenTest.rifampicinResistant=Rifampicin resistant | ||
| PathogenTest.isoniazidResistant=Isoniazid resistant | ||
| PathogenTest.specie=Species | ||
| PathogenTest.specie=Specie |
There was a problem hiding this comment.
Fix caption typo: use “Species” instead of “Specie”
This change introduces a user-facing wording regression. In this context, the correct label is “Species”.
Suggested fix
-PathogenTest.specie=Specie
+PathogenTest.specie=Species📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| PathogenTest.specie=Specie | |
| PathogenTest.specie=Species |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@sormas-api/src/main/resources/captions.properties` at line 1959, The caption
key PathogenTest.specie has a typo in its value; update the properties entry so
the user-facing label reads "Species" instead of "Specie" by changing the value
for PathogenTest.specie to "Species" (also search for other uses of
PathogenTest.specie to update any duplicates or translations to maintain
consistency).
Fixes #
Reverting the partial commit
Summary by CodeRabbit
Bug Fixes
Changes