Skip to content

exposure form - remove time picker from exposure date, reformat date on table, remove prophylaxis column from table.#13942

Merged
obinna-h-n merged 1 commit into
developmentfrom
13887-exposure-form-redesign
May 25, 2026
Merged

exposure form - remove time picker from exposure date, reformat date on table, remove prophylaxis column from table.#13942
obinna-h-n merged 1 commit into
developmentfrom
13887-exposure-form-redesign

Conversation

@obinna-h-n
Copy link
Copy Markdown
Contributor

@obinna-h-n obinna-h-n commented May 25, 2026

exposure form - remove time picker from exposure date, reformat date on table, remove prophylaxis column from table.

Summary by CodeRabbit

  • Changes
    • Exposure start and end date fields now accept dates only, removing time selection capability.
    • Prophylaxis adherence column removed from the exposure data table display.
    • Date range formatting in exposure tables simplified for improved readability.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9237ec6-be8f-4fba-93e6-8d1090e87066

📥 Commits

Reviewing files that changed from the base of the PR and between 227edcc and fb59784.

📒 Files selected for processing (2)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/exposure/ExposureForm.java
  • sormas-ui/src/main/java/de/symeda/sormas/ui/exposure/ExposuresField.java

📝 Walkthrough

Walkthrough

ExposureForm converts start/end date fields from DateTimeField to DateField via updated imports and field instantiation. The layout template is adjusted with additional placeholder parameters. ExposuresField updates table rendering to display date-only periods and adjusts visible columns for case-type exposures.

Changes

Exposure Date Format Updates

Layer / File(s) Summary
DateField conversion in ExposureForm
sormas-ui/src/main/java/de/symeda/sormas/ui/exposure/ExposureForm.java
Imports DateField, removes DateTimeField import, updates GENERAL_DETAILS_LAYOUT template expression with empty placeholder strings, and instantiates startDate and endDate as DateField components with validation preserved.
Exposure date display updates in ExposuresField
sormas-ui/src/main/java/de/symeda/sormas/ui/exposure/ExposuresField.java
Removes COLUMN_PROPHYLAXIS_ADHERENCE from visible columns when parent entity is CaseDataDto, and changes COLUMN_DATE generation from buildPeriodDateTimeString() to buildPeriodString() to render date-only period strings in the table.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • SORMAS-Foundation/SORMAS-Project#13596: Both PRs modify ExposureForm's START_DATE/END_DATE handling by changing how those fields are created and validated, with related date field type changes.
  • SORMAS-Foundation/SORMAS-Project#13936: Both PRs modify the exposure UI wiring in ExposureForm around the start/end date row and change ExposuresField's table column rendering for exposure dates.

Suggested reviewers

  • raulbob

Poem

🐰 A rabbit hops through dates with glee,
No time, just day—much simpler to see!
From DateTime's dance to DateField's grace,
Exposure records find their cleaner place. 🌿

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description repeats the title but does not reference a related issue number as required by the template, and lacks detailed explanation of the changes. Add the issue number reference (Fixes #13887) after the template prefix and provide more context about why these UI changes are needed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes all three main changes in the PR: removing time picker from exposure date, reformatting dates in the table, and removing the prophylaxis column.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 13887-exposure-form-redesign

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@obinna-h-n obinna-h-n merged commit 7ffc9c3 into development May 25, 2026
4 of 5 checks passed
@obinna-h-n obinna-h-n deleted the 13887-exposure-form-redesign branch May 25, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant