Skip to content

Implemented the default functionality of user combobox.#14099

Merged
KarnaiahPesula merged 1 commit into
developmentfrom
bugfix-14090-error-when-manually-typing-responsible-surveillance-officer
Jun 30, 2026
Merged

Implemented the default functionality of user combobox.#14099
KarnaiahPesula merged 1 commit into
developmentfrom
bugfix-14090-error-when-manually-typing-responsible-surveillance-officer

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Summary by CodeRabbit

  • Bug Fixes
    • Removed the ability to enter new values in the user selection field, so only existing users can be chosen.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fd4fbf8-9c6d-4b13-a0b1-370559e23923

📥 Commits

Reviewing files that changed from the base of the PR and between 2451102 and 0a00fd8.

📒 Files selected for processing (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/utils/UserField.java
💤 Files with no reviewable changes (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/utils/UserField.java

📝 Walkthrough

Walkthrough

Removes the setNewItemsAllowed(true) call on userCombo in UserField.initContent(), preventing users from entering arbitrary new items in the user selection combo box.

UserField combo restriction

Layer / File(s) Summary
Disable new item creation in UserField
sormas-ui/src/main/java/de/symeda/sormas/ui/utils/UserField.java
Removes userCombo.setNewItemsAllowed(true) so the combo box no longer accepts arbitrary new entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A field once open to any new name,
Now keeps its list locked, no wildcards in the game.
The rabbit hops past, whiskers twitching with glee,
"Only known users—that's how it should be!"
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains the template placeholder and lacks the required issue number and any implementation details. Replace the placeholder with a real issue reference after # and add a brief summary of the change, impact, and any relevant testing notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change by describing the combobox's default behavior, though it is a bit broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-14090-error-when-manually-typing-responsible-surveillance-officer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KarnaiahPesula KarnaiahPesula requested review from raulbob and roldy June 30, 2026 10:14
@KarnaiahPesula KarnaiahPesula merged commit 548995c into development Jun 30, 2026
7 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bugfix-14090-error-when-manually-typing-responsible-surveillance-officer branch June 30, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when manually typing under the field - AFP - Cases - Responsible Surveillance Officer

2 participants