Skip to content

Fixed the active and readonly boolean fields as string representation.#14160

Merged
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-14148-boolean-string-representations-customizable-fields
Jul 7, 2026
Merged

Fixed the active and readonly boolean fields as string representation.#14160
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-14148-boolean-string-representations-customizable-fields

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The active and readonly fields now shows "Yes" or "No" instead of "true" or "false".

Fixes #

Summary by CodeRabbit

  • Bug Fixes
    • Improved how boolean status values are displayed in grids by using a dedicated boolean renderer for clearer, more consistent visibility.
    • Updated the customizable fields grid for the read-only and active columns.
    • Updated the contact grid to render prophylaxis prescribed as a boolean in the UI.

The active and readonly fields now shows "Yes" or "No" instead of "true" or "false".
@KarnaiahPesula KarnaiahPesula linked an issue Jul 7, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4c92bd1-dd2a-4619-a520-e3bde5398012

📥 Commits

Reviewing files that changed from the base of the PR and between 668b037 and cc027e1.

📒 Files selected for processing (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/contact/AbstractContactGrid.java
✅ Files skipped from review due to trivial changes (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/contact/AbstractContactGrid.java

📝 Walkthrough

Walkthrough

The UI grids now render selected boolean columns with BooleanRenderer: CustomizableFieldsGrid for READ_ONLY and ACTIVE, and AbstractContactGrid for PROPHYLAXIS_PRESCRIBED. Other grid behavior remains unchanged.

Changes

Grid Boolean Column Rendering

Layer / File(s) Summary
Customizable fields boolean columns
sormas-ui/src/main/java/de/symeda/sormas/ui/configuration/customizablefield/CustomizableFieldsGrid.java
Adds BooleanRenderer import and applies it to the READ_ONLY and ACTIVE columns; the rest of the constructor and reload() behavior stay the same.
Contact prophylaxis column
sormas-ui/src/main/java/de/symeda/sormas/ui/contact/AbstractContactGrid.java
Adds BooleanRenderer import and uses it for ContactIndexDto.PROPHYLAXIS_PRESCRIBED in initColumns().

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but it leaves the required issue reference as the placeholder "Fixes #". Replace "Fixes #" with the actual issue number and keep the description aligned with the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by describing the boolean field display fix, even if phrasing is a bit awkward.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-14148-boolean-string-representations-customizable-fields

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pa-Touche Pa-Touche self-requested a review July 7, 2026 09:16
@KarnaiahPesula KarnaiahPesula merged commit a4846f6 into development Jul 7, 2026
7 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bugfix-14148-boolean-string-representations-customizable-fields branch July 7, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean string representations - Customizable fields

2 participants