Skip to content

adds <string.h> includes for ROCm 7 compatibility#1857

Merged
danielpeter merged 1 commit into
SPECFEM:develfrom
AMD-HPC:rocm7support
Feb 13, 2026
Merged

adds <string.h> includes for ROCm 7 compatibility#1857
danielpeter merged 1 commit into
SPECFEM:develfrom
AMD-HPC:rocm7support

Conversation

@frawanye
Copy link
Copy Markdown

Without these includes, compiling with rocm 7 causes the following error: no matching function for call to 'memcpy'
in the following files:

  • src/gpu/assemble_MPI_vector_cuda.cu
  • src/gpu/lts_assembly_mpi_cuda.cu
  • src/gpu/prepare_mesh_constants_cuda.cu

Without these includes, compiling with rocm 7 causes the following error:
no matching function for call to 'memcpy'
in the following files:
- src/gpu/assemble_MPI_vector_cuda.cu
- src/gpu/lts_assembly_mpi_cuda.cu
- src/gpu/prepare_mesh_constants_cuda.cu
@danielpeter
Copy link
Copy Markdown
Member

thanks for the update!

as this didn't show up so far, what system were you using to compile the code?

anyway, i'll merge it and then probably move these include statements #include <string.h> to the file mesh_constants_gpu.h for convenience and add some HIP compilation checks.

thanks again,
-daniel

@danielpeter danielpeter merged commit ece6276 into SPECFEM:devel Feb 13, 2026
41 checks passed
@frawanye
Copy link
Copy Markdown
Author

frawanye commented Feb 18, 2026

Thank you very much and sorry for the late response!

I've seen this error on all the systems I've tried to build specfem3d on (one MI300X, two MI325X, and one MI355X) that use rocm versions 7.0.0 and 7.1.1 across two different clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants