SIEM documentation + PETSC compilation updates#867
Merged
Conversation
danielpeter
approved these changes
Dec 8, 2025
danielpeter
left a comment
Member
There was a problem hiding this comment.
great, thanks for this gravity update!
the only change I can see is in the documentation. I would use now "SPECFEM3D Globe" instead of "SPECFEM" and "SPECFEM3D_GLOBE".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following was added/edited:
VecGetArrayF90seem to have been re-refactored back toVecGetArrayso have updated the subroutine namesMatSetValuesseems to be stricter on requiring a 1D array (previously 2D) so inputting flattened array, and also parsing single values as length 1 arraysMatMPIAIJSetPreallocationbeing stricter on needingNULL_ARRAYtypes instead ofNULL.