feat: Implement persistent subtitle style settings for text color, outline color, and font scale.

Author: SPluzh

main.py

@@ -139,6 +139,10 @@ def __init__(self):
         self.video_player.video_finished.connect(self.on_video_finished)
         self.video_player.position_changed.connect(self.save_progress)
         self.video_player.pause_changed.connect(self.on_player_pause_changed)
+        self.video_player.subtitle_style_changed.connect(self.save_subtitle_settings)
+
+        # Apply initial subtitle settings
+        self.video_player.set_subtitle_styles(self.sub_color, self.sub_border_color, self.sub_scale)
 
         self.splitter.addWidget(self.video_player)
 
@@ -899,6 +903,11 @@ def create_default_settings(self):
         config['Video'] = {
             'extensions': '.mp4,.mkv,.avi,.mov,.wmv,.flv,.webm,.m4v,.mpg,.mpeg,.3gp,.ts'
         }
+        config['Subtitles'] = {
+            'text_color': '#FFFFFF',
+            'outline_color': '#000000',
+            'font_scale': '1.0'
+        }
 
         with open(self.config_file, 'w', encoding='utf-8') as f:
             config.write(f)
@@ -938,6 +947,30 @@ def load_settings(self):
         self.display_height = config.getint('Thumbnails', 'display_height', fallback=90)
         self.animation_interval = config.getint('Thumbnails', 'animation_interval', fallback=400)
 
+        # Subtitle settings
+        self.sub_color = config.get('Subtitles', 'text_color', fallback='#FFFFFF')
+        self.sub_border_color = config.get('Subtitles', 'outline_color', fallback='#000000')
+        self.sub_scale = config.getfloat('Subtitles', 'font_scale', fallback=1.0)
+
+    def save_subtitle_settings(self, property_name, value):
+        """Save subtitle style settings to ini file."""
+        config = configparser.ConfigParser()
+        if self.config_file.exists():
+            config.read(self.config_file, encoding='utf-8')
+
+        if 'Subtitles' not in config:
+            config['Subtitles'] = {}
+
+        if property_name == "sub-color":
+            config['Subtitles']['text_color'] = value
+        elif property_name == "sub-border-color":
+            config['Subtitles']['outline_color'] = value
+        elif property_name == "sub-scale":
+            config['Subtitles']['font_scale'] = f"{value:.2f}"
+
+        with open(self.config_file, 'w', encoding='utf-8') as f:
+            config.write(f)
+
     def format_time(self, seconds):
         if not seconds:
             return "00:00"

player.py

@@ -31,6 +31,7 @@ class VideoPlayerWidget(QWidget):
     request_hide_main_window = pyqtSignal()
     request_show_main_window = pyqtSignal()
     pause_changed = pyqtSignal(bool)
+    subtitle_style_changed = pyqtSignal(str, object)
 
     def __init__(self, parent=None):
         super().__init__(parent)
@@ -44,6 +45,9 @@ def __init__(self, parent=None):
         self.is_loading = False
         self.auto_play_pending = False
         self.player = None
+        self.sub_color = "#FFFFFF"
+        self.sub_border_color = "#000000"
+        self.sub_scale = 1.0
         self.setup_ui()
         self.setup_mpv()
 
@@ -216,6 +220,10 @@ def setup_mpv(self):
                 log_handler=print,
                 loglevel='warn'
             )
+            
+            # Apply initial subtitle styles
+            self._apply_subtitle_styles()
+
             @self.player.property_observer('time-pos')
             def time_observer(_name, value):
                 if value is not None:
@@ -310,6 +318,7 @@ def load_video(self, file_path, saved_position=0, volume=100, auto_play=True):
 
             self.player.sid = 'no'
             self.player.loadfile(file_path)
+            self._apply_subtitle_styles()
             self.play_btn.setEnabled(True)
             self.progress_slider.setEnabled(True)
             self.frame_back_btn.setEnabled(True)
@@ -658,20 +667,61 @@ def change_subtitle_style(self, property_name, value):
                 # Convert HEX to MPV format (ARGB)
                 hex_color = value.lstrip('#')
                 self.player.sub_color = f"#FF{hex_color.upper()}"
+                self.sub_color = value
+                self.subtitle_style_changed.emit("sub-color", value)
                 print(f"📝 Subtitle color: {value}")
             elif property_name == "sub-border-color":
                 hex_color = value.lstrip('#')
                 self.player.sub_border_color = f"#FF{hex_color.upper()}"
+                self.sub_border_color = value
+                self.subtitle_style_changed.emit("sub-border-color", value)
                 print(f"📝 Subtitle border color: {value}")
             elif property_name == "sub-scale":
                 # value is delta (+5 or -5)
                 current_scale = getattr(self.player, 'sub_scale', 1.0)
                 new_scale = max(0.5, min(3.0, current_scale + value / 100.0))
                 self.player.sub_scale = new_scale
+                self.sub_scale = new_scale
+                self.subtitle_style_changed.emit("sub-scale", new_scale)
                 print(f"📝 Subtitle scale: {new_scale:.2f}")
         except Exception as e:
             print(f"Error changing subtitle style: {e}")
 
+    def set_subtitle_styles(self, color, border_color, scale):
+        """Set initial subtitle styles."""
+        self.sub_color = color
+        self.sub_border_color = border_color
+        self.sub_scale = scale
+        
+        # Also sync with popup
+        if hasattr(self, 'subtitle_btn'):
+            self.subtitle_btn.popup.text_color = color
+            self.subtitle_btn.popup.outline_color = border_color
+            self.subtitle_btn.popup._update_text_color_btn()
+            self.subtitle_btn.popup._update_outline_color_btn()
+            
+        if self.player:
+            self._apply_subtitle_styles()
+
+    def _apply_subtitle_styles(self):
+        """Apply stored subtitle styles to MPV player."""
+        if not self.player:
+            return
+        
+        try:
+            # Color
+            hex_color = self.sub_color.lstrip('#')
+            self.player.sub_color = f"#FF{hex_color.upper()}"
+            
+            # Border
+            hex_border = self.sub_border_color.lstrip('#')
+            self.player.sub_border_color = f"#FF{hex_border.upper()}"
+            
+            # Scale
+            self.player.sub_scale = self.sub_scale
+        except Exception as e:
+            print(f"Error applying subtitle styles: {e}")
+
     def change_subtitle_track(self, index):
         """Switch subtitles on selection."""
         if not self.player: return