-
Notifications
You must be signed in to change notification settings - Fork 374
Expand file tree
/
Copy pathtest_state_sync.py
More file actions
4051 lines (3455 loc) · 141 KB
/
test_state_sync.py
File metadata and controls
4051 lines (3455 loc) · 141 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import json
import logging
import re
import typing as t
from unittest.mock import call, patch
import duckdb # noqa: TID253
import pandas as pd # noqa: TID253
import pytest
import time_machine
from pytest_mock.plugin import MockerFixture
from sqlglot import exp
from sqlmesh.core import constants as c
from sqlmesh.core.config import EnvironmentSuffixTarget
from sqlmesh.core.dialect import parse_one
from sqlmesh.core.engine_adapter import create_engine_adapter
from sqlmesh.core.environment import Environment, EnvironmentStatements
from sqlmesh.core.model import (
FullKind,
IncrementalByTimeRangeKind,
Seed,
SeedKind,
SeedModel,
SqlModel,
)
from sqlmesh.core.snapshot import (
Snapshot,
SnapshotChangeCategory,
SnapshotId,
SnapshotIntervals,
SnapshotNameVersion,
SnapshotTableCleanupTask,
missing_intervals,
)
from sqlmesh.core.state_sync import (
CachingStateSync,
EngineAdapterStateSync,
)
from sqlmesh.core.state_sync.base import (
SCHEMA_VERSION,
SQLGLOT_VERSION,
Versions,
)
from sqlmesh.core.state_sync.common import (
ExpiredBatchRange,
LimitBoundary,
PromotionResult,
RowBoundary,
)
from sqlmesh.utils.date import now_timestamp, to_datetime, to_timestamp
from sqlmesh.utils.errors import SQLMeshError, StateMigrationError
pytestmark = pytest.mark.slow
def _get_cleanup_tasks(
state_sync: EngineAdapterStateSync,
*,
limit: int = 1000,
ignore_ttl: bool = False,
) -> t.List[SnapshotTableCleanupTask]:
batch = state_sync.get_expired_snapshots(
ignore_ttl=ignore_ttl,
batch_range=ExpiredBatchRange.init_batch_range(batch_size=limit),
)
return [] if batch is None else batch.cleanup_tasks
@pytest.fixture
def state_sync(duck_conn, tmp_path):
state_sync = EngineAdapterStateSync(
create_engine_adapter(lambda: duck_conn, "duckdb"),
schema=c.SQLMESH,
cache_dir=tmp_path / c.CACHE,
)
state_sync.migrate()
return state_sync
@pytest.fixture
def snapshots(make_snapshot: t.Callable) -> t.List[Snapshot]:
return [
make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
version="a",
),
make_snapshot(
SqlModel(
name="b",
query=parse_one("select 2, ds"),
),
version="b",
),
]
def compare_snapshot_intervals(x: SnapshotIntervals) -> str:
return x.identifier or ""
def promote_snapshots(
state_sync: EngineAdapterStateSync,
snapshots: t.List[Snapshot],
environment: str,
no_gaps: bool = False,
no_gaps_snapshot_names: t.Optional[t.Set[str]] = None,
environment_suffix_target: EnvironmentSuffixTarget = EnvironmentSuffixTarget.SCHEMA,
environment_catalog_mapping: t.Optional[t.Dict[re.Pattern, str]] = None,
) -> PromotionResult:
env = Environment.from_environment_catalog_mapping(
environment_catalog_mapping or {},
name=environment,
suffix_target=environment_suffix_target,
snapshots=[snapshot.table_info for snapshot in snapshots],
start_at="2022-01-01",
end_at="2022-01-01",
plan_id="test_plan_id",
previous_plan_id="test_plan_id",
)
return state_sync.promote(
env, no_gaps_snapshot_names=no_gaps_snapshot_names if no_gaps else set()
)
def delete_versions(state_sync: EngineAdapterStateSync) -> None:
state_sync.engine_adapter.drop_table(state_sync.version_state.versions_table)
def test_push_snapshots(
state_sync: EngineAdapterStateSync,
make_snapshot: t.Callable,
) -> None:
snapshot_a = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
)
)
snapshot_b = make_snapshot(
SqlModel(
name="b",
query=parse_one("select 2, ds"),
)
)
with pytest.raises(
SQLMeshError,
match=r".*has not been versioned.*",
):
state_sync.push_snapshots([snapshot_a, snapshot_b])
snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING, forward_only=True)
snapshot_b.version = "2"
state_sync.push_snapshots([snapshot_a, snapshot_b])
assert state_sync.get_snapshots([snapshot_a.snapshot_id, snapshot_b.snapshot_id]) == {
snapshot_a.snapshot_id: snapshot_a,
snapshot_b.snapshot_id: snapshot_b,
}
logger = logging.getLogger("sqlmesh.core.state_sync.db.facade")
with patch.object(logger, "error") as mock_logger:
state_sync.push_snapshots([snapshot_a])
assert str({snapshot_a.snapshot_id}) == mock_logger.call_args[0][1]
state_sync.push_snapshots([snapshot_a, snapshot_b])
assert str({snapshot_a.snapshot_id, snapshot_b.snapshot_id}) == mock_logger.call_args[0][1]
# test serialization
state_sync.push_snapshots(
[
make_snapshot(
SqlModel(
name="a",
kind=FullKind(),
query=parse_one(
"""
select 'x' + ' ' as y,
"z" + '\' as z,
"""
),
),
version="1",
)
]
)
def test_duplicates(state_sync: EngineAdapterStateSync, make_snapshot: t.Callable) -> None:
snapshot_a = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
version="1",
)
snapshot_b = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
version="1",
)
snapshot_c = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
version="1",
)
snapshot_b.updated_ts = snapshot_a.updated_ts + 1
snapshot_c.updated_ts = 0
state_sync.push_snapshots([snapshot_a])
state_sync.snapshot_state.push_snapshots([snapshot_a])
state_sync.snapshot_state.push_snapshots([snapshot_b])
state_sync.snapshot_state.push_snapshots([snapshot_c])
state_sync.snapshot_state.clear_cache()
assert (
state_sync.get_snapshots([snapshot_a])[snapshot_a.snapshot_id].updated_ts
== snapshot_b.updated_ts
)
def test_snapshots_exists(state_sync: EngineAdapterStateSync, snapshots: t.List[Snapshot]) -> None:
state_sync.push_snapshots(snapshots)
snapshot_ids = {snapshot.snapshot_id for snapshot in snapshots}
assert state_sync.snapshots_exist(snapshot_ids) == snapshot_ids
@pytest.fixture
def get_snapshot_intervals(state_sync) -> t.Callable[[Snapshot], t.Optional[SnapshotIntervals]]:
def _get_snapshot_intervals(snapshot: Snapshot) -> t.Optional[SnapshotIntervals]:
intervals = state_sync.interval_state.get_snapshot_intervals([snapshot])
return intervals[0] if intervals else None
return _get_snapshot_intervals
def test_add_interval(
state_sync: EngineAdapterStateSync,
make_snapshot: t.Callable,
get_snapshot_intervals: t.Callable,
) -> None:
snapshot = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2020-01-01", "20200101")
assert get_snapshot_intervals(snapshot).intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-02")),
]
state_sync.add_interval(snapshot, "20200101", to_datetime("2020-01-04"))
assert get_snapshot_intervals(snapshot).intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-04")),
]
state_sync.add_interval(snapshot, to_datetime("2020-01-05"), "2020-01-10")
assert get_snapshot_intervals(snapshot).intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-04")),
(to_timestamp("2020-01-05"), to_timestamp("2020-01-11")),
]
snapshot.change_category = SnapshotChangeCategory.BREAKING
snapshot.forward_only = True
state_sync.add_interval(snapshot, to_datetime("2020-01-16"), "2020-01-20", is_dev=True)
intervals = get_snapshot_intervals(snapshot)
assert intervals.intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-04")),
(to_timestamp("2020-01-05"), to_timestamp("2020-01-11")),
]
assert intervals.dev_intervals == [
(to_timestamp("2020-01-16"), to_timestamp("2020-01-21")),
]
def test_add_interval_partial(
state_sync: EngineAdapterStateSync,
make_snapshot: t.Callable,
get_snapshot_intervals: t.Callable,
) -> None:
snapshot = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2023-01-01", to_timestamp("2023-01-01") + 1000)
assert get_snapshot_intervals(snapshot) is None
state_sync.add_interval(snapshot, "2023-01-01", to_timestamp("2023-01-02") + 1000)
assert get_snapshot_intervals(snapshot).intervals == [
(to_timestamp("2023-01-01"), to_timestamp("2023-01-02")),
]
def test_remove_interval(state_sync: EngineAdapterStateSync, make_snapshot: t.Callable) -> None:
snapshot_a = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
snapshot_b = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 2::INT, '2022-01-01'::TEXT AS ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot_a, snapshot_b])
state_sync.add_interval(snapshot_a, "2020-01-01", "2020-01-10")
state_sync.add_interval(snapshot_b, "2020-01-11", "2020-01-30")
num_of_removals = 4
for _ in range(num_of_removals):
state_sync.remove_intervals(
[(snapshot_a, snapshot_a.inclusive_exclusive("2020-01-15", "2020-01-17"))],
remove_shared_versions=True,
)
remove_records_count = state_sync.engine_adapter.fetchone(
"SELECT COUNT(*) FROM sqlmesh._intervals WHERE name = '\"a\"' AND version = 'a' AND is_removed"
)[0] # type: ignore
assert remove_records_count == num_of_removals * 2 # 2 * snapshots
snapshots = state_sync.get_snapshots([snapshot_a, snapshot_b])
assert snapshots[snapshot_a.snapshot_id].intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-15")),
(to_timestamp("2020-01-18"), to_timestamp("2020-01-31")),
]
assert snapshots[snapshot_b.snapshot_id].intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-15")),
(to_timestamp("2020-01-18"), to_timestamp("2020-01-31")),
]
def test_remove_interval_missing_snapshot(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
) -> None:
snapshot_a = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
snapshot_b = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 2::INT, '2022-01-01'::TEXT AS ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot_a, snapshot_b])
state_sync.add_interval(snapshot_a, "2020-01-01", "2020-01-10")
state_sync.add_interval(snapshot_b, "2020-01-11", "2020-01-30")
# Remove snapshot b in order to test the scenario where it is missing
state_sync.delete_snapshots([snapshot_b.snapshot_id])
snapshots = state_sync.get_snapshots([snapshot_a, snapshot_b])
assert len(snapshots) == 1
assert snapshots[snapshot_a.snapshot_id].intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-31")),
]
state_sync.remove_intervals(
[(snapshot_a, snapshot_a.inclusive_exclusive("2020-01-15", "2020-01-17"))],
remove_shared_versions=True,
)
snapshots = state_sync.get_snapshots([snapshot_a, snapshot_b])
assert len(snapshots) == 1
assert snapshots[snapshot_a.snapshot_id].intervals == [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-15")),
(to_timestamp("2020-01-18"), to_timestamp("2020-01-31")),
]
def test_refresh_snapshot_intervals(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
) -> None:
snapshot = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2023-01-01", "2023-01-01")
assert not snapshot.intervals
state_sync.refresh_snapshot_intervals([snapshot])
assert snapshot.intervals == [(to_timestamp("2023-01-01"), to_timestamp("2023-01-02"))]
def test_get_snapshot_intervals(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable, get_snapshot_intervals
) -> None:
state_sync.interval_state.SNAPSHOT_BATCH_SIZE = 1
snapshot_a = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot_a])
state_sync.add_interval(snapshot_a, "2020-01-01", "2020-01-01")
snapshot_b = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 2, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot_b])
snapshot_c = make_snapshot(
SqlModel(
name="c",
cron="@daily",
query=parse_one("select 3, ds"),
),
version="c",
)
state_sync.push_snapshots([snapshot_c])
state_sync.add_interval(snapshot_c, "2020-01-03", "2020-01-03")
a_intervals = get_snapshot_intervals(snapshot_a)
c_intervals = get_snapshot_intervals(snapshot_c)
assert a_intervals.intervals == [(to_timestamp("2020-01-01"), to_timestamp("2020-01-02"))]
assert c_intervals.intervals == [(to_timestamp("2020-01-03"), to_timestamp("2020-01-04"))]
def test_compact_intervals(
state_sync: EngineAdapterStateSync,
make_snapshot: t.Callable,
get_snapshot_intervals: t.Callable,
) -> None:
snapshot = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-10")
state_sync.add_interval(snapshot, "2020-01-11", "2020-01-15")
state_sync.remove_intervals(
[(snapshot, snapshot.inclusive_exclusive("2020-01-05", "2020-01-12"))]
)
state_sync.add_interval(snapshot, "2020-01-12", "2020-01-16")
state_sync.remove_intervals(
[(snapshot, snapshot.inclusive_exclusive("2020-01-14", "2020-01-16"))]
)
expected_intervals = [
(to_timestamp("2020-01-01"), to_timestamp("2020-01-05")),
(to_timestamp("2020-01-12"), to_timestamp("2020-01-14")),
]
assert get_snapshot_intervals(snapshot).intervals == expected_intervals
state_sync.compact_intervals()
assert get_snapshot_intervals(snapshot).intervals == expected_intervals
# Make sure compaction is idempotent.
state_sync.compact_intervals()
assert get_snapshot_intervals(snapshot).intervals == expected_intervals
def test_compact_intervals_delete_batches(
state_sync: EngineAdapterStateSync,
make_snapshot: t.Callable,
mocker: MockerFixture,
) -> None:
snapshot = make_snapshot(
SqlModel(
name="a",
cron="@daily",
query=parse_one("select 1, ds"),
),
version="a",
)
delete_from_mock = mocker.patch.object(state_sync.engine_adapter, "delete_from")
state_sync.interval_state.INTERVAL_BATCH_SIZE = 2
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-11")
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-12")
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-13")
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-14")
state_sync.add_interval(snapshot, "2020-01-01", "2020-01-15")
state_sync.compact_intervals()
delete_from_mock.assert_has_calls(
[call(state_sync.interval_state.intervals_table, mocker.ANY)] * 3
)
def test_promote_snapshots(state_sync: EngineAdapterStateSync, make_snapshot: t.Callable):
snapshot_a = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
)
snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_b_old = make_snapshot(
SqlModel(
name="b",
kind=FullKind(),
query=parse_one("select 2 from a"),
),
nodes={"a": snapshot_a.model},
)
snapshot_b_old.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_b = make_snapshot(
SqlModel(
name="b",
kind=FullKind(),
query=parse_one("select * from a"),
),
nodes={"a": snapshot_a.model},
)
snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_c = make_snapshot(
SqlModel(
name="c",
query=parse_one("select 3, ds"),
),
)
snapshot_c.categorize_as(SnapshotChangeCategory.BREAKING)
with pytest.raises(
SQLMeshError,
match=r"Missing snapshots.*",
):
promote_snapshots(state_sync, [snapshot_a], "prod")
state_sync.push_snapshots([snapshot_a, snapshot_b_old, snapshot_b, snapshot_c])
promotion_result = promote_snapshots(state_sync, [snapshot_a, snapshot_b_old], "prod")
assert set(promotion_result.added) == set([snapshot_a.table_info, snapshot_b_old.table_info])
assert not promotion_result.removed
assert not promotion_result.removed_environment_naming_info
promotion_result = promote_snapshots(
state_sync,
[snapshot_a, snapshot_b_old, snapshot_c],
"prod",
)
assert set(promotion_result.added) == {
snapshot_a.table_info,
snapshot_b_old.table_info,
snapshot_c.table_info,
}
assert not promotion_result.removed
assert not promotion_result.removed_environment_naming_info
prev_snapshot_b_old_updated_ts = snapshot_b_old.updated_ts
prev_snapshot_c_updated_ts = snapshot_c.updated_ts
promotion_result = promote_snapshots(
state_sync,
[snapshot_a, snapshot_b],
"prod",
)
assert set(promotion_result.added) == {snapshot_a.table_info, snapshot_b.table_info}
assert set(promotion_result.removed) == {snapshot_c.table_info}
assert promotion_result.removed_environment_naming_info
assert promotion_result.removed_environment_naming_info.suffix_target.is_schema
assert (
state_sync.get_snapshots([snapshot_c])[snapshot_c.snapshot_id].updated_ts
> prev_snapshot_c_updated_ts
)
assert (
state_sync.get_snapshots([snapshot_b_old])[snapshot_b_old.snapshot_id].updated_ts
> prev_snapshot_b_old_updated_ts
)
snapshot_d = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 2, ds"),
),
)
snapshot_d.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot_d])
promotion_result = promote_snapshots(state_sync, [snapshot_d], "prod")
assert set(promotion_result.added) == {snapshot_d.table_info}
assert set(promotion_result.removed) == {snapshot_b.table_info}
assert promotion_result.removed_environment_naming_info
assert promotion_result.removed_environment_naming_info.suffix_target.is_schema
def test_promote_snapshots_suffix_change(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
):
snapshot_a = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
)
snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_b = make_snapshot(
SqlModel(
name="b",
kind=FullKind(),
query=parse_one("select * from a"),
),
nodes={"a": snapshot_a.model},
)
snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot_a, snapshot_b])
promotion_result = promote_snapshots(
state_sync,
[snapshot_a, snapshot_b],
"prod",
environment_suffix_target=EnvironmentSuffixTarget.TABLE,
)
assert set(promotion_result.added) == {snapshot_a.table_info, snapshot_b.table_info}
assert not promotion_result.removed
assert not promotion_result.removed_environment_naming_info
snapshot_c = make_snapshot(
SqlModel(
name="c",
query=parse_one("select 3, ds"),
),
)
snapshot_c.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot_c])
promotion_result = promote_snapshots(
state_sync,
[snapshot_b, snapshot_c],
"prod",
environment_suffix_target=EnvironmentSuffixTarget.SCHEMA,
)
# We still only add the snapshots that are included in the promotion
assert set(promotion_result.added) == {snapshot_b.table_info, snapshot_c.table_info}
# B does not get removed because the suffix target change doesn't affect it due to running in prod.
assert set(promotion_result.removed) == {snapshot_a.table_info}
# Make sure the removed suffix target is correctly seen as table
assert promotion_result.removed_environment_naming_info is not None
assert promotion_result.removed_environment_naming_info.suffix_target.is_table
promotion_result = promote_snapshots(
state_sync,
[snapshot_b, snapshot_c],
"dev",
environment_suffix_target=EnvironmentSuffixTarget.SCHEMA,
)
# We still only add the snapshots that are included in the promotion
assert set(promotion_result.added) == {snapshot_b.table_info, snapshot_c.table_info}
assert len(promotion_result.removed) == 0
assert promotion_result.removed_environment_naming_info is None
promotion_result = promote_snapshots(
state_sync,
[snapshot_b, snapshot_c],
"dev",
environment_suffix_target=EnvironmentSuffixTarget.TABLE,
)
# All snapshots are promoted due to suffix target change
assert set(promotion_result.added) == {
snapshot_b.table_info,
snapshot_c.table_info,
}
# All snapshots are removed due to suffix target change
assert set(promotion_result.removed) == {
snapshot_b.table_info,
snapshot_c.table_info,
}
assert promotion_result.removed_environment_naming_info is not None
assert promotion_result.removed_environment_naming_info.suffix_target.is_schema
def test_promote_snapshots_catalog_name_override_change(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
):
snapshot_a = make_snapshot(
SqlModel(
name="catalog1.schema.a",
query=parse_one("select 1, ds"),
),
)
snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_b = make_snapshot(
SqlModel(
name="catalog1.schema.b",
kind=FullKind(),
query=parse_one("select * from a"),
),
nodes={"a": snapshot_a.model},
)
snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING)
snapshot_c = make_snapshot(
SqlModel(
name="catalog2.schema.c",
kind=FullKind(),
query=parse_one("select * from a"),
),
nodes={"a": snapshot_a.model},
)
snapshot_c.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot_a, snapshot_b, snapshot_c])
promotion_result = promote_snapshots(
state_sync,
[snapshot_a, snapshot_b, snapshot_c],
"prod",
environment_catalog_mapping={},
)
assert set(promotion_result.added) == {
snapshot_a.table_info,
snapshot_b.table_info,
snapshot_c.table_info,
}
assert not promotion_result.removed
assert not promotion_result.removed_environment_naming_info
snapshot_d = make_snapshot(
SqlModel(
name="catalog1.schema.d",
query=parse_one("select 3, ds"),
),
)
snapshot_d.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot_d])
promotion_result = promote_snapshots(
state_sync,
[snapshot_b, snapshot_c, snapshot_d],
"prod",
environment_catalog_mapping={
re.compile("^prod$"): "catalog1",
},
)
# We still only add the snapshots that are included in the promotion which means removing A
assert set(promotion_result.added) == {
snapshot_b.table_info,
snapshot_c.table_info,
snapshot_d.table_info,
}
# C is removed because of the catalog change. The new one will be created in the new catalog.
# B is not removed because it's catalog did not change and therefore removing would actually result
# in dropping what we just added.
# A is removed because it was explicitly removed from the promotion.
assert set(promotion_result.removed) == {snapshot_a.table_info, snapshot_c.table_info}
# Make sure the removed suffix target correctly has the old catalog name set
assert promotion_result.removed_environment_naming_info
assert promotion_result.removed_environment_naming_info.catalog_name_override is None
promotion_result = promote_snapshots(
state_sync,
[snapshot_b, snapshot_c, snapshot_d],
"prod",
environment_catalog_mapping={
re.compile("^prod$"): "catalog2",
},
)
# All are added since their catalog was changed
assert set(promotion_result.added) == {
snapshot_b.table_info,
snapshot_c.table_info,
snapshot_d.table_info,
}
# All are removed since there were moved from their old catalog location
# Note that C has a catalog set in the model definition of `catalog2` which is what we moved to so you might think
# it shouldn't be removed, but its actual catalog was `catalog1` because of the previous override so therefore
# it should be removed from `catalog1`.
assert set(promotion_result.removed) == {
snapshot_b.table_info,
snapshot_c.table_info,
snapshot_d.table_info,
}
# Make sure the removed suffix target correctly has the old catalog name set
assert promotion_result.removed_environment_naming_info
assert promotion_result.removed_environment_naming_info.catalog_name_override == "catalog1"
def test_promote_snapshots_parent_plan_id_mismatch(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
):
snapshot = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
)
snapshot.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot])
promote_snapshots(state_sync, [snapshot], "prod")
new_environment = Environment(
name="prod",
snapshots=[snapshot.table_info],
start_at="2022-01-01",
end_at="2022-01-01",
plan_id="new_plan_id",
previous_plan_id="test_plan_id",
)
stale_new_environment = Environment(
name="prod",
snapshots=[snapshot.table_info],
start_at="2022-01-01",
end_at="2022-01-01",
plan_id="stale_new_plan_id",
previous_plan_id="test_plan_id",
)
state_sync.promote(new_environment)
with pytest.raises(
SQLMeshError,
match=re.escape(
"Another plan (new_plan_id) was applied to the target environment 'prod' while your current plan (stale_new_plan_id) was still in progress, interrupting it. Please re-apply your plan to resolve this error."
),
):
state_sync.promote(stale_new_environment)
@pytest.mark.parametrize("environment_name", ["dev", "prod"])
def test_promote_environment_expired(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable, environment_name: str
):
snapshot = make_snapshot(
SqlModel(
name="a",
query=parse_one("select 1, ds"),
),
)
snapshot.categorize_as(SnapshotChangeCategory.BREAKING)
state_sync.push_snapshots([snapshot])
promote_snapshots(state_sync, [snapshot], "dev")
state_sync.finalize(state_sync.get_environment("dev"))
state_sync.invalidate_environment("dev")
new_environment = Environment(
name=environment_name,
snapshots=[snapshot.table_info],
start_at="2022-01-01",
end_at="2022-01-01",
plan_id="new_plan_id",
previous_plan_id=None, # No previous plan ID since it's technically a new environment
expiration_ts=now_timestamp() + 3600,
)
assert new_environment.expiration_ts
# This call shouldn't fail.
promotion_result = state_sync.promote(new_environment)
assert promotion_result.added == [snapshot.table_info]
assert promotion_result.removed == []
assert promotion_result.removed_environment_naming_info is None
state_sync.finalize(new_environment)
new_environment.previous_plan_id = new_environment.plan_id
new_environment.plan_id = "another_plan_id"
promotion_result = state_sync.promote(new_environment)
# Should be empty since the environment is no longer expired and nothing has changed
assert promotion_result.removed == []
assert promotion_result.removed_environment_naming_info is None
if environment_name == "prod":
assert promotion_result.added == []
else:
# We should always recreate views in dev environments
assert promotion_result.added == [snapshot.table_info]
def test_promote_snapshots_no_gaps(state_sync: EngineAdapterStateSync, make_snapshot: t.Callable):
model = SqlModel(
name="a",
query=parse_one("select 1, ds"),
kind=IncrementalByTimeRangeKind(time_column="ds"),
start="2022-01-01",
)
snapshot = make_snapshot(model, version="a")
snapshot.change_category = SnapshotChangeCategory.BREAKING
state_sync.push_snapshots([snapshot])
state_sync.add_interval(snapshot, "2022-01-01", "2022-01-02")
promote_snapshots(state_sync, [snapshot], "prod", no_gaps=True)
new_snapshot_same_version = make_snapshot(model, version="a")
new_snapshot_same_version.change_category = SnapshotChangeCategory.INDIRECT_NON_BREAKING
new_snapshot_same_version.fingerprint = snapshot.fingerprint.copy(
update={"data_hash": "new_snapshot_same_version"}
)
state_sync.push_snapshots([new_snapshot_same_version])
state_sync.add_interval(new_snapshot_same_version, "2022-01-03", "2022-01-03")
promote_snapshots(state_sync, [new_snapshot_same_version], "prod", no_gaps=True)
new_snapshot_missing_interval = make_snapshot(model, version="b")
new_snapshot_missing_interval.change_category = SnapshotChangeCategory.BREAKING
new_snapshot_missing_interval.fingerprint = snapshot.fingerprint.copy(
update={"data_hash": "new_snapshot_missing_interval"}
)
state_sync.push_snapshots([new_snapshot_missing_interval])
state_sync.add_interval(new_snapshot_missing_interval, "2022-01-01", "2022-01-02")
with pytest.raises(
SQLMeshError,
match=r".*Detected missing intervals for model .*, interrupting your current plan. Please re-apply your plan to resolve this error.*",
):
promote_snapshots(state_sync, [new_snapshot_missing_interval], "prod", no_gaps=True)
new_snapshot_same_interval = make_snapshot(model, version="c")
new_snapshot_same_interval.change_category = SnapshotChangeCategory.BREAKING
new_snapshot_same_interval.fingerprint = snapshot.fingerprint.copy(
update={"data_hash": "new_snapshot_same_interval"}
)
state_sync.push_snapshots([new_snapshot_same_interval])
state_sync.add_interval(new_snapshot_same_interval, "2022-01-01", "2022-01-03")
promote_snapshots(state_sync, [new_snapshot_same_interval], "prod", no_gaps=True)
# We should skip the gaps check if the snapshot is not representative.
promote_snapshots(
state_sync,
[new_snapshot_missing_interval],
"prod",
no_gaps=True,
no_gaps_snapshot_names=set(),
)
@time_machine.travel("2023-01-08 16:00:00 UTC", tick=False)
def test_promote_snapshots_no_gaps_lookback(
state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
):
model = SqlModel(
name="a",
cron="@hourly",
query=parse_one("select 1, ds"),
kind=IncrementalByTimeRangeKind(time_column="ds", lookback=1),
start="2023-01-01",