-
Notifications
You must be signed in to change notification settings - Fork 377
Expand file tree
/
Copy pathtest_trino.py
More file actions
757 lines (625 loc) · 28.3 KB
/
test_trino.py
File metadata and controls
757 lines (625 loc) · 28.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
import typing as t
from unittest.mock import MagicMock
import pytest
from pytest_mock.plugin import MockerFixture
from sqlglot import exp, parse_one
import sqlmesh.core.dialect as d
from sqlmesh.core.config.connection import TrinoConnectionConfig
from sqlmesh.core.engine_adapter import TrinoEngineAdapter
from sqlmesh.core.model import load_sql_based_model
from sqlmesh.core.model.definition import SqlModel
from sqlmesh.core.dialect import schema_
from sqlmesh.utils.date import to_ds
from sqlmesh.utils.errors import SQLMeshError
from tests.core.engine_adapter import to_sql_calls
pytestmark = [pytest.mark.engine, pytest.mark.trino]
@pytest.fixture
def trino_mocked_engine_adapter(
make_mocked_engine_adapter: t.Callable, mocker: MockerFixture
) -> TrinoEngineAdapter:
def mock_catalog_type(catalog_name):
if "iceberg" in catalog_name:
return "iceberg"
if "delta_lake" in catalog_name:
return "delta_lake"
return "hive"
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_catalog_type",
side_effect=mock_catalog_type,
)
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter._block_until_table_exists",
return_value=True,
)
return make_mocked_engine_adapter(TrinoEngineAdapter)
def test_set_current_catalog(trino_mocked_engine_adapter: TrinoEngineAdapter):
adapter = trino_mocked_engine_adapter
adapter.set_current_catalog("test_catalog")
assert to_sql_calls(adapter) == [
'USE "test_catalog"."information_schema"',
]
@pytest.mark.parametrize("storage_type", ["iceberg", "delta_lake"])
def test_get_catalog_type(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture, storage_type: str
):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="system",
)
assert adapter.current_catalog_type == "hive"
assert adapter.get_catalog_type("foo") == TrinoEngineAdapter.DEFAULT_CATALOG_TYPE
assert adapter.get_catalog_type("datalake_hive") == "hive"
assert adapter.get_catalog_type("datalake_iceberg") == "iceberg"
assert adapter.get_catalog_type("datalake_delta_lake") == "delta_lake"
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value=f"system_{storage_type}",
)
assert adapter.current_catalog_type == storage_type
def test_get_catalog_type_cached(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture
):
adapter = trino_mocked_engine_adapter
mocker.stop(t.cast(MagicMock, adapter.get_catalog_type)) # to make mypy happy
def mock_fetchone(sql):
if "iceberg" in sql:
return ("iceberg",)
return ("hive",)
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.fetchone", side_effect=mock_fetchone
)
fetchone_mock = t.cast(MagicMock, adapter.fetchone) # to make mypy happy
adapter.get_catalog_type("datalake_iceberg")
adapter.get_catalog_type("datalake_iceberg")
adapter.get_catalog_type("datalake_iceberg")
assert fetchone_mock.call_count == 1
adapter.get_catalog_type("datalake")
assert fetchone_mock.call_count == 2
adapter.get_catalog_type("datalake_iceberg")
assert fetchone_mock.call_count == 2
@pytest.mark.parametrize("storage_type", ["hive", "delta_lake"])
def test_partitioned_by_hive_delta(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture, storage_type: str
):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value=f"datalake_{storage_type}",
)
assert adapter.get_catalog_type(f"datalake_{storage_type}") == storage_type
columns_to_types = {
"cola": exp.DataType.build("INT"),
"colb": exp.DataType.build("TEXT"),
}
adapter.create_table("test_table", columns_to_types, partitioned_by=[exp.to_column("colb")])
adapter.ctas("test_table", parse_one("select 1"), partitioned_by=[exp.to_column("colb")]) # type: ignore
assert to_sql_calls(adapter) == [
"""CREATE TABLE IF NOT EXISTS "test_table" ("cola" INTEGER, "colb" VARCHAR) WITH (PARTITIONED_BY=ARRAY['colb'])""",
"""CREATE TABLE IF NOT EXISTS "test_table" WITH (PARTITIONED_BY=ARRAY['colb']) AS SELECT 1""",
]
def test_partitioned_by_iceberg(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture
):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="datalake_iceberg",
)
assert adapter.get_catalog_type("datalake_iceberg") == "iceberg"
columns_to_types = {
"cola": exp.DataType.build("INT"),
"colb": exp.DataType.build("TEXT"),
}
adapter.create_table("test_table", columns_to_types, partitioned_by=[exp.to_column("colb")])
adapter.ctas("test_table", parse_one("select 1"), partitioned_by=[exp.to_column("colb")]) # type: ignore
assert to_sql_calls(adapter) == [
"""CREATE TABLE IF NOT EXISTS "test_table" ("cola" INTEGER, "colb" VARCHAR) WITH (PARTITIONING=ARRAY['colb'])""",
"""CREATE TABLE IF NOT EXISTS "test_table" WITH (PARTITIONING=ARRAY['colb']) AS SELECT 1""",
]
def test_partitioned_by_iceberg_transforms(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture
):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="datalake_iceberg",
)
expressions = d.parse(
"""
MODEL (
name test_table,
partitioned_by (day(cola), truncate(colb, 8), colc),
kind INCREMENTAL_BY_TIME_RANGE(
time_column cola,
),
);
SELECT 1::timestamp AS cola, 2::varchar as colb, 'foo' as colc;
"""
)
model: SqlModel = t.cast(SqlModel, load_sql_based_model(expressions))
adapter.create_table(
table_name=model.view_name,
target_columns_to_types=model.columns_to_types_or_raise,
partitioned_by=model.partitioned_by,
)
adapter.ctas(
table_name=model.view_name,
query_or_df=t.cast(exp.Query, model.query),
partitioned_by=model.partitioned_by,
)
assert to_sql_calls(adapter) == [
"""CREATE TABLE IF NOT EXISTS "test_table" ("cola" TIMESTAMP, "colb" VARCHAR, "colc" VARCHAR) WITH (PARTITIONING=ARRAY['DAY("cola")', 'TRUNCATE("colb", 8)', '"colc"'])""",
"""CREATE TABLE IF NOT EXISTS "test_table" WITH (PARTITIONING=ARRAY['DAY("cola")', 'TRUNCATE("colb", 8)', '"colc"']) AS SELECT CAST(1 AS TIMESTAMP) AS "cola", CAST(2 AS VARCHAR) AS "colb", \'foo\' AS "colc\"""",
]
def test_partitioned_by_with_multiple_catalogs_same_server(
trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture
):
adapter = trino_mocked_engine_adapter
columns_to_types = {
"cola": exp.DataType.build("INT"),
"colb": exp.DataType.build("TEXT"),
}
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="system",
)
adapter.create_table(
"datalake.test_schema.test_table", columns_to_types, partitioned_by=[exp.to_column("colb")]
)
adapter.ctas(
"datalake.test_schema.test_table",
parse_one("select 1"), # type: ignore
partitioned_by=[exp.to_column("colb")],
)
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="iceberg",
)
adapter.create_table(
"datalake_iceberg.test_schema.test_table",
columns_to_types,
partitioned_by=[exp.to_column("colb")],
)
adapter.ctas(
"datalake_iceberg.test_schema.test_table",
parse_one("select 1"), # type: ignore
partitioned_by=[exp.to_column("colb")],
)
assert to_sql_calls(adapter) == [
"""CREATE TABLE IF NOT EXISTS "datalake"."test_schema"."test_table" ("cola" INTEGER, "colb" VARCHAR) WITH (PARTITIONED_BY=ARRAY['colb'])""",
"""CREATE TABLE IF NOT EXISTS "datalake"."test_schema"."test_table" WITH (PARTITIONED_BY=ARRAY['colb']) AS SELECT 1""",
"""CREATE TABLE IF NOT EXISTS "datalake_iceberg"."test_schema"."test_table" ("cola" INTEGER, "colb" VARCHAR) WITH (PARTITIONING=ARRAY['colb'])""",
"""CREATE TABLE IF NOT EXISTS "datalake_iceberg"."test_schema"."test_table" WITH (PARTITIONING=ARRAY['colb']) AS SELECT 1""",
]
def test_comments_hive(mocker: MockerFixture, make_mocked_engine_adapter: t.Callable):
adapter = make_mocked_engine_adapter(TrinoEngineAdapter)
current_catalog_mock = mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog"
)
current_catalog_mock.return_value = "hive"
catalog_type_mock = mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_catalog_type"
)
catalog_type_mock.return_value = "hive"
allowed_table_comment_length = TrinoEngineAdapter.MAX_TABLE_COMMENT_LENGTH
truncated_table_comment = "a" * allowed_table_comment_length
long_table_comment = truncated_table_comment + "b"
allowed_column_comment_length = TrinoEngineAdapter.MAX_COLUMN_COMMENT_LENGTH
truncated_column_comment = "c" * allowed_column_comment_length
long_column_comment = truncated_column_comment + "d"
adapter.create_table(
"test_table",
{"a": exp.DataType.build("INT"), "b": exp.DataType.build("INT")},
table_description=long_table_comment,
column_descriptions={"a": long_column_comment},
)
adapter.ctas(
"test_table",
parse_one("SELECT a, b FROM source_table"),
{"a": exp.DataType.build("INT"), "b": exp.DataType.build("INT")},
table_description=long_table_comment,
column_descriptions={"a": long_column_comment},
)
adapter.create_view(
"test_view",
parse_one("SELECT a, b FROM source_table"),
table_description=long_table_comment,
)
adapter._create_table_comment(
"test_table",
long_table_comment,
)
adapter._create_column_comments(
"test_table",
{"a": long_column_comment},
)
sql_calls = to_sql_calls(adapter)
assert sql_calls == [
f"""CREATE TABLE IF NOT EXISTS "test_table" ("a" INTEGER COMMENT '{truncated_column_comment}', "b" INTEGER) COMMENT '{truncated_table_comment}'""",
'DESCRIBE "test_table"',
f"""CREATE TABLE IF NOT EXISTS "test_table" COMMENT '{truncated_table_comment}' AS SELECT CAST("a" AS INTEGER) AS "a", CAST("b" AS INTEGER) AS "b" FROM (SELECT "a", "b" FROM "source_table") AS "_subquery\"""",
'DESCRIBE "test_table"',
f"""COMMENT ON COLUMN "test_table"."a" IS '{truncated_column_comment}'""",
"""CREATE OR REPLACE VIEW test_view AS SELECT a, b FROM source_table""",
f"""COMMENT ON VIEW "test_view" IS '{truncated_table_comment}'""",
f"""COMMENT ON TABLE "test_table" IS '{truncated_table_comment}'""",
f"""COMMENT ON COLUMN "test_table"."a" IS '{truncated_column_comment}'""",
]
@pytest.mark.parametrize("storage_type", ["iceberg", "delta_lake"])
def test_comments_iceberg_delta(
mocker: MockerFixture, make_mocked_engine_adapter: t.Callable, storage_type: str
):
adapter = make_mocked_engine_adapter(TrinoEngineAdapter)
current_catalog_mock = mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog"
)
current_catalog_mock.return_value = storage_type
catalog_type_mock = mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_catalog_type"
)
catalog_type_mock.return_value = storage_type
allowed_table_comment_length = TrinoEngineAdapter.MAX_TABLE_COMMENT_LENGTH
truncated_table_comment = "a" * allowed_table_comment_length
long_table_comment = truncated_table_comment + "b"
allowed_column_comment_length = TrinoEngineAdapter.MAX_COLUMN_COMMENT_LENGTH
truncated_column_comment = "c" * allowed_column_comment_length
long_column_comment = truncated_column_comment + "d"
adapter.create_table(
"test_table",
{"a": exp.DataType.build("INT"), "b": exp.DataType.build("INT")},
table_description=long_table_comment,
column_descriptions={"a": long_column_comment},
)
adapter.ctas(
"test_table",
parse_one("SELECT a, b FROM source_table"),
{"a": exp.DataType.build("INT"), "b": exp.DataType.build("INT")},
table_description=long_table_comment,
column_descriptions={"a": long_column_comment},
)
adapter.create_view(
"test_view",
parse_one("SELECT a, b FROM source_table"),
table_description=long_table_comment,
)
adapter._create_table_comment(
"test_table",
long_table_comment,
)
adapter._create_column_comments(
"test_table",
{"a": long_column_comment},
)
sql_calls = to_sql_calls(adapter)
assert sql_calls == [
f"""CREATE TABLE IF NOT EXISTS "test_table" ("a" INTEGER COMMENT '{long_column_comment}', "b" INTEGER) COMMENT '{long_table_comment}'""",
f"""CREATE TABLE IF NOT EXISTS "test_table" COMMENT '{long_table_comment}' AS SELECT CAST("a" AS INTEGER) AS "a", CAST("b" AS INTEGER) AS "b" FROM (SELECT "a", "b" FROM "source_table") AS "_subquery\"""",
f"""COMMENT ON COLUMN "test_table"."a" IS '{long_column_comment}'""",
"""CREATE OR REPLACE VIEW test_view AS SELECT a, b FROM source_table""",
f"""COMMENT ON VIEW "test_view" IS '{long_table_comment}'""",
f"""COMMENT ON TABLE "test_table" IS '{long_table_comment}'""",
f"""COMMENT ON COLUMN "test_table"."a" IS '{long_column_comment}'""",
]
def test_delta_timestamps(make_mocked_engine_adapter: t.Callable):
adapter = make_mocked_engine_adapter(TrinoEngineAdapter)
ts6 = exp.DataType.build("timestamp(6)")
ts3_tz = exp.DataType.build("timestamp(3) with time zone")
columns_to_types = {
"ts": exp.DataType.build("TIMESTAMP"),
"ts_1": exp.DataType.build("TIMESTAMP(1)"),
"ts_tz": exp.DataType.build("TIMESTAMP WITH TIME ZONE"),
"ts_tz_1": exp.DataType.build("TIMESTAMP(1) WITH TIME ZONE"),
}
delta_columns_to_types = adapter._to_delta_ts(columns_to_types)
assert delta_columns_to_types == {
"ts": ts6,
"ts_1": ts6,
"ts_tz": ts3_tz,
"ts_tz_1": ts3_tz,
}
def test_table_format(trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="iceberg",
)
expressions = d.parse(
"""
MODEL (
name iceberg.test_table,
kind FULL,
table_format iceberg,
storage_format orc
);
SELECT 1::timestamp AS cola, 2::varchar as colb, 'foo' as colc;
"""
)
model: SqlModel = t.cast(SqlModel, load_sql_based_model(expressions))
adapter.create_table(
table_name=model.name,
target_columns_to_types=model.columns_to_types_or_raise,
table_format=model.table_format,
storage_format=model.storage_format,
)
adapter.ctas(
table_name=model.name,
query_or_df=t.cast(exp.Query, model.query),
target_columns_to_types=model.columns_to_types_or_raise,
table_format=model.table_format,
storage_format=model.storage_format,
)
# Trino needs to ignore the `table_format` property because to create Iceberg tables, you target an Iceberg catalog
# rather than explicitly telling it to create an Iceberg table. So this is testing that `FORMAT='ORC'` is output
# instead of `FORMAT='ICEBERG'` which would be invalid
assert to_sql_calls(adapter) == [
"""CREATE TABLE IF NOT EXISTS "iceberg"."test_table" ("cola" TIMESTAMP, "colb" VARCHAR, "colc" VARCHAR) WITH (format='orc')""",
'''CREATE TABLE IF NOT EXISTS "iceberg"."test_table" WITH (format='orc') AS SELECT CAST("cola" AS TIMESTAMP) AS "cola", CAST("colb" AS VARCHAR) AS "colb", CAST("colc" AS VARCHAR) AS "colc" FROM (SELECT CAST(1 AS TIMESTAMP) AS "cola", CAST(2 AS VARCHAR) AS "colb", \'foo\' AS "colc") AS "_subquery"''',
]
def test_table_location(trino_mocked_engine_adapter: TrinoEngineAdapter, mocker: MockerFixture):
adapter = trino_mocked_engine_adapter
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_current_catalog",
return_value="iceberg",
)
expressions = d.parse(
"""
MODEL (
name iceberg.test_table,
kind FULL,
physical_properties (
location = 'hdfs://some/table/location'
)
);
SELECT 1::timestamp AS cola, 2::varchar as colb, 'foo' as colc;
"""
)
model: SqlModel = t.cast(SqlModel, load_sql_based_model(expressions))
adapter.create_table(
table_name=model.name,
target_columns_to_types=model.columns_to_types_or_raise,
table_properties=model.physical_properties,
)
adapter.ctas(
table_name=model.name,
query_or_df=t.cast(exp.Query, model.query),
target_columns_to_types=model.columns_to_types_or_raise,
table_properties=model.physical_properties,
)
assert to_sql_calls(adapter) == [
'CREATE TABLE IF NOT EXISTS "iceberg"."test_table" ("cola" TIMESTAMP, "colb" VARCHAR, "colc" VARCHAR) WITH (location=\'hdfs://some/table/location\')',
'CREATE TABLE IF NOT EXISTS "iceberg"."test_table" WITH (location=\'hdfs://some/table/location\') AS SELECT CAST("cola" AS TIMESTAMP) AS "cola", CAST("colb" AS VARCHAR) AS "colb", CAST("colc" AS VARCHAR) AS "colc" FROM (SELECT CAST(1 AS TIMESTAMP) AS "cola", CAST(2 AS VARCHAR) AS "colb", \'foo\' AS "colc") AS "_subquery"',
]
def test_schema_location_mapping():
config = TrinoConnectionConfig(
user="user",
host="host",
catalog="catalog",
)
adapter = config.create_engine_adapter()
assert adapter.schema_location_mapping is None
assert adapter._schema_location("foo") is None
config = TrinoConnectionConfig(
user="user",
host="host",
catalog="catalog",
schema_location_mapping={
"^utils$": "s3://utils-bucket/@{schema_name}",
"^landing\\..*$": "s3://raw-data/@{catalog_name}/@{schema_name}",
"^staging.*$": "s3://bucket/@{schema_name}_dev",
"^sqlmesh.*$": "s3://sqlmesh-internal/dev/@{schema_name}",
},
)
adapter = config.create_engine_adapter()
assert adapter.schema_location_mapping is not None
assert adapter._schema_location("foo") is None
assert adapter._schema_location("utils_dev") is None
assert adapter._schema_location("utils") == "s3://utils-bucket/utils"
assert adapter._schema_location("staging_customers") == "s3://bucket/staging_customers_dev"
assert adapter._schema_location("staging_accounts") == "s3://bucket/staging_accounts_dev"
assert (
adapter._schema_location("sqlmesh__staging_customers")
== "s3://sqlmesh-internal/dev/sqlmesh__staging_customers"
)
assert (
adapter._schema_location("sqlmesh__staging_utils")
== "s3://sqlmesh-internal/dev/sqlmesh__staging_utils"
)
assert adapter._schema_location("landing.transactions") == "s3://raw-data/landing/transactions"
assert (
adapter._schema_location(schema_("transactions", "landing"))
== "s3://raw-data/landing/transactions"
)
assert (
adapter._schema_location('"landing"."transactions"') == "s3://raw-data/landing/transactions"
)
def test_create_schema_sets_location(make_mocked_engine_adapter: t.Callable, mocker: MockerFixture):
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter.get_catalog_type",
return_value="iceberg",
)
mocker.patch(
"sqlmesh.core.engine_adapter.trino.TrinoEngineAdapter._block_until_table_exists",
return_value=True,
)
config = TrinoConnectionConfig(
user="user",
host="host",
catalog="catalog",
schema_location_mapping={
"^utils$": "s3://utils-bucket/@{schema_name}",
"^landing\\..*$": "s3://raw-data/@{catalog_name}/@{schema_name}",
"^staging.*$": "s3://bucket/@{schema_name}_dev",
"^sqlmesh.*$": "s3://sqlmesh-internal/dev/@{schema_name}",
"^iceberg\\.staging.*$": "s3://iceberg-catalog/foo_@{schema_name}",
},
)
adapter: TrinoEngineAdapter = make_mocked_engine_adapter(
TrinoEngineAdapter, schema_location_mapping=config.schema_location_mapping
)
adapter.create_schema("foo")
adapter.create_schema(schema_("utils_dev", "db"))
adapter.create_schema(schema_("utils", "db"))
adapter.create_schema(schema_("utils"))
adapter.create_schema(schema_("sqlmesh"))
adapter.create_schema("sqlmesh__staging")
adapter.create_schema(schema_("snapshots", "sqlmesh"))
adapter.create_schema(schema_("staging_foo"))
adapter.create_schema(schema_("staging_bar", "iceberg"))
adapter.create_schema('"catalog"."staging_customers"')
adapter.create_schema(schema_("transactions", "landing"))
assert (
to_sql_calls(adapter)
== [
'CREATE SCHEMA IF NOT EXISTS "foo"', # no match
'CREATE SCHEMA IF NOT EXISTS "db"."utils_dev"', # no match
'CREATE SCHEMA IF NOT EXISTS "db"."utils"', # no match on '^utils$' because of catalog
"CREATE SCHEMA IF NOT EXISTS \"utils\" WITH (LOCATION='s3://utils-bucket/utils')", # match '^utils$'
"CREATE SCHEMA IF NOT EXISTS \"sqlmesh\" WITH (LOCATION='s3://sqlmesh-internal/dev/sqlmesh')", # match '^sqlmesh.*$'
"CREATE SCHEMA IF NOT EXISTS \"sqlmesh__staging\" WITH (LOCATION='s3://sqlmesh-internal/dev/sqlmesh__staging')", # match '^sqlmesh.*$'
'CREATE SCHEMA IF NOT EXISTS "sqlmesh"."snapshots" WITH (LOCATION=\'s3://sqlmesh-internal/dev/snapshots\')', # match '^sqlmesh.*$' on the catalog
"CREATE SCHEMA IF NOT EXISTS \"staging_foo\" WITH (LOCATION='s3://bucket/staging_foo_dev')", # match '^staging.*$'
'CREATE SCHEMA IF NOT EXISTS "iceberg"."staging_bar" WITH (LOCATION=\'s3://iceberg-catalog/foo_staging_bar\')', # match '^iceberg\.staging.*$'
'CREATE SCHEMA IF NOT EXISTS "catalog"."staging_customers"', # no match
'CREATE SCHEMA IF NOT EXISTS "landing"."transactions" WITH (LOCATION=\'s3://raw-data/landing/transactions\')', # match '^landing\..*$'
]
)
def test_session_authorization(trino_mocked_engine_adapter: TrinoEngineAdapter):
adapter = trino_mocked_engine_adapter
# Test 1: No authorization property - should not execute any authorization commands
with adapter.session({}):
pass
assert to_sql_calls(adapter) == []
# Test 2: String authorization
with adapter.session({"authorization": "test_user"}):
adapter.execute("SELECT 1")
assert to_sql_calls(adapter) == [
"SET SESSION AUTHORIZATION 'test_user'",
"SELECT 1",
"RESET SESSION AUTHORIZATION",
]
# Test 3: Expression authorization
adapter.cursor.execute.reset_mock()
with adapter.session({"authorization": exp.Literal.string("another_user")}):
adapter.execute("SELECT 2")
assert to_sql_calls(adapter) == [
"SET SESSION AUTHORIZATION 'another_user'",
"SELECT 2",
"RESET SESSION AUTHORIZATION",
]
# Test 4: RESET is called even if exception occurs during session
adapter.cursor.execute.reset_mock()
try:
with adapter.session({"authorization": "test_user"}):
adapter.execute("SELECT 1")
raise RuntimeError("Test exception")
except RuntimeError:
pass
# Test 5: Invalid authorization value
with pytest.raises(
SQLMeshError,
match="Invalid value for `session_properties.authorization`. Must be a string literal.",
):
with adapter.session({"authorization": exp.Literal.number(1)}):
adapter.execute("SELECT 1")
assert to_sql_calls(adapter) == [
"SET SESSION AUTHORIZATION 'test_user'",
"SELECT 1",
"RESET SESSION AUTHORIZATION",
]
@pytest.mark.parametrize(
"catalog_name,expected_replace",
[
("hive_catalog", False),
("iceberg_catalog", True),
("delta_catalog", False),
("acme_delta_lake", True),
("acme_iceberg", True),
("custom_delta_lake_something", True),
("my_iceberg_store", True),
("plain_catalog", False),
],
)
def test_replace_table_catalog_support(
trino_mocked_engine_adapter: TrinoEngineAdapter, catalog_name, expected_replace
):
adapter = trino_mocked_engine_adapter
adapter.replace_query(
table_name=".".join([catalog_name, "schema", "test_table"]),
query_or_df=t.cast(exp.Query, parse_one("SELECT 1 AS col")),
)
sql_calls = to_sql_calls(adapter)
assert len(sql_calls) == 1
if expected_replace:
assert (
sql_calls[0]
== f'CREATE OR REPLACE TABLE "{catalog_name}"."schema"."test_table" AS SELECT 1 AS "col"'
)
else:
assert (
sql_calls[0]
== f'CREATE TABLE IF NOT EXISTS "{catalog_name}"."schema"."test_table" AS SELECT 1 AS "col"'
)
@pytest.mark.parametrize(
"catalog_type_overrides", [{}, {"my_catalog": "hive"}, {"other_catalog": "iceberg"}]
)
def test_insert_overwrite_time_partition_hive(
make_mocked_engine_adapter: t.Callable, catalog_type_overrides: t.Dict[str, str]
):
config = TrinoConnectionConfig(
user="user",
host="host",
catalog="catalog",
catalog_type_overrides=catalog_type_overrides,
)
adapter: TrinoEngineAdapter = make_mocked_engine_adapter(
TrinoEngineAdapter, catalog_type_overrides=config.catalog_type_overrides
)
adapter.fetchone = MagicMock(return_value=None) # type: ignore
adapter.insert_overwrite_by_time_partition(
table_name=".".join(["my_catalog", "schema", "test_table"]),
query_or_df=t.cast(exp.Query, parse_one("SELECT a, b FROM tbl")),
start="2022-01-01",
end="2022-01-02",
time_column="b",
time_formatter=lambda x, _: exp.Literal.string(to_ds(x)),
target_columns_to_types={"a": exp.DataType.build("INT"), "b": exp.DataType.build("STRING")},
)
assert to_sql_calls(adapter) == [
"SET SESSION my_catalog.insert_existing_partitions_behavior='OVERWRITE'",
'INSERT INTO "my_catalog"."schema"."test_table" ("a", "b") SELECT "a", "b" FROM (SELECT "a", "b" FROM "tbl") AS "_subquery" WHERE "b" BETWEEN \'2022-01-01\' AND \'2022-01-02\'',
"SET SESSION my_catalog.insert_existing_partitions_behavior='APPEND'",
]
@pytest.mark.parametrize(
"catalog_type_overrides",
[
{"my_catalog": "iceberg"},
{"my_catalog": "unknown"},
],
)
def test_insert_overwrite_time_partition_iceberg(
make_mocked_engine_adapter: t.Callable, catalog_type_overrides: t.Dict[str, str]
):
config = TrinoConnectionConfig(
user="user",
host="host",
catalog="catalog",
catalog_type_overrides=catalog_type_overrides,
)
adapter: TrinoEngineAdapter = make_mocked_engine_adapter(
TrinoEngineAdapter, catalog_type_overrides=config.catalog_type_overrides
)
adapter.fetchone = MagicMock(return_value=None) # type: ignore
adapter.insert_overwrite_by_time_partition(
table_name=".".join(["my_catalog", "schema", "test_table"]),
query_or_df=t.cast(exp.Query, parse_one("SELECT a, b FROM tbl")),
start="2022-01-01",
end="2022-01-02",
time_column="b",
time_formatter=lambda x, _: exp.Literal.string(to_ds(x)),
target_columns_to_types={"a": exp.DataType.build("INT"), "b": exp.DataType.build("STRING")},
)
assert to_sql_calls(adapter) == [
'DELETE FROM "my_catalog"."schema"."test_table" WHERE "b" BETWEEN \'2022-01-01\' AND \'2022-01-02\'',
'INSERT INTO "my_catalog"."schema"."test_table" ("a", "b") SELECT "a", "b" FROM (SELECT "a", "b" FROM "tbl") AS "_subquery" WHERE "b" BETWEEN \'2022-01-01\' AND \'2022-01-02\'',
]