Fix: ensure dict lookup won't fail during validation (#922)

georgesittas · web-flow · commit 02449e473012 · 2023-05-30T18:08:32.000+03:00
diff --git a/sqlmesh/core/model/meta.py b/sqlmesh/core/model/meta.py
@@ -201,7 +201,7 @@ def _columns_validator(
             return {column.name: column.args["kind"] for column in v.expressions}
         if isinstance(v, dict):
             return {
-                k: exp.DataType.build(data_type, dialect=values["dialect"])
+                k: exp.DataType.build(data_type, dialect=values.get("dialect"))
                 for k, data_type in v.items()
             }
         return v

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ def _columns_validator(`
`201`	`201`	`return {column.name: column.args["kind"] for column in v.expressions}`
`202`	`202`	`if isinstance(v, dict):`
`203`	`203`	`return {`
`204`		`- k: exp.DataType.build(data_type, dialect=values["dialect"])`
	`204`	`+ k: exp.DataType.build(data_type, dialect=values.get("dialect"))`
`205`	`205`	`for k, data_type in v.items()`
`206`	`206`	`}`
`207`	`207`	`return v`