mssql test fixes

Signed-off-by: Ujfalusi Sándor <ujfalusi.sandor@gmail.com>

Author: ujfalusis

tests/core/engine_adapter/integration/__init__.py

@@ -520,6 +520,14 @@ def get_table_comment(
                     AND c.relkind = '{"v" if table_kind == "VIEW" else "r"}'
                 ;
             """
+        elif self.dialect == "tsql":
+            kind = "table" if table_kind == "BASE TABLE" else "view"
+            query = f"""
+                SELECT 
+                	ep.name,
+                    CAST(ep.value AS NVARCHAR(MAX)) comment 
+                FROM fn_listextendedproperty('MS_Description', 'schema', '{schema_name}', '{kind}', '{table_name}', DEFAULT, DEFAULT) ep
+            """
 
         result = self.engine_adapter.fetchall(query)
 
@@ -629,6 +637,16 @@ def get_column_comments(
                     AND c.relkind = '{"v" if table_kind == "VIEW" else "r"}'
                 ;
             """
+        elif self.dialect == "tsql":
+            kind = "table" if table_kind == "BASE TABLE" else "view"
+            query = f"""
+                SELECT
+                    col.COLUMN_NAME column_name,
+                    CAST(ep.value AS NVARCHAR(MAX)) comment 
+                FROM INFORMATION_SCHEMA.COLUMNS col
+                CROSS APPLY fn_listextendedproperty('MS_Description', 'schema', col.TABLE_SCHEMA, '{kind}', col.TABLE_NAME, 'column', col.COLUMN_NAME) ep
+                WHERE col.TABLE_SCHEMA = '{schema_name}' AND col.TABLE_NAME = '{table_name}'
+            """
 
         result = self.engine_adapter.fetchall(query)
 

tests/core/engine_adapter/test_mssql.py

@@ -1002,26 +1002,3 @@ def python_scd2_model(context, **kwargs):
     snapshot: Snapshot = make_snapshot(m)
     assert snapshot.node.physical_properties == m.physical_properties
     assert snapshot.node.physical_properties.get("mssql_merge_exists")
-
-
-def test_comments(make_mocked_engine_adapter: t.Callable, mocker: MockerFixture):
-    adapter = make_mocked_engine_adapter(MSSQLEngineAdapter)
-
-    columns_to_types = {
-        "cola": exp.DataType.build("INT"),
-        "colb": exp.DataType.build("TEXT"),
-    }
-    adapter.create_table(
-        "test_table", columns_to_types, table_description="\\", column_descriptions={"cola": "\\"}
-    )
-
-    sql_calls = to_sql_calls(adapter)
-    assert sql_calls == [
-        """IF NOT EXISTS (SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'test_table') EXEC('CREATE TABLE [test_table] ([cola] INTEGER, [colb] VARCHAR(MAX))');""",
-        adapter._build_create_comment_table_exp(
-            exp.table_("test_table", quoted=True), "\\", "TABLE"
-        ),
-        adapter._build_create_comment_column_exp(
-            exp.table_("test_table", quoted=True), "cola", "\\", "TABLE"
-        ),
-    ]