Skip to content

Commit 0f682ed

Browse files
authored
Fix: Backfilling batch size for seeds should always be None (#979)
1 parent 6418195 commit 0f682ed

3 files changed

Lines changed: 10 additions & 1 deletion

File tree

sqlmesh/core/model/definition.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -872,6 +872,13 @@ def seed_path(self) -> Path:
872872
def depends_on_past(self) -> bool:
873873
return False
874874

875+
@property
876+
def batch_size(self) -> t.Optional[int]:
877+
# Unlike other model kinds, the batch size provided in the SEED kind represents the
878+
# maximum number of rows to insert in a single batch.
879+
# We should never batch intervals for seed models.
880+
return None
881+
875882
def to_dehydrated(self) -> SeedModel:
876883
"""Creates a dehydrated copy of this model.
877884

tests/core/test_model.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,8 @@ def test_seed():
456456
"name": exp.DataType.build("varchar"),
457457
}
458458

459+
assert model.batch_size is None
460+
459461

460462
def test_seed_provided_columns():
461463
expressions = parse(

tests/core/test_snapshot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def test_fingerprint_seed_model():
432432

433433
expected_fingerprint = SnapshotFingerprint(
434434
data_hash="3834815287",
435-
metadata_hash="1624292983",
435+
metadata_hash="1120323454",
436436
)
437437

438438
model = load_model(expressions, path=Path("./examples/sushi/models/test_model.sql"))

0 commit comments

Comments
 (0)