clean up

Author: mykalmax

web/common/src/components/Lineage/LineageContext.ts

@@ -52,22 +52,22 @@ export function getInitial<
 >() {
   return {
     showOnlySelectedNodes: false,
-    setShowOnlySelectedNodes: () => { },
+    setShowOnlySelectedNodes: () => {},
     selectedNodes: new Set<TNodeID>(),
-    setSelectedNodes: () => { },
+    setSelectedNodes: () => {},
     selectedEdges: new Set<TEdgeID>(),
-    setSelectedEdges: () => { },
+    setSelectedEdges: () => {},
     selectedNodeId: null,
-    setSelectedNodeId: () => { },
+    setSelectedNodeId: () => {},
     zoom: ZOOM_THRESHOLD,
-    setZoom: () => { },
+    setZoom: () => {},
     edges: [],
-    setEdges: () => { },
+    setEdges: () => {},
     nodes: [],
     nodesMap: {},
-    setNodesMap: () => { },
+    setNodesMap: () => {},
     isBuildingLayout: false,
-    setIsBuildingLayout: () => { },
+    setIsBuildingLayout: () => {},
     currentNode: null,
   }
 }

web/common/src/components/Lineage/LineageLayout.tsx

@@ -69,8 +69,8 @@ export function LineageLayout<
   edgeTypes?: EdgeTypes
   className?: string
   controls?:
-  | React.ReactNode
-  | (({ setCenter }: { setCenter: SetCenter }) => React.ReactNode)
+    | React.ReactNode
+    | (({ setCenter }: { setCenter: SetCenter }) => React.ReactNode)
   onNodeClick?: (
     event: React.MouseEvent<Element, MouseEvent>,
     node: LineageNode<TNodeData, TNodeID>,

web/common/src/components/Lineage/layout/dagreLayout.worker.ts

@@ -19,7 +19,6 @@ self.onmessage = <
     const nodes = Object.values(nodesMap)
     const nodeCount = nodes.length
     const edgeCount = edges.length
-    const maxCount = Math.max(nodeCount, edgeCount)
 
     if (nodeCount === 0)
       return self.postMessage({
@@ -44,17 +43,16 @@ self.onmessage = <
     g.setDefaultEdgeLabel(() => ({}))
 
     // Building layout already heavy operation, so trying to optimize it a bit
-    for (let i = 0; i < maxCount; i++) {
-      if (i < edgeCount) {
-        g.setEdge(edges[i].source, edges[i].target)
-      }
-      if (i < nodeCount) {
-        const node = nodes[i]
-        g.setNode(node.id, {
-          width: node.width || DEFAULT_NODE_WIDTH,
-          height: node.height || 0,
-        })
-      }
+    for (let i = 0; i < edgeCount; i++) {
+      g.setEdge(edges[i].source, edges[i].target)
+    }
+
+    for (let i = 0; i < nodeCount; i++) {
+      const node = nodes[i]
+      g.setNode(node.id, {
+        width: node.width || DEFAULT_NODE_WIDTH,
+        height: node.height || 0,
+      })
     }
 
     dagre.layout(g)

web/common/src/components/Lineage/stories/ModelLineage.tsx

@@ -38,7 +38,11 @@ import {
   cleanupLayoutWorker,
   getLayoutedGraph as getDagreLayoutedGraph,
 } from '../layout/dagreLayout'
-import { type LineageEdge, type LineageNodesMap, ZOOM_THRESHOLD } from '../utils'
+import {
+  type LineageEdge,
+  type LineageNodesMap,
+  ZOOM_THRESHOLD,
+} from '../utils'
 import {
   type EdgeData,
   ModelLineageContext,
@@ -252,12 +256,12 @@ export const ModelLineage = ({
     return edgesColumnLevel.length > 0
       ? edgesColumnLevel
       : getTransformedModelEdges<
-        ModelName,
-        EdgeData,
-        ModelNodeId,
-        ModelEdgeId,
-        ModelColumnID
-      >(adjacencyListKeys, adjacencyList, transformEdge)
+          ModelName,
+          EdgeData,
+          ModelNodeId,
+          ModelEdgeId,
+          ModelColumnID
+        >(adjacencyListKeys, adjacencyList, transformEdge)
   }, [adjacencyListKeys, adjacencyList, transformEdge, edgesColumnLevel])
 
   const calculateLayout = React.useMemo(() => {

web/common/src/components/Lineage/stories/ModelNode.tsx

@@ -109,18 +109,18 @@ export const ModelNode = React.memo(function ModelNode({
   const nodeDetailsHeight =
     zoom > ZOOM_THRESHOLD
       ? calculateNodeDetailsHeight({
-        nodeDetailsCount: 0,
-      })
+          nodeDetailsCount: 0,
+        })
       : 0
   const selectedColumnsHeight = calculateSelectedColumnsHeight(
     modelSelectedColumns.length,
   )
   const columnsHeight =
     zoom > ZOOM_THRESHOLD && shouldShowColumns
       ? calculateColumnsHeight({
-        columnsCount: calculateNodeColumnsCount(columns.length),
-        hasColumnsFilter,
-      })
+          columnsCount: calculateNodeColumnsCount(columns.length),
+          hasColumnsFilter,
+        })
       : 0
 
   // If zoom is less than ZOOM_THRESHOLD, we are making node looks bigger
@@ -231,7 +231,9 @@ export const ModelNode = React.memo(function ModelNode({
                 grayscale
                 className={cn(
                   'w-full overflow-hidden cursor-default truncate',
-                  zoom > ZOOM_THRESHOLD ? ' text-xs' : 'text-2xl justify-center',
+                  zoom > ZOOM_THRESHOLD
+                    ? ' text-xs'
+                    : 'text-2xl justify-center',
                 )}
               />
             </HorizontalContainer>