fix: forall with only one criteria (#701)

* fix: forall with only one criteria

Apply the `NOT` predicate before `REDUCE` to handle cases where only
one criteria is specified.

* tidy: don't add extra parens

Author: plaflamme

examples/sushi/models/waiter_as_customer_by_day.sql

@@ -7,7 +7,8 @@ MODEL (
   owner jen,
   cron '@daily',
   audits (
-    not_null(columns=[waiter_id])
+    not_null(columns = [waiter_id]),
+    forall(criteria = [LENGTH(waiter_name) > 0])
   )
 );
 

sqlmesh/core/audit/builtin.py

@@ -68,8 +68,11 @@
 SELECT *
 FROM @this_model
 WHERE @REDUCE(
-  @criteria,
-  (l, r) -> NOT (l) OR NOT (r)
+  @EACH(
+    @criteria,
+    c -> NOT (c)
+  ),
+  (l, r) -> l OR r
 )
     """,
 )

tests/core/test_audit.py

@@ -220,6 +220,15 @@ def test_number_of_rows_audit(model: Model):
 
 
 def test_forall_audit(model: Model):
+    rendered_query_a = builtin.forall_audit.render_query(
+        model,
+        criteria=[parse_one("a >= b")],
+    )
+    assert (
+        rendered_query_a.sql()
+        == "SELECT * FROM (SELECT * FROM db.test_model AS test_model WHERE test_model.ds <= '1970-01-01' AND test_model.ds >= '1970-01-01') AS _q_0 WHERE NOT (_q_0.a >= _q_0.b)"
+    )
+
     rendered_query_a = builtin.forall_audit.render_query(
         model,
         criteria=[parse_one("a >= b"), parse_one("c + d - e < 1.0")],