Fix: Prevent formatting=false throwing an error (#4819)

erindru · web-flow · commit 2e0f6f1af69a · 2025-06-26T11:40:29.000+12:00
diff --git a/sqlmesh/core/model/definition.py b/sqlmesh/core/model/definition.py
@@ -2886,6 +2886,7 @@ def render_expression(
             for name, args in values
         )
     ),
+    "formatting": str,
 }
 
 
diff --git a/tests/core/test_model.py b/tests/core/test_model.py
@@ -9973,9 +9973,9 @@ def test_formatting_flag_serde():
     )
 
     model = load_sql_based_model(expressions)
+    assert model.render_definition()[0].sql() == "MODEL (\nname test_model,\nformatting False\n)"
 
     model_json = model.json()
-
     assert "formatting" not in json.loads(model_json)
 
     deserialized_model = SqlModel.parse_raw(model_json)

Original file line number	Diff line number	Diff line change
`@@ -9973,9 +9973,9 @@ def test_formatting_flag_serde():`
`9973`	`9973`	`)`
`9974`	`9974`
`9975`	`9975`	`model = load_sql_based_model(expressions)`
	`9976`	`+ assert model.render_definition()[0].sql() == "MODEL (\nname test_model,\nformatting False\n)"`
`9976`	`9977`
`9977`	`9978`	`model_json = model.json()`
`9978`		`-`
`9979`	`9979`	`assert "formatting" not in json.loads(model_json)`
`9980`	`9980`
`9981`	`9981`	`deserialized_model = SqlModel.parse_raw(model_json)`