Fix: Use the model's dialect when printing expressions as part of error messages (#3666)

izeigerman · web-flow · commit 42b07a093507 · 2025-01-20T10:35:19.000-08:00
diff --git a/sqlmesh/core/model/definition.py b/sqlmesh/core/model/definition.py
@@ -1303,7 +1303,7 @@ def validate_definition(self) -> None:
                 continue
             if not alias:
                 raise_config_error(
-                    f"Outer projection '{expression}' must have inferrable names or explicit aliases.",
+                    f"Outer projection '{expression.sql(dialect=self.dialect)}' must have inferrable names or explicit aliases.",
                     self._path,
                 )
             name_counts[alias] = name_counts.get(alias, 0) + 1

Original file line number	Diff line number	Diff line change
`@@ -1303,7 +1303,7 @@ def validate_definition(self) -> None:`
`1303`	`1303`	`continue`
`1304`	`1304`	`if not alias:`
`1305`	`1305`	`raise_config_error(`
`1306`		`- f"Outer projection '{expression}' must have inferrable names or explicit aliases.",`
	`1306`	`+ f"Outer projection '{expression.sql(dialect=self.dialect)}' must have inferrable names or explicit aliases.",`
`1307`	`1307`	`self._path,`
`1308`	`1308`	`)`
`1309`	`1309`	`name_counts[alias] = name_counts.get(alias, 0) + 1`