Fix: Broken build

Author: izeigerman

setup.py

@@ -65,7 +65,7 @@
             "agate==1.7.1",
             f"apache-airflow=={os.environ.get('AIRFLOW_VERSION', '2.9.1')}",
             "opentelemetry-proto==1.27.0",  # pip was having trouble resolving this transitive dependency of airflow
-            "beautifulsoup4",
+            "beautifulsoup4==4.12.3",
             "clickhouse-connect",
             "cryptography",
             "custom-materializations",

sqlmesh/core/console.py

@@ -5,6 +5,7 @@
 import typing as t
 import unittest
 import uuid
+import logging
 
 from hyperscript import h
 from rich.console import Console as RichConsole
@@ -47,6 +48,9 @@
     LayoutWidget = t.TypeVar("LayoutWidget", bound=t.Union[widgets.VBox, widgets.HBox])
 
 
+logger = logging.getLogger(__name__)
+
+
 SNAPSHOT_CHANGE_CATEGORY_STR = {
     None: "Unknown",
     SnapshotChangeCategory.BREAKING: "Breaking",
@@ -409,7 +413,7 @@ def log_error(self, message: str) -> None:
         pass
 
     def log_warning(self, message: str) -> None:
-        pass
+        logger.warning(message)
 
     def log_success(self, message: str) -> None:
         pass
@@ -1183,6 +1187,7 @@ def log_error(self, message: str) -> None:
         self._print(f"[red]{message}[/red]")
 
     def log_warning(self, message: str) -> None:
+        logger.warning(message)
         if not self.ignore_warnings:
             self._print(f"[yellow]{message}[/yellow]")
 
@@ -2311,6 +2316,7 @@ def log_error(self, message: str) -> None:
         self._write(message, style="bold red")
 
     def log_warning(self, message: str) -> None:
+        logger.warning(message)
         if not self.ignore_warnings:
             self._write(message, style="bold yellow")
 

sqlmesh/core/renderer.py

@@ -547,7 +547,6 @@ def _optimize_query(self, query: exp.Query, all_deps: t.Set[str]) -> exp.Query:
             if self._validate_query:
                 raise_config_error(warning, self._path)
 
-            logger.warning(warning)
             get_console().log_warning(warning)
 
         try:
@@ -578,7 +577,6 @@ def _optimize_query(self, query: exp.Query, all_deps: t.Set[str]) -> exp.Query:
 
             query = original
 
-            logger.warning(warning)
             get_console().log_warning(warning)
         except Exception as ex:
             raise_config_error(

sqlmesh/core/schema_diff.py

@@ -383,9 +383,10 @@ def _is_coerceable_type(self, current_type: exp.DataType, new_type: exp.DataType
             if is_coerceable:
                 from sqlmesh.core.console import get_console
 
-                warning = f"Coercing type {current_type} to {new_type} which means an alter will not be performed and therefore the resulting table structure will not match what is in the query.\nUpdate your model to cast the value to {current_type} type in order to remove this warning."
-                logger.warning(warning)
-                get_console().log_warning(warning)
+                get_console().log_warning(
+                    f"Coercing type {current_type} to {new_type} which means an alter will not be performed and therefore the resulting table structure will not match what is in the query.\nUpdate your model to cast the value to {current_type} type in order to remove this warning."
+                )
+
             return is_coerceable
         return False
 

sqlmesh/core/test/definition.py

@@ -329,7 +329,11 @@ def create_test(
         name = normalize_model_name(name, default_catalog=default_catalog, dialect=dialect)
         model = models.get(name)
         if not model:
-            logger.warning(f"Model '{name}' was not found{' at ' + str(path) if path else ''}")
+            from sqlmesh.core.console import get_console
+
+            get_console().log_warning(
+                f"Model '{name}' was not found{' at ' + str(path) if path else ''}"
+            )
             return None
 
         if isinstance(model, SqlModel):

tests/core/test_model.py

@@ -1,6 +1,5 @@
 # ruff: noqa: F811
 import json
-import logging
 import typing as t
 from datetime import date, datetime
 from pathlib import Path
@@ -276,8 +275,7 @@ def test_model_validation_union_query():
 
 
 def test_model_qualification():
-    logger = logging.getLogger("sqlmesh.core.renderer")
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(get_console(), "log_warning") as mock_logger:
         expressions = d.parse(
             """
             MODEL (
@@ -2677,8 +2675,7 @@ def test_update_schema():
     model.update_schema(schema)
     assert model.mapping_schema == {'"table_a"': {"a": "INT"}}
 
-    logger = logging.getLogger("sqlmesh.core.renderer")
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(get_console(), "log_warning") as mock_logger:
         model.render_query(needs_optimization=True)
         assert mock_logger.call_args[0][0] == missing_schema_warning_msg(
             '"db"."table"', ('"table_b"',)
@@ -2694,8 +2691,6 @@ def test_update_schema():
 
 
 def test_missing_schema_warnings():
-    logger = logging.getLogger("sqlmesh.core.renderer")
-
     full_schema = MappingSchema(
         {
             "a": {"x": exp.DataType.build("int")},
@@ -2710,34 +2705,36 @@ def test_missing_schema_warnings():
         },
     )
 
+    console = get_console()
+
     # star, no schema, no deps
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(d.parse("MODEL (name test); SELECT * FROM (SELECT 1 a) x"))
         model.render_query(needs_optimization=True)
         mock_logger.assert_not_called()
 
     # star, full schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(d.parse("MODEL (name test); SELECT * FROM a CROSS JOIN b"))
         model.update_schema(full_schema)
         model.render_query(needs_optimization=True)
         mock_logger.assert_not_called()
 
     # star, partial schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(d.parse("MODEL (name test); SELECT * FROM a CROSS JOIN b"))
         model.update_schema(partial_schema)
         model.render_query(needs_optimization=True)
         assert mock_logger.call_args[0][0] == missing_schema_warning_msg('"test"', ('"b"',))
 
     # star, no schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(d.parse("MODEL (name test); SELECT * FROM b JOIN a"))
         model.render_query(needs_optimization=True)
         assert mock_logger.call_args[0][0] == missing_schema_warning_msg('"test"', ('"a"', '"b"'))
 
     # no star, full schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(
             d.parse("MODEL (name test); SELECT x::INT FROM a CROSS JOIN b")
         )
@@ -2746,7 +2743,7 @@ def test_missing_schema_warnings():
         mock_logger.assert_not_called()
 
     # no star, partial schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(
             d.parse("MODEL (name test); SELECT x::INT FROM a CROSS JOIN b")
         )
@@ -2755,7 +2752,7 @@ def test_missing_schema_warnings():
         mock_logger.assert_not_called()
 
     # no star, empty schema
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(console, "log_warning") as mock_logger:
         model = load_sql_based_model(
             d.parse("MODEL (name test); SELECT x::INT FROM a CROSS JOIN b")
         )

tests/core/test_test.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import logging
 import datetime
 import typing as t
 from pathlib import Path
@@ -21,6 +20,7 @@
     ModelDefaultsConfig,
 )
 from sqlmesh.core.context import Context
+from sqlmesh.core.console import get_console
 from sqlmesh.core.dialect import parse
 from sqlmesh.core.engine_adapter import EngineAdapter
 from sqlmesh.core.macros import MacroEvaluator, macro
@@ -1771,8 +1771,7 @@ def test_unknown_model_warns(mocker: MockerFixture) -> None:
         """
     )
 
-    logger = logging.getLogger("sqlmesh.core.test.definition")
-    with patch.object(logger, "warning") as mock_logger:
+    with patch.object(get_console(), "log_warning") as mock_logger:
         ModelTest.create_test(
             body=body,
             test_name="test_unknown_model",