Chore: Show resources to be deleted and enhance warnings in destroy

themisvaltinos · themisvaltinos · commit 495e96a1c34f · 2025-07-14T18:05:48.000+03:00
diff --git a/docs/reference/cli.md b/docs/reference/cli.md
@@ -149,7 +149,7 @@ Options:
 ```
 Usage: sqlmesh destroy
 
-  Removes all project resources, including warehouse objects, state tables, the SQLMesh cache and any build artifacts.
+  Removes all state tables, the SQLMesh cache and all project resources, including warehouse objects. This includes all tables, views and schemas managed by SQLMesh, as well as any external resources that may have been created by other tools within those schemas.
 
 Options:
   --help               Show this message and exit.
diff --git a/docs/reference/notebook.md b/docs/reference/notebook.md
@@ -250,7 +250,7 @@ options:
 ```
 %destroy
 
-Removes all project resources, including warehouse objects, state tables, the SQLMesh cache and any build artifacts.
+Removes all state tables, the SQLMesh cache, and other project resources, including warehouse objects. This includes all tables, views, and schemas managed by SQLMesh, as well as any external resources that may have been created by other tools within those schemas.
 ```
 
 #### dlt_refresh
diff --git a/sqlmesh/core/console.py b/sqlmesh/core/console.py
@@ -1277,14 +1277,20 @@ def stop_cleanup(self, success: bool = False) -> None:
             self.log_error("Cleanup failed!")
 
     def start_destroy(self) -> bool:
-        self.log_warning(
+        self.log_error(
             (
-                "This will permanently delete all engine-managed objects, state tables and SQLMesh cache.\n"
+                "!!!  EXTREME CAUTION: DESTRUCTIVE OPERATION !!!\n\n"
+                "The 'destroy' command will PERMANENTLY DELETE:\n"
+                "  • ALL state tables and metadata\n"
+                "  • ALL SQLMesh cache and build artifacts\n"
+                "  • ALL tables and views in the project's schemas/datasets\n"
+                "  • ALL schemas/datasets managed by SQLMesh in this project\n\n"
+                "!!! WARNING: This includes external tables created or managed by other tools !!!\n\n"
                 "The operation is irreversible and may disrupt any currently running or scheduled plans.\n"
-                "Use this command only when you intend to fully reset the project."
+                "Only use this command when you intend to COMPLETELY DESTROY the project.\n"
             )
         )
-        if not self._confirm("Proceed?"):
+        if not self._confirm("Do you understand the risks and want to see what will be deleted?"):
             self.log_error("Destroy aborted!")
             return False
         return True
diff --git a/sqlmesh/core/context.py b/sqlmesh/core/context.py
@@ -842,8 +842,7 @@ def destroy(self) -> bool:
 
         if self.console.start_destroy():
             try:
-                self._destroy()
-                success = True
+                success = self._destroy()
             finally:
                 self.console.stop_destroy(success=success)
 
@@ -2705,7 +2704,81 @@ def _context_diff(
             always_recreate_environment=always_recreate_environment,
         )
 
-    def _destroy(self) -> None:
+    def _destroy(self) -> bool:
+        environments = self.state_reader.get_environments()
+
+        schemas_to_delete = set()
+        tables_to_delete = set()
+        views_to_delete = set()
+        all_snapshot_infos = set()
+
+        # For each environment find schemas and tables
+        for environment in environments:
+            all_snapshot_infos.update(environment.snapshots)
+            snapshots = self.state_reader.get_snapshots(environment.snapshots).values()
+            for snapshot in snapshots:
+                if snapshot.is_model and not snapshot.is_symbolic:
+                    # Get the appropriate adapter
+                    if environment.gateway_managed and snapshot.model_gateway:
+                        adapter = self.engine_adapters.get(
+                            snapshot.model_gateway, self.engine_adapter
+                        )
+                    else:
+                        adapter = self.engine_adapter
+
+                    if environment.suffix_target.is_schema or environment.suffix_target.is_catalog:
+                        schema = snapshot.qualified_view_name.schema_for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        catalog = snapshot.qualified_view_name.catalog_for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        if catalog:
+                            schemas_to_delete.add(f"{catalog}.{schema}")
+                        else:
+                            schemas_to_delete.add(schema)
+
+                    if environment.suffix_target.is_table:
+                        view_name = snapshot.qualified_view_name.for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        views_to_delete.add(view_name)
+
+                    # Add snapshot tables
+                    table_name = snapshot.table_name()
+                    tables_to_delete.add(table_name)
+
+        # Display what will be deleted
+        self.console.log_error("\n" + "=" * 50 + "\n")
+        if schemas_to_delete:
+            self.console.log_error("Schemas to be deleted:")
+            for schema in sorted(schemas_to_delete):
+                self.console.log_error(f"  • {schema}")
+
+        if views_to_delete:
+            self.console.log_error("\nEnvironment views to be deleted:")
+            for view in sorted(views_to_delete):
+                self.console.log_error(f"  • {view}")
+
+        if tables_to_delete:
+            self.console.log_error("\nSnapshot tables to be deleted:")
+            for table in sorted(tables_to_delete):
+                self.console.log_error(f"  • {table}")
+
+        self.console.log_error("\nAll SQLMesh state tables will be deleted")
+        self.console.log_error("\n" + "=" * 50 + "\n")
+
+        # Final confirmation with stronger warning
+        self.console.log_error(
+            "!!! CRITICAL WARNING: This action will PERMANENTLY DELETE ALL the above resources!\n"
+            "This includes ALL tables, views and schemas managed by SQLMesh AND potentially\n"
+            "external resources created by other tools in these schemas. This action is IRREVERSIBLE!\n"
+        )
+
+        if not self.console._confirm("Are you ABSOLUTELY SURE you want to proceed with deletion?"):  # type: ignore
+            self.console.log_error("Destroy operation cancelled.")
+            return False
+
         # Invalidate all environments, including prod
         for environment in self.state_reader.get_environments():
             self.state_sync.invalidate_environment(name=environment.name, protect_prod=False)
@@ -2721,6 +2794,8 @@ def _destroy(self) -> None:
         # Finally clear caches
         self.clear_caches()
 
+        return True
+
     def _run_janitor(self, ignore_ttl: bool = False) -> None:
         current_ts = now_timestamp()
 
diff --git a/tests/core/test_integration.py b/tests/core/test_integration.py
@@ -6281,7 +6281,9 @@ def test_destroy(copy_to_temp_path):
     context.fetchdf(f"SELECT * FROM db_1.first_schema.model_two")
 
     # Use the destroy command to remove all data objects and state
-    context._destroy()
+    # Mock the console confirmation to automatically return True
+    with patch.object(context.console, "_confirm", return_value=True):
+        context._destroy()
 
     # Ensure all tables have been removed
     for table_name in state_tables:
diff --git a/tests/integrations/jupyter/test_magics.py b/tests/integrations/jupyter/test_magics.py
@@ -898,16 +898,32 @@ def test_destroy(
     assert not output.stderr
     text_output = convert_all_html_output_to_text(output)
     expected_messages = [
-        "[WARNING] This will permanently delete all engine-managed objects, state tables and SQLMesh cache.\n"
-        "The operation is irreversible and may disrupt any currently running or scheduled plans.\n"
-        "Use this command only when you intend to fully reset the project.",
+        (
+            "!!!  EXTREME CAUTION: DESTRUCTIVE OPERATION !!!\n\n"
+            "The 'destroy' command will PERMANENTLY DELETE:\n"
+            "  • ALL state tables and metadata\n"
+            "  • ALL SQLMesh cache and build artifacts\n"
+            "  • ALL tables and views in the project's schemas/datasets\n"
+            "  • ALL schemas/datasets managed by SQLMesh in this project\n\n"
+            "!!! WARNING: This includes external tables created or managed by other tools !!!\n\n"
+            "The operation is irreversible and may disrupt any currently running or scheduled plans.\n"
+            "Only use this command when you intend to COMPLETELY DESTROY the project."
+        ),
+        "Do you understand the risks and want to see what will be deleted? [y/n]:",
+        "Schemas to be deleted:",
+        "• memory.sushi",
+        "Snapshot tables to be deleted:",
+        "All SQLMesh state tables will be deleted",
+        (
+            "!!! CRITICAL WARNING: This action will PERMANENTLY DELETE ALL the above resources!\n"
+            "This includes ALL tables, views and schemas managed by SQLMesh AND potentially\n"
+            "external resources created by other tools in these schemas. This action is IRREVERSIBLE!"
+        ),
+        "Are you ABSOLUTELY SURE you want to proceed with deletion? [y/n]:",
         "Environment 'prod' invalidated.",
         "Deleted object memory.sushi",
         'Deleted object "memory"."raw"."model1"',
-        'Deleted object "memory"."raw"."model1"',
         'Deleted object "memory"."raw"."model2"',
-        'Deleted object "memory"."raw"."model2"',
-        'Deleted object "memory"."raw"."demographics"',
         'Deleted object "memory"."raw"."demographics"',
         "State tables removed.",
         "Destroy completed successfully.",
