Fix: show column descriptions for unaliased columns in UI (#1487)

treysp · web-flow · commit 4a44bec23b0c · 2023-09-27T10:30:10.000-05:00
* Use alias_or_name instead of alias

* Remove dev code
diff --git a/sqlmesh/core/model/definition.py b/sqlmesh/core/model/definition.py
@@ -1004,7 +1004,7 @@ def column_descriptions(self) -> t.Dict[str, str]:
                 return {}
 
             self._column_descriptions = {
-                select.alias: "\n".join(comment.strip() for comment in select.comments)
+                select.alias_or_name: "\n".join(comment.strip() for comment in select.comments)
                 for select in query.selects
                 if select.comments
             }

Original file line number	Diff line number	Diff line change
`@@ -1004,7 +1004,7 @@ def column_descriptions(self) -> t.Dict[str, str]:`
`1004`	`1004`	`return {}`
`1005`	`1005`
`1006`	`1006`	`self._column_descriptions = {`
`1007`		`- select.alias: "\n".join(comment.strip() for comment in select.comments)`
	`1007`	`+ select.alias_or_name: "\n".join(comment.strip() for comment in select.comments)`
`1008`	`1008`	`for select in query.selects`
`1009`	`1009`	`if select.comments`
`1010`	`1010`	`}`