Skip to content

Commit 7e21452

Browse files
committed
PR feedback 1 (george)
1 parent 383d974 commit 7e21452

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies = [
2424
"requests",
2525
"rich[jupyter]",
2626
"ruamel.yaml",
27-
"sqlglot[rs]~=27.26.0",
27+
"sqlglot[rs]~=27.27.0",
2828
"tenacity",
2929
"time-machine",
3030
"json-stream"

sqlmesh/dbt/column.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def column_types_to_sqlmesh(
4242
)
4343
if column_def.args.get("constraints"):
4444
logger.warning(
45-
f"Ignoring unsupported constraints for column '{name}' with definition '{column.data_type}'."
45+
f"Ignoring unsupported constraints for column '{name}' with definition '{column.data_type}'. Please refer to github.com/TobikoData/sqlmesh/issues/4717 for more information."
4646
)
4747
kind = column_def.kind
4848
if kind:

tests/dbt/test_transformation.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,6 @@ def test_seed_column_types():
860860
logger = logging.getLogger("sqlmesh.dbt.column")
861861
with patch.object(logger, "warning") as mock_logger:
862862
sqlmesh_seed = seed.to_sqlmesh(context)
863-
mock_logger.assert_called_once()
864863
assert "Ignoring unsupported constraints" in mock_logger.call_args[0][0]
865864
assert sqlmesh_seed.columns_to_types == expected_column_types
866865

0 commit comments

Comments
 (0)