Chore: warn instead of raising if unit test references unknown model (#3763)

Author: georgesittas

sqlmesh/core/test/__init__.py

@@ -57,18 +57,18 @@ def run_tests(
                 ).create_engine_adapter(register_comments_override=False)
                 testing_adapter_by_gateway[gateway] = testing_engine_adapter
 
-            tests.append(
-                ModelTest.create_test(
-                    body=body,
-                    test_name=metadata.test_name,
-                    models=models,
-                    engine_adapter=testing_engine_adapter,
-                    dialect=dialect,
-                    path=metadata.path,
-                    default_catalog=default_catalog,
-                    preserve_fixtures=preserve_fixtures,
-                )
+            test = ModelTest.create_test(
+                body=body,
+                test_name=metadata.test_name,
+                models=models,
+                engine_adapter=testing_engine_adapter,
+                dialect=dialect,
+                path=metadata.path,
+                default_catalog=default_catalog,
+                preserve_fixtures=preserve_fixtures,
             )
+            if test:
+                tests.append(test)
 
         result = t.cast(
             ModelTextTestResult,

sqlmesh/core/test/definition.py

@@ -310,7 +310,7 @@ def create_test(
         path: Path | None,
         preserve_fixtures: bool = False,
         default_catalog: str | None = None,
-    ) -> ModelTest:
+    ) -> t.Optional[ModelTest]:
         """Create a SqlModelTest or a PythonModelTest.
 
         Args:
@@ -329,7 +329,8 @@ def create_test(
         name = normalize_model_name(name, default_catalog=default_catalog, dialect=dialect)
         model = models.get(name)
         if not model:
-            _raise_error(f"Model '{name}' was not found", path)
+            logger.warning(f"Model '{name}' was not found{' at ' + str(path) if path else ''}")
+            return None
 
         if isinstance(model, SqlModel):
             test_type: t.Type[ModelTest] = SqlModelTest
@@ -759,6 +760,8 @@ def generate_test(
         path=fixture_path,
         default_catalog=model.default_catalog,
     )
+    if not test:
+        return
 
     test.setUp()
 

tests/core/test_test.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
+import logging
 import datetime
 import typing as t
 from pathlib import Path
-from unittest.mock import call
+from unittest.mock import call, patch
 
 import pandas as pd
 import pytest
@@ -1760,6 +1761,29 @@ def test_complicated_recursive_cte() -> None:
     )
 
 
+def test_unknown_model_warns(mocker: MockerFixture) -> None:
+    body = load_yaml(
+        """
+model: unknown
+outputs:
+  query:
+  - c: 1
+        """
+    )
+
+    logger = logging.getLogger("sqlmesh.core.test.definition")
+    with patch.object(logger, "warning") as mock_logger:
+        ModelTest.create_test(
+            body=body,
+            test_name="test_unknown_model",
+            models={},  # type: ignore
+            engine_adapter=mocker.Mock(),
+            dialect=None,
+            path=None,
+        )
+        assert mock_logger.mock_calls == [call("Model '\"unknown\"' was not found")]
+
+
 def test_test_generation(tmp_path: Path) -> None:
     init_example_project(tmp_path, dialect="duckdb")