fix: raise SQLMeshError when invalidating a nonexistent environment

The sqlmesh invalidate command previously accepted any environment name,
even if the environment did not exist, silently reporting success. Now
it checks that the environment exists first and raises a clear
SQLMeshError if it does not.

Fixes #5621

Signed-off-by: Nuzia Rijki <noezhiya@gmail.com>

Author: noezhiya-dot

sqlmesh/core/context.py

@@ -1831,6 +1831,9 @@ def invalidate_environment(self, name: str, sync: bool = False) -> None:
                 be deleted asynchronously by the janitor process.
         """
         name = Environment.sanitize_name(name)
+        stored_environment = self.state_sync.get_environment(name)
+        if not stored_environment:
+            raise SQLMeshError(f"Environment '{name}' does not exist.")
         self.state_sync.invalidate_environment(name)
         if sync:
             self._cleanup_environments(name=name)

tests/core/test_context.py

@@ -1202,6 +1202,22 @@ def test_invalidate_environment_no_sync_skips_cleanup(sushi_context, mocker: Moc
     state_sync_mock.delete_expired_environments.assert_not_called()
 
 
+@pytest.mark.slow
+def test_invalidate_environment_nonexistent_raises(
+    sushi_context, mocker: MockerFixture
+) -> None:
+    """invalidate_environment should raise SQLMeshError if the environment does not exist."""
+    state_sync_mock = mocker.patch.object(
+        type(sushi_context), "state_sync", new_callable=mocker.PropertyMock
+    ).return_value
+    state_sync_mock.get_environment.return_value = None
+
+    with pytest.raises(SQLMeshError, match="Environment 'doesnotexist' does not exist."):
+        sushi_context.invalidate_environment("doesnotexist")
+
+    state_sync_mock.invalidate_environment.assert_not_called()
+
+
 @pytest.mark.slow
 def test_plan_default_end(sushi_context_pre_scheduling: Context):
     prod_plan_builder = sushi_context_pre_scheduling.plan_builder("prod")