Include built-in audits into the snapshot fingerprint calculation (#642)

Author: izeigerman

sqlmesh/core/snapshot/definition.py

@@ -10,7 +10,7 @@
 from sqlglot import exp
 
 from sqlmesh.core import constants as c
-from sqlmesh.core.audit import Audit
+from sqlmesh.core.audit import BUILT_IN_AUDITS, Audit
 from sqlmesh.core.model import (
     Model,
     PythonModel,
@@ -786,21 +786,26 @@ def _model_metadata_hash(model: Model, audits: t.Dict[str, Audit]) -> str:
     ]
 
     for audit_name, audit_args in sorted(model.audits, key=lambda a: a[0]):
-        if audit_name not in audits:
-            continue
-
-        audit = audits[audit_name]
-        metadata.extend(
-            [
-                audit.name,
-                audit.render_query(model, **t.cast(t.Dict[str, t.Any], audit_args)).sql(
-                    identify=True, comments=True
-                ),
-                audit.dialect,
-                str(audit.skip),
-                str(audit.blocking),
-            ]
-        )
+        metadata.append(audit_name)
+
+        if audit_name in BUILT_IN_AUDITS:
+            for arg_name, arg_value in audit_args.items():
+                metadata.append(arg_name)
+                metadata.append(arg_value.sql(identify=True, comments=True))
+        elif audit_name in audits:
+            audit = audits[audit_name]
+            metadata.extend(
+                [
+                    audit.render_query(model, **t.cast(t.Dict[str, t.Any], audit_args)).sql(
+                        identify=True, comments=True
+                    ),
+                    audit.dialect,
+                    str(audit.skip),
+                    str(audit.blocking),
+                ]
+            )
+        else:
+            raise SQLMeshError(f"Unexpected audit name '{audit_name}'.")
 
     # Add comments from the model query.
     for e, _, _ in model.render_query().walk():

tests/core/test_snapshot.py

@@ -4,7 +4,7 @@
 import pytest
 from _pytest.monkeypatch import MonkeyPatch
 from pytest_mock.plugin import MockerFixture
-from sqlglot import exp, parse, parse_one
+from sqlglot import exp, parse, parse_one, to_column
 
 from sqlmesh.core.config import AutoCategorizationMode, CategorizerConfig
 from sqlmesh.core.model import (
@@ -419,6 +419,16 @@ def test_fingerprint_jinja_macros(model: Model):
     assert updated_fingerprint.metadata_hash == original_fingerprint.metadata_hash
 
 
+def test_fingerprint_builtin_audits(model: Model, parent_model: Model):
+    fingerprint = fingerprint_from_model(model, models={})
+
+    model = SqlModel.parse_obj(
+        {**model.dict(), "audits": [("unique_values", {"columns": exp.convert([to_column("a")])})]}
+    )
+    new_fingerprint = fingerprint_from_model(model, models={})
+    assert new_fingerprint != fingerprint
+
+
 def test_stamp(model: Model):
     original_fingerprint = fingerprint_from_model(model, models={})