Skip to content

Commit a4b85c1

Browse files
committed
Fix: not propogating external kind
1 parent cbcf09f commit a4b85c1

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"requests",
4545
"rich",
4646
"ruamel.yaml",
47-
"sqlglot~=13.2.1",
47+
"sqlglot~=13.2.2",
4848
"fsspec",
4949
],
5050
extras_require={

sqlmesh/core/model/definition.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,6 +1157,7 @@ def create_external_model(
11571157
name,
11581158
dialect=dialect,
11591159
path=path,
1160+
kind="EXTERNAL",
11601161
**kwargs,
11611162
)
11621163

tests/core/test_schema_loader.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,18 @@ def test_create_external_models(sushi_context):
6060
)
6161

6262
sushi_context.upsert_model(model)
63-
assert sushi_context.models["sushi.raw_fruits"].columns_to_types == {
63+
raw_fruits = sushi_context.models["sushi.raw_fruits"]
64+
assert raw_fruits.kind.is_symbolic
65+
assert raw_fruits.kind.is_external
66+
assert raw_fruits.columns_to_types == {
6467
"id": exp.DataType.build("BIGINT"),
6568
"name": exp.DataType.build("VARCHAR"),
6669
}
6770

68-
assert sushi_context.models["sushi.fruits"].columns_to_types == {
71+
fruits = sushi_context.models["sushi.fruits"]
72+
assert not fruits.kind.is_symbolic
73+
assert not fruits.kind.is_external
74+
assert fruits.columns_to_types == {
6975
"id": exp.DataType.build("BIGINT"),
7076
"name": exp.DataType.build("VARCHAR"),
7177
}

0 commit comments

Comments
 (0)