Chore: improve metadata update console printing (#3824)

Author: georgesittas

sqlmesh/core/console.py

@@ -957,7 +957,8 @@ def _show_summary_tree_for(
                     )
                 elif context_diff.indirectly_modified(name):
                     indirect.add(f"[indirect]{display_name}")
-                elif context_diff.metadata_updated(name):
+
+                if context_diff.metadata_updated(name):
                     metadata.add(
                         f"[metadata]{display_name}"
                         if no_diff
@@ -1051,7 +1052,7 @@ def _show_categorized_snapshots(self, plan: Plan, default_catalog: t.Optional[st
             if context_diff.directly_modified(snapshot.name):
                 category_str = SNAPSHOT_CHANGE_CATEGORY_STR[snapshot.change_category]
                 tree = Tree(
-                    f"[bold][direct]Directly Modified: {snapshot.display_name(plan.environment_naming_info, default_catalog, dialect=self.dialect)} ({category_str})"
+                    f"\n[bold][direct]Directly Modified: {snapshot.display_name(plan.environment_naming_info, default_catalog, dialect=self.dialect)} ({category_str})"
                 )
                 indirect_tree = None
                 for child_sid in sorted(plan.indirectly_modified.get(snapshot.snapshot_id, set())):
@@ -1069,13 +1070,16 @@ def _show_categorized_snapshots(self, plan: Plan, default_catalog: t.Optional[st
                     indirect_tree = self._limit_model_names(indirect_tree, self.verbose)
             elif context_diff.metadata_updated(snapshot.name):
                 tree = Tree(
-                    f"[bold][metadata]Metadata Updated: {snapshot.display_name(plan.environment_naming_info, default_catalog, dialect=self.dialect)}"
+                    f"\n[bold][metadata]Metadata Updated: {snapshot.display_name(plan.environment_naming_info, default_catalog, dialect=self.dialect)}"
                 )
             else:
                 continue
 
-            self._print(Syntax(context_diff.text_diff(snapshot.name), "sql", word_wrap=True))
-            self._print(tree)
+            text_diff = context_diff.text_diff(snapshot.name)
+            if text_diff:
+                self._print("")
+                self._print(Syntax(text_diff, "sql", word_wrap=True))
+                self._print(tree)
 
     def _show_missing_dates(self, plan: Plan, default_catalog: t.Optional[str]) -> None:
         """Displays the models with missing dates."""

tests/integrations/jupyter/test_magics.py

@@ -238,7 +238,7 @@ def test_diff(sushi_context, notebook, convert_all_html_output_to_text, get_all_
     assert len(output.outputs) == 2
     assert convert_all_html_output_to_text(output) == [
         "Differences from the `prod` environment:",
-        "Models:\n└── Directly Modified:\n    └── sqlmesh_example.test",
+        "Models:\n├── Directly Modified:\n│   └── sqlmesh_example.test\n└── Metadata Updated:\n    └── sqlmesh_example.test",
     ]
     assert get_all_html_output(output) == [
         str(
@@ -266,7 +266,7 @@ def test_diff(sushi_context, notebook, convert_all_html_output_to_text, get_all_
                         autoescape=False,
                     )
                 )
-                + "└── "
+                + "├── "
                 + str(
                     h(
                         "span",
@@ -275,6 +275,15 @@ def test_diff(sushi_context, notebook, convert_all_html_output_to_text, get_all_
                         autoescape=False,
                     )
                 )
+                + "│   └── sqlmesh_example.test└── "
+                + str(
+                    h(
+                        "span",
+                        {"style": "font-weight: bold"},
+                        "Metadata Updated:",
+                        autoescape=False,
+                    )
+                )
                 + "    └── sqlmesh_example.test",
                 autoescape=False,
             )