Feat: add formatter options to render command#4753
Merged
Conversation
219adf4 to
6fdbee1
Compare
6fdbee1 to
36e09e5
Compare
Contributor
|
My wonder here is whether we should try to standardise it into a struct that is much easier to reuse that the flags pass in. For me if you want to format it in a certain way, you probably want it in your config. |
Collaborator
Author
@benfdking we have a pydantic model for that config already. I've used it in this PR as well. It's just that we allow you to override the various settings in one-off |
erindru
reviewed
Jun 17, 2025
bb2c0ff to
a8f2293
Compare
a8f2293 to
7bac9e1
Compare
themisvaltinos
approved these changes
Jun 23, 2025
Collaborator
themisvaltinos
left a comment
There was a problem hiding this comment.
Looks good to me!
VaggelisD
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.