Skip to content

Feat: add formatter options to render command#4753

Merged
georgesittas merged 2 commits into
mainfrom
jo/add_format_opts_to_render
Jun 23, 2025
Merged

Feat: add formatter options to render command#4753
georgesittas merged 2 commits into
mainfrom
jo/add_format_opts_to_render

Conversation

@georgesittas
Copy link
Copy Markdown
Collaborator

No description provided.

@georgesittas georgesittas requested a review from a team June 17, 2025 12:14
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch 2 times, most recently from 219adf4 to 6fdbee1 Compare June 17, 2025 12:30
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from 6fdbee1 to 36e09e5 Compare June 17, 2025 13:07
@benfdking
Copy link
Copy Markdown
Contributor

My wonder here is whether we should try to standardise it into a struct that is much easier to reuse that the flags pass in. For me if you want to format it in a certain way, you probably want it in your config.

@georgesittas
Copy link
Copy Markdown
Collaborator Author

georgesittas commented Jun 17, 2025

My wonder here is whether we should try to standardise it into a struct that is much easier to reuse that the flags pass in. For me if you want to format it in a certain way, you probably want it in your config.

@benfdking we have a pydantic model for that config already. I've used it in this PR as well. It's just that we allow you to override the various settings in one-off render commands.

Comment thread sqlmesh/magics.py Outdated
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from bb2c0ff to a8f2293 Compare June 19, 2025 16:31
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from a8f2293 to 7bac9e1 Compare June 19, 2025 16:42
@georgesittas georgesittas requested a review from a team June 19, 2025 16:57
Copy link
Copy Markdown
Collaborator

@themisvaltinos themisvaltinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment thread sqlmesh/cli/main.py
Comment thread sqlmesh/cli/main.py
@georgesittas georgesittas merged commit 66ac52a into main Jun 23, 2025
25 checks passed
@georgesittas georgesittas deleted the jo/add_format_opts_to_render branch June 23, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants