♻️ Replaced simple aggregate functions with direct use of properties. (#482)

Author: danielmackay

src/Application/UseCases/Heroes/Commands/UpdateHero/UpdateHeroCommand.cs

@@ -28,8 +28,8 @@ public async Task<ErrorOr<Guid>> Handle(UpdateHeroCommand request, CancellationT
         if (hero is null)
             return HeroErrors.NotFound;
 
-        hero.UpdateName(request.Name);
-        hero.UpdateAlias(request.Alias);
+        hero.Name = request.Name;
+        hero.Alias = request.Alias;
         var powers = request.Powers.Select(p => new Power(p.Name, p.PowerLevel));
         hero.UpdatePowers(powers);
 

src/Domain/Heroes/Hero.cs

@@ -9,8 +9,30 @@ namespace SSW.CleanArchitecture.Domain.Heroes;
 public class Hero : AggregateRoot<HeroId>
 {
     private readonly List<Power> _powers = [];
-    public string Name { get; private set; } = null!;
-    public string Alias { get; private set; } = null!;
+
+    private string _name = null!;
+    private string _alias = null!;
+
+    public string Name
+    {
+        get => _name;
+        set
+        {
+            ThrowIfNullOrWhiteSpace(value, nameof(Name));
+            _name = value;
+        }
+    }
+
+    public string Alias
+    {
+        get => _alias;
+        set
+        {
+            ThrowIfNullOrWhiteSpace(value, nameof(Alias));
+            _alias = value;
+        }
+    }
+
     public int PowerLevel { get; private set; }
     public TeamId? TeamId { get; private set; }
 
@@ -21,25 +43,11 @@ private Hero() { }
     public static Hero Create(string name, string alias)
     {
         Guid.CreateVersion7();
-        var hero = new Hero { Id = HeroId.From(Guid.CreateVersion7()) };
-        hero.UpdateName(name);
-        hero.UpdateAlias(alias);
+        var hero = new Hero { Id = HeroId.From(Guid.CreateVersion7()), Name = name, Alias = alias };
 
         return hero;
     }
 
-    public void UpdateName(string name)
-    {
-        ThrowIfNullOrWhiteSpace(name);
-        Name = name;
-    }
-
-    public void UpdateAlias(string alias)
-    {
-        ThrowIfNullOrWhiteSpace(alias);
-        Alias = alias;
-    }
-
     public void UpdatePowers(IEnumerable<Power> updatedPowers)
     {
         _powers.Clear();

src/Domain/Teams/Team.cs

@@ -8,7 +8,16 @@ namespace SSW.CleanArchitecture.Domain.Teams;
 
 public class Team : AggregateRoot<TeamId>
 {
-    public string Name { get; private set; } = null!;
+    public string Name
+    {
+        get => _name;
+        private set
+        {
+            ThrowIfNullOrWhiteSpace(value, nameof(Name));
+            _name = value;
+        }
+    }
+
     public int TotalPowerLevel { get; private set; }
     public TeamStatus Status { get; private set; }
 
@@ -17,16 +26,14 @@ public class Team : AggregateRoot<TeamId>
     private Mission? CurrentMission => _missions.FirstOrDefault(m => m.Status == MissionStatus.InProgress);
 
     private readonly List<Hero> _heroes = [];
+    private string _name = null!;
     public IReadOnlyList<Hero> Heroes => _heroes.AsReadOnly();
 
     private Team() { }
 
     public static Team Create(string name)
     {
-        ThrowIfNullOrWhiteSpace(name);
-
         var team = new Team { Id = TeamId.From(Guid.CreateVersion7()), Name = name, Status = TeamStatus.Available };
-
         return team;
     }