XS⚠️ ◾ Exclude internal hours from billed days - #751
Merged
Conversation
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
jimmidier
approved these changes
Nov 19, 2025
AttackOnMorty
deleted the
fix-exclude-internal-hours-from-billed-days
branch
November 25, 2025 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per my conversation with @jimmidier, billed days should not include internal hours because we only care about client hours.
This pull request updates the employee billing logic to improve accuracy when calculating billed days, especially regarding project-specific billing and excluding internal projects. The changes primarily refactor how billed days are calculated and used throughout the codebase.
Billing logic improvements
GetTotalBilledDayswithGetBilledDaysinGetFreeEmployeesAction.cs, now calculating billed days for a specific employee and their first project, rather than aggregating across all projects.GetBillableEmployeesmethod to use the newGetBilledDayssignature, which takes both the employee and the project, ensuring more precise billing per project.GetBilledDaysinEmployeesHelper.csthat calculates billed days only for non-SSW (external) projects and ignores internal projects, improving accuracy. The previous methods for total billed days and simple billed days by hours are now commented out.No