Skip to content

XS⚠️ ◾ Exclude internal hours from billed days - #751

Merged
AttackOnMorty merged 1 commit into
mainfrom
fix-exclude-internal-hours-from-billed-days
Nov 25, 2025
Merged

XS⚠️ ◾ Exclude internal hours from billed days#751
AttackOnMorty merged 1 commit into
mainfrom
fix-exclude-internal-hours-from-billed-days

Conversation

@AttackOnMorty

Copy link
Copy Markdown
Member
  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

As per my conversation with @jimmidier, billed days should not include internal hours because we only care about client hours.

  1. What was changed?

This pull request updates the employee billing logic to improve accuracy when calculating billed days, especially regarding project-specific billing and excluding internal projects. The changes primarily refactor how billed days are calculated and used throughout the codebase.

Billing logic improvements

  • Replaced usage of GetTotalBilledDays with GetBilledDays in GetFreeEmployeesAction.cs, now calculating billed days for a specific employee and their first project, rather than aggregating across all projects.
  • Updated the GetBillableEmployees method to use the new GetBilledDays signature, which takes both the employee and the project, ensuring more precise billing per project.
  • Added a new version of GetBilledDays in EmployeesHelper.cs that calculates billed days only for non-SSW (external) projects and ignores internal projects, improving accuracy. The previous methods for total billed days and simple billed days by hours are now commented out.
  1. Did you do pair or mob programming?

No

@github-actions

Copy link
Copy Markdown

PR Metrics

Thanks for keeping your pull request small.
⚠️ Consider adding additional tests.

Lines
Product Code 32
Test Code -
Subtotal 32
Ignored Code -
Total 32

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title Exclude internal hours from billed days XS⚠️ ◾ Exclude internal hours from billed days Nov 18, 2025
@AttackOnMorty
AttackOnMorty merged commit 2b74ff9 into main Nov 25, 2025
1 check passed
@AttackOnMorty
AttackOnMorty deleted the fix-exclude-internal-hours-from-billed-days branch November 25, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants