XS✔ ◾ Remove dead My Shaves portal IPC surface that leaked raw JSON (#454)

[tomek-i]

Summary

After signing in and clicking "My Shave(s)" in an older Desktop build, users saw a raw JSON payload instead of a formatted UI (see attached screenshot/video on #454). Investigating on main today:

• The current "Shaves" page (HomePage.tsx, routed at /) already renders a proper table/card UI, sourced from the local database via shave.getAll() — this was the fix delivered by PR XS⚠️ ◾ change My Shaves list to use local database #830 ("change My Shaves list to use local database").
• However, the old portal:get-my-shaves IPC handler that XS⚠️ ◾ change My Shaves list to use local database #830 replaced was never removed. It still exists end-to-end (IPC channel, ipcMain.handle, preload binding, and GetMyShavesResponse/ShaveItem types) and returns the raw parsed /me/shaves API response as-is, with no formatting.
• That handler is dead code today — no component in the current UI calls ipcClient.portal.getMyShaves() (confirmed via repo-wide search; its sibling getMyProjects is consumed by ProjectsPage.tsx, for contrast). The screenshot on My Shave shows raw JSON payload on sign-in (desktop) #454 is from an older build (pre-L⚠️ ◾ 💄 UI overhaul of homepage, navigation and shaves page #815 top-nav layout) whose "My Shaves" button evidently called this raw endpoint directly.

Since the handler is unreachable from any current UI action, the literal repro no longer happens on main. But leaving unused code that dumps a raw API payload lying around is exactly the "unfinished feature exposed" risk the issue calls out — it could get wired back up by accident. This PR removes it entirely so that can't happen.

Changes

• src/backend/ipc/channels.ts — remove PORTAL_GET_MY_SHAVES channel constant
• src/backend/ipc/portal-handlers.ts — remove the ipcMain.handle(PORTAL_GET_MY_SHAVES, ...) block and its now-unused https/GetMyShavesResponse imports
• src/backend/preload.ts — remove the channel constant and portal.getMyShaves bridge binding
• src/backend/types/index.ts, src/ui/src/types/index.ts — remove the now-unused ShaveItem/GetMyShavesResponse types
• src/ui/src/services/ipc-client.ts — remove the portal.getMyShaves type declaration and its import

No behavior change to the real "My Shaves" page — it never used this handler.

Testing performed

• npm run build — clean (tsc, no dangling references)
• npm rebuild better-sqlite3 --build-from-source && npx vitest run --reporter=verbose --exclude 'src/ui/**' — 691/691 tests passed
• npm --prefix src/ui install && npm --prefix src/ui test — 255/255 tests passed
• npm run lint — clean (one pre-existing, unrelated info-level note in Cloud360LiveView.tsx, not touched by this change)
• Repo-wide grep confirms zero remaining references to PORTAL_GET_MY_SHAVES, getMyShaves, GetMyShavesResponse, ShaveItem

Closes #454

[Copilot]

Pull request overview

This PR removes an unused (“dead”) Portal IPC endpoint (portal:get-my-shaves) and its related types/IPC surface to prevent any accidental re-exposure of an unformatted raw JSON payload to the UI. It aligns the codebase with the current implementation where “Shaves” are sourced from the local DB (shave.getAll()) rather than the Portal /me/shaves response.

Changes:

• Removed the PORTAL_GET_MY_SHAVES IPC channel constant and end-to-end wiring (handler + preload bridge).
• Removed the now-unused getMyShaves typing from the renderer IPC client surface.
• Removed ShaveItem / GetMyShavesResponse types from both backend and UI type re-exports.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/backend/ipc/channels.ts	Removes the unused PORTAL_GET_MY_SHAVES channel constant.
src/backend/ipc/portal-handlers.ts	Deletes the unused IPC handler (and its imports) that returned raw /me/shaves JSON.
src/backend/preload.ts	Removes the preload bridge binding for portal.getMyShaves.
src/backend/types/index.ts	Removes unused ShaveItem / GetMyShavesResponse exports.
src/ui/src/types/index.ts	Removes unused ShaveItem / GetMyShavesResponse exports.
src/ui/src/services/ipc-client.ts	Removes the portal.getMyShaves declaration/import from the typed IPC client surface.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.