Skip to content

Commit 6e3b2e9

Browse files
parmi93TofMassilia13320
authored andcommitted
Make message buffer const in ECC sign
Mark the buffer to sign as `const` in `xxx_ecc_generate_signature()` to reflect that the input buffer is not modified. This improves const-correctness and clarifies the API contract.
1 parent a329b21 commit 6e3b2e9

6 files changed

Lines changed: 8 additions & 8 deletions

File tree

api/stse_ecc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ stse_ReturnCode_t stse_ecc_generate_signature(
5757
stse_Handler_t *pSTSE,
5858
PLAT_UI8 slot_number,
5959
stse_ecc_key_type_t key_type,
60-
PLAT_UI8 *pMessage,
60+
const PLAT_UI8 *pMessage,
6161
PLAT_UI16 message_length,
6262
PLAT_UI8 *pSignature) {
6363
stse_ReturnCode_t ret;

api/stse_ecc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ stse_ReturnCode_t stse_ecc_generate_signature(
8686
stse_Handler_t *pSTSE,
8787
PLAT_UI8 slot_number,
8888
stse_ecc_key_type_t key_type,
89-
PLAT_UI8 *pMessage,
89+
const PLAT_UI8 *pMessage,
9090
PLAT_UI16 message_length,
9191
PLAT_UI8 *pSignature);
9292

services/stsafea/stsafea_ecc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ stse_ReturnCode_t stsafea_ecc_generate_signature(
343343
stse_Handler_t *pSTSE,
344344
PLAT_UI8 slot_number,
345345
stse_ecc_key_type_t key_type,
346-
PLAT_UI8 *pMessage,
346+
const PLAT_UI8 *pMessage,
347347
PLAT_UI16 message_length,
348348
PLAT_UI8 *pSignature) {
349349
PLAT_UI8 cmd_header = STSAFEA_CMD_GENERATE_SIGNATURE;
@@ -368,7 +368,7 @@ stse_ReturnCode_t stsafea_ecc_generate_signature(
368368
stse_frame_element_allocate_push(&CmdFrame, eCmd_header, STSAFEA_HEADER_SIZE, &cmd_header);
369369
stse_frame_element_allocate_push(&CmdFrame, eSlot_number, STSAFEA_SLOT_NUMBER_ID_SIZE, &slot_number);
370370
stse_frame_element_allocate_push(&CmdFrame, eMessage_length, STSAFEA_GENERIC_LENGTH_SIZE, (PLAT_UI8 *)&message_length);
371-
stse_frame_element_allocate_push(&CmdFrame, eMessage, message_length, pMessage);
371+
stse_frame_element_allocate_push(&CmdFrame, eMessage, message_length, (PLAT_UI8 *)pMessage);
372372
stse_frame_element_swap_byte_order(&eMessage_length);
373373

374374
stse_frame_allocate(RspFrame);

services/stsafea/stsafea_ecc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ stse_ReturnCode_t stsafea_ecc_generate_signature(
124124
stse_Handler_t *pSTSE,
125125
PLAT_UI8 slot_number,
126126
stse_ecc_key_type_t key_type,
127-
PLAT_UI8 *pMessage,
127+
const PLAT_UI8 *pMessage,
128128
PLAT_UI16 message_length,
129129
PLAT_UI8 *pSignature);
130130

services/stsafel/stsafel_ecc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
stse_ReturnCode_t stsafel_ecc_generate_signature(
2626
stse_Handler_t *pSTSE,
2727
stse_ecc_key_type_t key_type,
28-
PLAT_UI8 *pChallenge,
28+
const PLAT_UI8 *pChallenge,
2929
PLAT_UI16 challenge_length,
3030
PLAT_UI8 *pSignature) {
3131
PLAT_UI8 cmd_header = STSAFEL_CMD_GENERATE_SIGNATURE;
@@ -44,7 +44,7 @@ stse_ReturnCode_t stsafel_ecc_generate_signature(
4444
/*- Create CMD frame and populate elements */
4545
stse_frame_allocate(CmdFrame);
4646
stse_frame_element_allocate_push(&CmdFrame, eCmd_header, STSAFEL_HEADER_SIZE, &cmd_header);
47-
stse_frame_element_allocate_push(&CmdFrame, eChallenge, challenge_length, pChallenge);
47+
stse_frame_element_allocate_push(&CmdFrame, eChallenge, challenge_length, (PLAT_UI8 *)pChallenge);
4848
stse_frame_element_allocate_push(&CmdFrame, eInternal_data_subject, 1, &internal_data_subject);
4949

5050
/*- Create Rsp frame and populate elements*/

services/stsafel/stsafel_ecc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
stse_ReturnCode_t stsafel_ecc_generate_signature(
4949
stse_Handler_t *pSTSE,
5050
stse_ecc_key_type_t key_type,
51-
PLAT_UI8 *pChallenge,
51+
const PLAT_UI8 *pChallenge,
5252
PLAT_UI16 challenge_length,
5353
PLAT_UI8 *pSignature);
5454

0 commit comments

Comments
 (0)