csharp: Fix missing support for sbytes serialization

Author: moucha19-st

csharp/src/CompostRpc/Serialization.cs

@@ -22,6 +22,7 @@ private static readonly Dictionary<Type, Func<byte[], object>> _primitiveTypeDes
         = new()
     {
         {typeof(bool), (buf) => BitConverter.ToBoolean(buf, 0)},
+        {typeof(sbyte), (buf) => unchecked((sbyte)buf[0])},
         {typeof(short), (buf) => BitConverter.ToInt16(buf, 0)},
         {typeof(ushort), (buf) => BitConverter.ToUInt16(buf, 0)},
         {typeof(int), (buf) => BitConverter.ToInt32(buf, 0)},
@@ -282,6 +283,7 @@ public static void SerializePrimitive(object arg, byte[] buffer, ref BufferUnit
         int next_offset = arg switch
         {
             bool argt => CopyBytes(BitConverter.GetBytes(argt), 0, buffer, offset.Bytes, 1),
+            sbyte argt => CopyBytes(unchecked((byte)argt), buffer, offset.Bytes),
             short argt => CopyBytes(BitConverter.GetBytes(argt), 0, buffer, offset.Bytes, sizeof(short)),
             ushort argt => CopyBytes(BitConverter.GetBytes(argt), 0, buffer, offset.Bytes, sizeof(ushort)),
             uint argt => CopyBytes(BitConverter.GetBytes(argt), 0, buffer, offset.Bytes, sizeof(uint)),

csharp/tests/CompostRpc.UnitTests/SerializationTests.cs

@@ -22,6 +22,7 @@ public void BufferAllocationOverLimitTest()
     {
         {-1, 0, 4, [0xF0,0,0,0]},
         {-8, 0, 4, [0x80,0,0,0]},
+        {(sbyte)-1, 0, 8, [0xFF,0,0,0]},
         {0xFU, 6, 4, [0x03,0xC0,0,0]},
         {0xFU, 1, 4, [0x78,0,0,0]},
         {0xFU, 0, 4, [0xF0,0,0,0]},
@@ -80,4 +81,46 @@ public void PackedEnumSerializationTest()
         offset = BufferUnit.Zero;
         Assert.ThrowsAny<OverflowException>(() => Serialization.SerializePackedPrimitive(Status.Fail, buffer, ref offset, size));
     }
+
+    public static TheoryData<object> SignedPrimitiveSerializationTestData
+    {
+        get
+        {
+            var data = new TheoryData<object>
+            {
+                (object)(sbyte)-128,
+                (object)(sbyte)-1,
+                (object)(sbyte)0,
+                (object)(sbyte)127,
+                (object)short.MinValue,
+                (object)(short)-1,
+                (object)(short)0,
+                (object)short.MaxValue,
+                (object)int.MinValue,
+                (object)-1,
+                (object)0,
+                (object)int.MaxValue,
+                (object)long.MinValue,
+                (object)-1L,
+                (object)0L,
+                (object)long.MaxValue
+            };
+            return data;
+        }
+    }
+
+    [MemberData(nameof(SignedPrimitiveSerializationTestData))]
+    [Theory]
+    public void SignedPrimitiveSerializationTest(object value)
+    {
+        Type valueType = value.GetType();
+        byte[] buffer = new byte[Serialization.GetTypeSize(valueType).Bytes];
+        BufferUnit offset = BufferUnit.Zero;
+
+        Serialization.SerializePrimitive(value, buffer, ref offset);
+
+        offset = BufferUnit.Zero;
+        object actual = Serialization.DeserializePrimitive(valueType, buffer, ref offset);
+        Assert.Equal(value, actual);
+    }
 }