[core][dataflow] Fix some const. Revert data() constness for port.

Author: dlyr

src/Core/Containers/VariableSet.hpp

@@ -546,7 +546,7 @@ auto VariableSet::insertVariable( const std::string& name, const T& value )
 
 template <typename T>
 auto VariableSet::getVariable( const std::string& name ) -> T& {
-    return const_cast<T&>( const_cast<const VariableSet*>( this )->getVariable<T>( name ) );
+    return getVariableHandle<T>( name )->second;
 }
 
 template <typename T>

src/Dataflow/Core/Functionals/TransformNode.hpp

@@ -99,7 +99,7 @@ bool TransformNode<coll_t, v_t>::execute() {
     m_result.clear();
     // m_elements.reserve( inData.size() ); // --> this is not a requirement of
     // SequenceContainer
-    std::transform( inData.begin(), inData.end(), std::back_inserter( m_result ), f );
+    std::transform( inData.cbegin(), inData.cend(), std::back_inserter( m_result ), f );
 
     return true;
 }

src/Dataflow/Core/PortFactory.hpp

@@ -67,8 +67,8 @@ class RA_DATAFLOW_CORE_API PortFactory
                 return &( casted->data() );
             };
             m_output_setter[type] = []( PortBaseOut* port, std::any any ) {
-                const T* data = std::any_cast<const T*>( any );
-                auto casted   = dynamic_cast<PortOut<T>*>( port );
+                T* data     = std::any_cast<T*>( any );
+                auto casted = dynamic_cast<PortOut<T>*>( port );
                 casted->set_data( data );
             };
 

src/Dataflow/Core/PortIn.hpp

@@ -45,7 +45,7 @@ class RA_DATAFLOW_CORE_API PortBaseIn : public PortBase
     void set_default_value( const T& value );
 
     template <typename T>
-    const T& data();
+    T& data();
 
   protected:
     /**
@@ -106,7 +106,7 @@ class PortIn : public PortBaseIn,
      * Fails if note link nor has a default value, check with has_data beforehand if needed.
      * \return T& The reference to the data.
      */
-    const T& data();
+    T& data();
 
     /// \name Manage the connection with a PortOut.
     /// @{
@@ -197,12 +197,12 @@ void PortBaseIn::set_default_value( const T& value ) {
 }
 
 template <typename T>
-const T& PortBaseIn::data() {
+T& PortBaseIn::data() {
     return static_cast<PortIn<T>*>( this )->data();
 }
 
 template <typename T>
-const T& PortIn<T>::data() {
+T& PortIn<T>::data() {
     if ( is_linked() ) return m_from->data();
     if ( m_defaultValue ) return *m_defaultValue;
     CORE_ASSERT( false, "should not get here" );

src/Dataflow/Core/PortOut.hpp

@@ -30,7 +30,7 @@ class RA_DATAFLOW_CORE_API PortBaseOut : public PortBase
     /// Get data stored at this outpute port
     /// Check if this port type it the same as T
     template <typename T>
-    const T& data();
+    T& data();
 
     /// Set port data pointer.
     /// Check if this port type it the same as T
@@ -49,7 +49,7 @@ class RA_DATAFLOW_CORE_API PortBaseOut : public PortBase
         --m_linkCount;
         CORE_ASSERT( m_linkCount >= 0, "link count error" );
     }
-    virtual int link_count() { return m_linkCount; }
+    virtual int link_count() const { return m_linkCount; }
 
   protected:
     /// Constructor.
@@ -95,10 +95,10 @@ class PortOut : public PortBaseOut
     /// @}
 
     /// Gets a reference to the data this ports points to.
-    const T& data() { return *m_data; }
+    T& data() { return *m_data; }
     /// Takes a pointer to the data this port will point to.
     /// @param data The pointer to the data.
-    void set_data( const T* data ) { m_data = data; }
+    void set_data( T* data ) { m_data = data; }
     /// Returns true if the pointer to the data is not null.
     bool has_data() override { return ( m_data ); }
 
@@ -107,7 +107,7 @@ class PortOut : public PortBaseOut
      *
      * Use raw ptr since data belongs to the node and can be plain stack variable
      */
-    const T* m_data { nullptr };
+    T* m_data { nullptr };
 
 }; // class PortOut<T>
 
@@ -120,7 +120,7 @@ using PortBaseOutRawPtr = PortRawPtr<PortBaseOut>;
 using PortBaseOutPtr    = PortPtr<PortBaseOut>;
 
 template <typename T>
-const T& PortBaseOut::data() {
+T& PortBaseOut::data() {
     auto thisOut = dynamic_cast<PortOut<T>*>( this );
     if ( thisOut && thisOut->has_data() ) { return thisOut->data(); }